| Message ID | 20210428173021.38241-1-zbigniew.kempczynski@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Add relocation exceptions for two other platforms | expand |
On Wed, Apr 28, 2021 at 07:43:42PM +0000, Patchwork wrote: > Patch Details > > Series: drm/i915: Add relocation exceptions for two other platforms > URL: https://patchwork.freedesktop.org/series/89594/ > State: failure > Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20017/index.html > > CI Bug Log - changes from CI_DRM_10023_full -> Patchwork_20017_full > > Summary > > FAILURE > > Serious unknown changes coming with Patchwork_20017_full absolutely need > to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_20017_full, please notify your bug team to allow > them > to document this new failure mode, which will reduce false positives in > CI. > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_20017_full: > > IGT changes > > Possible regressions > > * igt@kms_flip_tiling@flip-changes-tiling-yf@edp-1-pipe-b: > * shard-skl: PASS -> FAIL I don't think enabling relocations on rkl/adl has the influence to skl but if anyone knows I'm wrong please share the details. Otherwise I would rerun the series to ensure this is incidental failure. -- Zbigniew > > Known issues > > Here are the changes found in Patchwork_20017_full that come from known > issues: > > IGT changes > > Issues hit > > * igt@gem_create@create-massive: > > * shard-skl: NOTRUN -> DMESG-WARN (i915#3002) > * igt@gem_ctx_persistence@idempotent: > > * shard-snb: NOTRUN -> SKIP (fdo#109271 / i915#1099) +2 similar > issues > * igt@gem_ctx_ringsize@active@bcs0: > > * shard-skl: PASS -> INCOMPLETE (i915#3316) > * igt@gem_ctx_shared@q-in-order: > > * shard-snb: NOTRUN -> SKIP (fdo#109271) +186 similar issues > * igt@gem_eio@unwedge-stress: > > * shard-tglb: PASS -> TIMEOUT (i915#2369 / i915#3063) > * igt@gem_exec_fair@basic-deadline: > > * shard-apl: NOTRUN -> FAIL (i915#2846) > * igt@gem_exec_fair@basic-none-solo@rcs0: > > * shard-kbl: NOTRUN -> FAIL (i915#2842) +1 similar issue > * igt@gem_exec_fair@basic-none@vcs1: > > * shard-iclb: NOTRUN -> FAIL (i915#2842) > * igt@gem_exec_fair@basic-none@vecs0: > > * shard-kbl: PASS -> FAIL (i915#2842) > * igt@gem_exec_fair@basic-throttle@rcs0: > > * shard-glk: PASS -> FAIL (i915#2842) > * igt@gem_exec_whisper@basic-forked: > > * shard-glk: PASS -> DMESG-WARN (i915#118 / i915#95) > * igt@gem_mmap_gtt@cpuset-medium-copy: > > * shard-iclb: PASS -> FAIL (i915#307) > * igt@gem_pwrite@basic-exhaustion: > > * shard-snb: NOTRUN -> WARN (i915#2658) > * igt@gen9_exec_parse@allowed-all: > > * shard-kbl: PASS -> DMESG-WARN (i915#1436 / i915#716) > * igt@gen9_exec_parse@bb-large: > > * shard-apl: NOTRUN -> FAIL (i915#3296) > * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait: > > * shard-kbl: NOTRUN -> SKIP (fdo#109271) +123 similar issues > * igt@i915_selftest@live@gt_pm: > > * shard-skl: NOTRUN -> DMESG-FAIL (i915#1886 / i915#2291) > * igt@kms_big_joiner@basic: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2705) > * igt@kms_color@pipe-a-ctm-0-5: > > * shard-skl: PASS -> DMESG-WARN (i915#1982) > * igt@kms_color_chamelium@pipe-a-ctm-0-75: > > * shard-kbl: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +10 similar > issues > * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: > > * shard-snb: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +12 similar > issues > * igt@kms_color_chamelium@pipe-c-ctm-max: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +19 similar > issues > * igt@kms_color_chamelium@pipe-d-degamma: > > * shard-skl: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +4 similar > issues > * igt@kms_content_protection@atomic-dpms: > > * shard-kbl: NOTRUN -> TIMEOUT (i915#1319) > * igt@kms_content_protection@uevent: > > * shard-kbl: NOTRUN -> FAIL (i915#2105) > * igt@kms_cursor_crc@pipe-b-cursor-256x256-random: > > * shard-skl: PASS -> FAIL (i915#54) > * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: > > * shard-skl: PASS -> FAIL (i915#2346) > * igt@kms_cursor_legacy@pipe-d-single-bo: > > * shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#533) +1 similar > issue > * igt@kms_flip@flip-vs-suspend@b-vga1: > > * shard-snb: PASS -> DMESG-WARN (i915#2772) > * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2642) > * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2672) > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite: > > * shard-skl: NOTRUN -> SKIP (fdo#109271) +40 similar issues > * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite: > > * shard-skl: PASS -> FAIL (i915#49) > * igt@kms_hdr@bpc-switch: > > * shard-skl: PASS -> FAIL (i915#1188) > * igt@kms_hdr@bpc-switch-suspend: > > * shard-kbl: PASS -> DMESG-WARN (i915#180) +5 similar issues > * igt@kms_pipe_crc_basic@read-crc-pipe-d: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#533) > * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: > > * shard-apl: NOTRUN -> FAIL (fdo#108145 / i915#265) +3 similar > issues > > * shard-kbl: NOTRUN -> FAIL (fdo#108145 / i915#265) +1 similar > issue > > * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: > > * shard-apl: NOTRUN -> FAIL (i915#265) > * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: > > * shard-skl: PASS -> FAIL (fdo#108145 / i915#265) > * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#658) +5 similar > issues > * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2: > > * shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#658) +3 similar > issues > * igt@kms_psr2_su@frontbuffer: > > * shard-iclb: PASS -> SKIP (fdo#109642 / fdo#111068 / i915#658) > * igt@kms_psr@psr2_sprite_blt: > > * shard-iclb: PASS -> SKIP (fdo#109441) +2 similar issues > * igt@kms_vblank@pipe-d-ts-continuation-idle: > > * shard-apl: NOTRUN -> SKIP (fdo#109271) +236 similar issues > * igt@kms_writeback@writeback-fb-id: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2437) > * igt@kms_writeback@writeback-invalid-parameters: > > * shard-skl: NOTRUN -> SKIP (fdo#109271 / i915#2437) > * igt@sysfs_clients@busy: > > * shard-skl: NOTRUN -> SKIP (fdo#109271 / i915#2994) > * igt@sysfs_clients@fair-7: > > * shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#2994) > * igt@sysfs_clients@recycle: > > * shard-apl: NOTRUN -> SKIP (fdo#109271 / i915#2994) +2 similar > issues > > Possible fixes > > * igt@gem_create@create-clear: > > * shard-iclb: FAIL (i915#3160) -> PASS > * igt@gem_exec_fair@basic-flow@rcs0: > > * shard-tglb: FAIL (i915#2842) -> PASS +1 similar issue > * igt@gem_exec_fair@basic-pace-share@rcs0: > > * shard-glk: FAIL (i915#2842) -> PASS > > * shard-kbl: FAIL (i915#2842) -> PASS > > * igt@gem_exec_fair@basic-throttle@rcs0: > > * shard-iclb: FAIL (i915#2849) -> PASS > * igt@gem_mmap_gtt@cpuset-basic-small-copy-xy: > > * shard-glk: FAIL (i915#307) -> PASS > * igt@kms_async_flips@alternate-sync-async-flip: > > * shard-skl: FAIL (i915#2521) -> PASS > * igt@kms_fbcon_fbt@fbc-suspend: > > * shard-apl: INCOMPLETE (i915#180) -> PASS > > * shard-kbl: INCOMPLETE (i915#155 / i915#180 / i915#636) -> PASS > > * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: > > * shard-kbl: DMESG-WARN (i915#180) -> PASS +8 similar issues > * igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1: > > * shard-skl: FAIL (i915#2122) -> PASS +2 similar issues > * igt@kms_psr@psr2_sprite_plane_move: > > * shard-iclb: SKIP (fdo#109441) -> PASS +1 similar issue > * igt@kms_universal_plane@universal-plane-gen9-features-pipe-a: > > * shard-skl: DMESG-WARN (i915#1982) -> PASS > > Warnings > > * igt@i915_pm_rc6_residency@rc6-fence: > > * shard-iclb: WARN (i915#2684) -> WARN (i915#2681 / i915#2684) +1 > similar issue > * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: > > * shard-iclb: SKIP (i915#658) -> SKIP (i915#2920) +2 similar issues > * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: > > * shard-iclb: SKIP (i915#2920) -> SKIP (i915#658) +1 similar issue > * igt@runner@aborted: > > * shard-kbl: (FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, > FAIL, FAIL) (i915#1436 / i915#180 / i915#1814 / i915#2292 / > i915#2505 / i915#3002 / i915#602 / i915#92) -> (FAIL, FAIL, FAIL, > FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL) (fdo#109271 / i915#1436 > / i915#180 / i915#1814 / i915#2505 / i915#3002 / i915#716) > > * shard-skl: (FAIL, FAIL) (i915#2029 / i915#3002) -> (FAIL, FAIL, > FAIL, FAIL, FAIL, FAIL) (i915#198 / i915#2029 / i915#3002 / > i915#3057) > > Participating hosts (11 -> 11) > > No changes in participating hosts > > Build changes > > * Linux: CI_DRM_10023 -> Patchwork_20017 > > CI-20190529: 20190529 > CI_DRM_10023: a8bf9e284933fa5c1cb821b48ba95821e5d1cc3f @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_6076: 9ab0820dbd07781161c1ace6973ea222fd24e53a @ > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_20017: fcbabd445c5707a6699da0a665a399273dc73ab0 @ > git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ > git://anongit.freedesktop.org/piglit
On Thu, Apr 29, 2021 at 10:16:31AM +0200, Zbigniew Kempczyński wrote: > On Wed, Apr 28, 2021 at 07:43:42PM +0000, Patchwork wrote: > > Patch Details > > > > Series: drm/i915: Add relocation exceptions for two other platforms > > URL: https://patchwork.freedesktop.org/series/89594/ > > State: failure > > Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20017/index.html > > > > CI Bug Log - changes from CI_DRM_10023_full -> Patchwork_20017_full > > > > Summary > > > > FAILURE > > > > Serious unknown changes coming with Patchwork_20017_full absolutely need > > to be > > verified manually. > > > > If you think the reported changes have nothing to do with the changes > > introduced in Patchwork_20017_full, please notify your bug team to allow > > them > > to document this new failure mode, which will reduce false positives in > > CI. > > > > Possible new issues > > > > Here are the unknown changes that may have been introduced in > > Patchwork_20017_full: > > > > IGT changes > > > > Possible regressions > > > > * igt@kms_flip_tiling@flip-changes-tiling-yf@edp-1-pipe-b: > > * shard-skl: PASS -> FAIL > > I don't think enabling relocations on rkl/adl has the influence to skl > but if anyone knows I'm wrong please share the details. Otherwise > I would rerun the series to ensure this is incidental failure. I suspect this is due to a bug in igt kms legacy commits. At least I see a failing alpha blend test on pipe B in the log before this one, which is how the bug hits us usually. I'm trying to fix it atm, but unfortunately the fix is revealing other harder to solve bugs which need to be fixed first :/
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 297143511f99..6d621898698f 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -496,11 +496,14 @@ eb_validate_vma(struct i915_execbuffer *eb, struct drm_i915_gem_exec_object2 *entry, struct i915_vma *vma) { - /* Relocations are disallowed for all platforms after TGL-LP. This - * also covers all platforms with local memory. + /* + * Relocations are disallowed starting from gen12 with some exceptions + * - TGL/RKL/ADL. */ if (entry->relocation_count && - INTEL_GEN(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915)) + INTEL_GEN(eb->i915) >= 12 && !(IS_TIGERLAKE(eb->i915) || + IS_ROCKETLAKE(eb->i915) || + IS_ALDERLAKE_S(eb->i915))) return -EINVAL; if (unlikely(entry->flags & eb->invalid_flags))
We have established previously we stop using relocations starting from gen12 platforms with Tigerlake as an exception. Unfortunately we need extend transition period and support relocations for two other igfx platforms - Rocketlake and Alderlake. As Alderlake is coming in two variants - S and P and only S landed upstream already we will need to extend the relocation enabling condition one more time for P version in the future. Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jason Ekstrand <jason@jlekstrand.net> --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)