diff mbox series

[CI] drm/i915: Initialize err in remap_io_sg()

Message ID 20210517202117.179303-1-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [CI] drm/i915: Initialize err in remap_io_sg() | expand

Commit Message

Souza, Jose May 17, 2021, 8:21 p.m. UTC 
If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
iteration, err is uninitialized causing a wrong call to zap_vma_ptes().

But that is impossible to happen as a scatterlist must have at least
one valid segment.
Anyways to avoid more reports from static checkers initializing ret
here.

Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Ausmus <james.ausmus@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/i915_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Souza, Jose May 17, 2021, 8:20 p.m. UTC | #1 
Rodrigo, Jani: So "i915: fix remap_io_sg to verify the pgprot" was not merged into any drm-intel branch, how should I merge this after get CI green
light?

On Mon, 2021-05-17 at 13:21 -0700, José Roberto de Souza wrote:
> If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
> iteration, err is uninitialized causing a wrong call to zap_vma_ptes().
> 
> But that is impossible to happen as a scatterlist must have at least
> one valid segment.
> Anyways to avoid more reports from static checkers initializing ret
> here.
> 
> Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot")
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: James Ausmus <james.ausmus@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c
> index 4c8cd08c672d..25576fa73ff0 100644
> --- a/drivers/gpu/drm/i915/i915_mm.c
> +++ b/drivers/gpu/drm/i915/i915_mm.c
> @@ -47,7 +47,7 @@ int remap_io_sg(struct vm_area_struct *vma,
>  		struct scatterlist *sgl, resource_size_t iobase)
>  {
>  	unsigned long pfn, len, remapped = 0;
> -	int err;
> +	int err = 0;
>  
>  	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
>  	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);
Jani Nikula May 17, 2021, 8:31 p.m. UTC | #2 
On Mon, 17 May 2021, "Souza, Jose" <jose.souza@intel.com> wrote:
> Rodrigo, Jani: So "i915: fix remap_io_sg to verify the pgprot" was not merged into any drm-intel branch, how should I merge this after get CI green
> light?

I think Rodrigo should do a backmerge.

BR,
Jani.


>
> On Mon, 2021-05-17 at 13:21 -0700, José Roberto de Souza wrote:
>> If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
>> iteration, err is uninitialized causing a wrong call to zap_vma_ptes().
>> 
>> But that is impossible to happen as a scatterlist must have at least
>> one valid segment.
>> Anyways to avoid more reports from static checkers initializing ret
>> here.
>> 
>> Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot")
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: James Ausmus <james.ausmus@intel.com>
>> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_mm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c
>> index 4c8cd08c672d..25576fa73ff0 100644
>> --- a/drivers/gpu/drm/i915/i915_mm.c
>> +++ b/drivers/gpu/drm/i915/i915_mm.c
>> @@ -47,7 +47,7 @@ int remap_io_sg(struct vm_area_struct *vma,
>>  		struct scatterlist *sgl, resource_size_t iobase)
>>  {
>>  	unsigned long pfn, len, remapped = 0;
>> -	int err;
>> +	int err = 0;
>>  
>>  	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
>>  	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi May 17, 2021, 9:51 p.m. UTC | #3 
On Mon, 2021-05-17 at 23:31 +0300, Jani Nikula wrote:
> On Mon, 17 May 2021, "Souza, Jose" <jose.souza@intel.com> wrote:
> > Rodrigo, Jani: So "i915: fix remap_io_sg to verify the pgprot" was
> > not merged into any drm-intel branch, how should I merge this after
> > get CI green
> > light?
> 
> I think Rodrigo should do a backmerge.

done... pushing right now... sorry for the delay

> 
> BR,
> Jani.
> 
> 
> > 
> > On Mon, 2021-05-17 at 13:21 -0700, José Roberto de Souza wrote:
> > > If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the
> > > first
> > > iteration, err is uninitialized causing a wrong call to
> > > zap_vma_ptes().
> > > 
> > > But that is impossible to happen as a scatterlist must have at
> > > least
> > > one valid segment.
> > > Anyways to avoid more reports from static checkers initializing
> > > ret
> > > here.
> > > 
> > > Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the
> > > pgprot")
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > Cc: Christoph Hellwig <hch@lst.de>
> > > Signed-off-by: James Ausmus <james.ausmus@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_mm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_mm.c
> > > b/drivers/gpu/drm/i915/i915_mm.c
> > > index 4c8cd08c672d..25576fa73ff0 100644
> > > --- a/drivers/gpu/drm/i915/i915_mm.c
> > > +++ b/drivers/gpu/drm/i915/i915_mm.c
> > > @@ -47,7 +47,7 @@ int remap_io_sg(struct vm_area_struct *vma,
> > >                 struct scatterlist *sgl, resource_size_t iobase)
> > >  {
> > >         unsigned long pfn, len, remapped = 0;
> > > -       int err;
> > > +       int err = 0;
> > >  
> > >         /* We rely on prevalidation of the io-mapping to skip
> > > track_pfn(). */
> > >         GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) !=
> > > EXPECTED_FLAGS);
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
Souza, Jose May 18, 2021, 6 p.m. UTC | #4 
On Tue, 2021-05-18 at 05:56 +0000, Patchwork wrote:
Patch Details
Series: drm/i915: Initialize err in remap_io_sg()
URL:    https://patchwork.freedesktop.org/series/90258/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/index.html
CI Bug Log - changes from CI_DRM_10093_full -> Patchwork_20139_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_20139_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20139_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_20139_full:

IGT changes
Possible regressions

  *   igt@api_intel_bb@destroy-bb:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk5/igt@api_intel_bb@destroy-bb.html> -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@api_intel_bb@destroy-bb.html> +3 similar issues
  *   igt@gem_ppgtt@blt-vs-render-ctx0:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@gem_ppgtt@blt-vs-render-ctx0.html>
  *   igt@kms_atomic_interruptible@legacy-setmode:

     *   shard-glk: NOTRUN -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@kms_atomic_interruptible@legacy-setmode.html> +1 similar issue
  *   igt@prime_mmap_coherency@read:

     *   shard-snb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb5/igt@prime_mmap_coherency@read.html>

Regressions not related.
Patch pushed, thanks Christoph, Rodrigo and Jani.

Warnings

  *   igt@gem_ctx_freq@sysfs:
     *   shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk5/igt@gem_ctx_freq@sysfs.html> ([i915#3457]) -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@gem_ctx_freq@sysfs.html>

Known issues

Here are the changes found in Patchwork_20139_full that come from known issues:

IGT changes
Issues hit

  *   igt@feature_discovery@display-3x:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@feature_discovery@display-3x.html> ([i915#1839])
  *   igt@gem_create@create-clear:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk6/igt@gem_create@create-clear.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk4/igt@gem_create@create-clear.html> ([i915#3160])
  *   igt@gem_create@create-massive:

     *   shard-kbl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@gem_create@create-massive.html> ([i915#3002])

     *   shard-skl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@gem_create@create-massive.html> ([i915#3002])

  *   igt@gem_ctx_persistence@engines-mixed:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb7/igt@gem_ctx_persistence@engines-mixed.html> ([fdo#109271] / [i915#1099]) +4 similar issues
  *   igt@gem_ctx_persistence@heartbeat-many:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk6/igt@gem_ctx_persistence@heartbeat-many.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk6/igt@gem_ctx_persistence@heartbeat-many.html> ([i915#3457]) +30 similar issues
  *   igt@gem_ctx_persistence@many-contexts:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-tglb8/igt@gem_ctx_persistence@many-contexts.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html> ([i915#2410] / [i915#3457])
  *   igt@gem_ctx_ringsize@active@bcs0:

     *   shard-skl: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@gem_ctx_ringsize@active@bcs0.html> ([i915#3316] / [i915#3457])
  *   igt@gem_exec_fair@basic-none@vcs1:

     *   shard-iclb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@gem_exec_fair@basic-none@vcs1.html> ([i915#2842] / [i915#3457]) +4 similar issues
  *   igt@gem_exec_fair@basic-pace@rcs0:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html> ([i915#2842] / [i915#3457])
  *   igt@gem_exec_fair@basic-pace@vcs0:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html> ([i915#2842] / [i915#3457]) +1 similar issue
  *   igt@gem_exec_fair@basic-throttle@rcs0:

     *   shard-tglb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb8/igt@gem_exec_fair@basic-throttle@rcs0.html> ([i915#2842] / [i915#3457])
  *   igt@gem_exec_gttfill@engines@rcs0:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk3/igt@gem_exec_gttfill@engines@rcs0.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk8/igt@gem_exec_gttfill@engines@rcs0.html> ([i915#118] / [i915#3457] / [i915#95])
  *   igt@gem_exec_reloc@basic-wide-active@rcs0:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb6/igt@gem_exec_reloc@basic-wide-active@rcs0.html> ([i915#2389] / [i915#3457]) +2 similar issues
  *   igt@gem_exec_schedule@u-fairslice@rcs0:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@gem_exec_schedule@u-fairslice@rcs0.html> ([i915#3457]) +3 similar issues
  *   igt@gem_exec_schedule@u-submit-early-slice@vcs0:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-apl8/igt@gem_exec_schedule@u-submit-early-slice@vcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl3/igt@gem_exec_schedule@u-submit-early-slice@vcs0.html> ([i915#3457]) +3 similar issues
  *   igt@gem_exec_schedule@u-submit-late-slice@vecs0:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk5/igt@gem_exec_schedule@u-submit-late-slice@vecs0.html> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@gem_exec_schedule@u-submit-late-slice@vecs0.html> ([i915#3457])
  *   igt@gem_exec_suspend@basic-s3:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-kbl2/igt@gem_exec_suspend@basic-s3.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@gem_exec_suspend@basic-s3.html> ([i915#180]) +1 similar issue
  *   igt@gem_mmap_gtt@big-copy:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-iclb4/igt@gem_mmap_gtt@big-copy.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb7/igt@gem_mmap_gtt@big-copy.html> ([i915#307])
  *   igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-iclb1/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb1/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html> ([i915#2910] / [i915#3468])

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-kbl7/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl4/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html> ([i915#3468])

  *   igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-tglb1/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html> ([i915#3468])

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk1/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk3/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html> ([i915#3468])

  *   igt@gem_mmap_gtt@fault-concurrent-y:

     *   shard-snb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb7/igt@gem_mmap_gtt@fault-concurrent-y.html> ([i915#3468])
  *   igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-ccs:

     *   shard-iclb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@gem_render_copy@y-tiled-ccs-to-yf-tiled-ccs.html> ([i915#3468])
  *   igt@gem_render_copy@yf-tiled-ccs-to-x-tiled:

     *   shard-apl: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl6/igt@gem_render_copy@yf-tiled-ccs-to-x-tiled.html> ([i915#3468]) +2 similar issues
  *   igt@gem_render_copy@yf-tiled-ccs-to-y-tiled-ccs:

     *   shard-glk: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@gem_render_copy@yf-tiled-ccs-to-y-tiled-ccs.html> ([i915#3468])
  *   igt@gem_render_copy@yf-tiled-ccs-to-yf-tiled-ccs:

     *   shard-tglb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@gem_render_copy@yf-tiled-ccs-to-yf-tiled-ccs.html> ([i915#3468])
  *   igt@gem_spin_batch@spin-each:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-skl4/igt@gem_spin_batch@spin-each.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl4/igt@gem_spin_batch@spin-each.html> ([i915#2898] / [i915#3457])

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl6/igt@gem_spin_batch@spin-each.html> ([i915#2898] / [i915#3457])

  *   igt@gem_userptr_blits@dmabuf-sync:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@gem_userptr_blits@dmabuf-sync.html> ([fdo#109271] / [i915#3323])
  *   igt@gem_userptr_blits@input-checking:

     *   shard-apl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@gem_userptr_blits@input-checking.html> ([i915#3002])

     *   shard-snb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb6/igt@gem_userptr_blits@input-checking.html> ([i915#3002])

  *   igt@gem_userptr_blits@set-cache-level:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb6/igt@gem_userptr_blits@set-cache-level.html> ([i915#3324])
  *   igt@gem_userptr_blits@vma-merge:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb7/igt@gem_userptr_blits@vma-merge.html> ([i915#2724] / [i915#3457])
  *   igt@gem_workarounds@suspend-resume-context:

     *   shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-kbl1/igt@gem_workarounds@suspend-resume-context.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@gem_workarounds@suspend-resume-context.html> ([i915#180] / [i915#3457])
  *   igt@gen3_render_linear_blits:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@gen3_render_linear_blits.html> ([fdo#109289])
  *   igt@i915_hangman@engine-error@vecs0:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl7/igt@i915_hangman@engine-error@vecs0.html> ([fdo#109271]) +31 similar issues
  *   igt@i915_pm_lpsp@screens-disabled:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@i915_pm_lpsp@screens-disabled.html> ([fdo#109271]) +36 similar issues
  *   igt@i915_pm_rpm@cursor-dpms:

     *   shard-glk: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@i915_pm_rpm@cursor-dpms.html> ([i915#3457])
  *   igt@i915_pm_rps@min-max-config-loaded:

     *   shard-snb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb2/igt@i915_pm_rps@min-max-config-loaded.html> ([i915#3457]) +2 similar issues
  *   igt@i915_pm_rps@waitboost:

     *   shard-skl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@i915_pm_rps@waitboost.html> ([i915#3457])

     *   shard-kbl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@i915_pm_rps@waitboost.html> ([i915#3457])

  *   igt@kms_big_fb@linear-32bpp-rotate-90:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_big_fb@linear-32bpp-rotate-90.html> ([fdo#110725] / [fdo#111614])
  *   igt@kms_chamelium@hdmi-hpd-fast:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_chamelium@hdmi-hpd-fast.html> ([fdo#109284] / [fdo#111827]) +3 similar issues
  *   igt@kms_chamelium@vga-edid-read:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@kms_chamelium@vga-edid-read.html> ([fdo#109284] / [fdo#111827])
  *   igt@kms_color@pipe-d-ctm-0-25:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_color@pipe-d-ctm-0-25.html> ([fdo#109278] / [i915#1149])
  *   igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html> ([fdo#109271] / [fdo#111827]) +23 similar issues
  *   igt@kms_color_chamelium@pipe-c-ctm-green-to-red:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html> ([fdo#109271] / [fdo#111827])
  *   igt@kms_color_chamelium@pipe-c-degamma:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@kms_color_chamelium@pipe-c-degamma.html> ([fdo#109271] / [fdo#111827]) +3 similar issues
  *   igt@kms_content_protection@lic:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_content_protection@lic.html> ([fdo#109300] / [fdo#111066])
  *   igt@kms_content_protection@uevent:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@kms_content_protection@uevent.html> ([i915#2105])
  *   igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html> ([i915#2124] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html> ([i915#3444] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:

     *   shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html> ([i915#3444] / [i915#3457]) +4 similar issues
  *   igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:

     *   shard-kbl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html> ([i915#3444] / [i915#3457]) +5 similar issues
  *   igt@kms_cursor_crc@pipe-a-cursor-suspend:

     *   shard-kbl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html> ([i915#180] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding:

     *   shard-tglb: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb8/igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding.html> ([i915#3457])
  *   igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk2/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk1/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html> ([i915#3444] / [i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-b-cursor-256x256-random:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html> ([i915#3457]) +4 similar issues
  *   igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html> ([i915#3444] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque.html> ([i915#3444] / [i915#3457]) +2 similar issues
  *   igt@kms_cursor_crc@pipe-c-cursor-256x85-random:

     *   shard-tglb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html> ([i915#2124] / [i915#3457])
  *   igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_cursor_crc@pipe-c-cursor-32x10-offscreen.html> ([fdo#109278] / [i915#3457]) +2 similar issues
  *   igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:

     *   shard-iclb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html> ([i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-c-cursor-dpms:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-iclb6/igt@kms_cursor_crc@pipe-c-cursor-dpms.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb8/igt@kms_cursor_crc@pipe-c-cursor-dpms.html> ([i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding.html> ([fdo#109271] / [i915#3457]) +5 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-256x85-onscreen:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@kms_cursor_crc@pipe-d-cursor-256x85-onscreen.html> ([fdo#109271] / [i915#3457]) +1 similar issue
  *   igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl6/igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement.html> ([fdo#109271] / [i915#3457]) +10 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-32x10-sliding:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb2/igt@kms_cursor_crc@pipe-d-cursor-32x10-sliding.html> ([fdo#109271] / [i915#3457]) +64 similar issues
  *   igt@kms_cursor_crc@pipe-d-cursor-512x170-onscreen:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@kms_cursor_crc@pipe-d-cursor-512x170-onscreen.html> ([fdo#109271] / [i915#3457]) +1 similar issue
  *   igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb5/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html> ([fdo#109271]) +413 similar issues
  *   igt@kms_flip@2x-flip-vs-wf_vblank:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_flip@2x-flip-vs-wf_vblank.html> ([fdo#109274])
  *   igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html> ([fdo#109271] / [i915#2642])
  *   igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-1-pipe-b:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk3/igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-1-pipe-b.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk8/igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-1-pipe-b.html> ([i915#3468])
  *   igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-2-pipe-b:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk3/igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-2-pipe-b.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk8/igt@kms_flip_tiling@flip-changes-tiling@hdmi-a-2-pipe-b.html> ([i915#3484])
  *   igt@kms_flip_tiling@flip-yf-tiled:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@kms_flip_tiling@flip-yf-tiled.html> ([fdo#111615])
  *   igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:

     *   shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html> ([fdo#111825]) +4 similar issues
  *   igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-mmap-cpu.html> ([fdo#109280]) +8 similar issues
  *   igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt:

     *   shard-glk: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt.html> ([fdo#109271]) +2 similar issues
  *   igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html> ([fdo#109271] / [i915#533])
  *   igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html> ([fdo#108145] / [i915#265])
  *   igt@kms_plane_alpha_blend@pipe-d-coverage-vs-premult-vs-constant:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@kms_plane_alpha_blend@pipe-d-coverage-vs-premult-vs-constant.html> ([fdo#109278]) +4 similar issues
  *   igt@kms_plane_cursor@pipe-a-overlay-size-256:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html> ([i915#2657] / [i915#3457])
  *   igt@kms_plane_cursor@pipe-a-primary-size-128:

     *   shard-snb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-snb6/igt@kms_plane_cursor@pipe-a-primary-size-128.html> ([i915#2657]) +2 similar issues
  *   igt@kms_plane_cursor@pipe-c-viewport-size-256:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk5/igt@kms_plane_cursor@pipe-c-viewport-size-256.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk1/igt@kms_plane_cursor@pipe-c-viewport-size-256.html> ([i915#2657])
  *   igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html> ([fdo#109271] / [i915#658]) +1 similar issue
  *   igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html> ([fdo#109271] / [i915#658])
  *   igt@kms_psr2_sf@plane-move-sf-dmg-area-3:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html> ([fdo#109271] / [i915#658]) +2 similar issues
  *   igt@kms_pwrite_crc:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10093/shard-glk8/igt@kms_pwrite_crc.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-glk1/igt@kms_pwrite_crc.html> ([i915#3192])
  *   igt@kms_vblank@pipe-d-ts-continuation-idle:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@kms_vblank@pipe-d-ts-continuation-idle.html> ([fdo#109271]) +62 similar issues
  *   igt@kms_writeback@writeback-check-output:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl6/igt@kms_writeback@writeback-check-output.html> ([fdo#109271] / [i915#2437]) +1 similar issue
  *   igt@nouveau_crc@pipe-d-ctx-flip-detection:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@nouveau_crc@pipe-d-ctx-flip-detection.html> ([fdo#109278] / [i915#2530])
  *   igt@perf_pmu@most-busy-idle-check-all@rcs0:

     *   shard-apl: NOTRUN -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl6/igt@perf_pmu@most-busy-idle-check-all@rcs0.html> ([i915#3457]) +2 similar issues
  *   igt@perf_pmu@rc6-suspend:

     *   shard-kbl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl7/igt@perf_pmu@rc6-suspend.html> ([i915#180])
  *   igt@prime_nv_test@i915_import_pread_pwrite:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-iclb4/igt@prime_nv_test@i915_import_pread_pwrite.html> ([fdo#109291])
  *   igt@sysfs_clients@busy:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-skl5/igt@sysfs_clients@busy.html> ([fdo#109271] / [i915#2994]) +1 similar issue
  *   igt@sysfs_clients@fair-7:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@sysfs_clients@fair-7.html> ([fdo#109271] / [i915#2994])
  *   igt@sysfs_clients@recycle:

     *   shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-kbl2/igt@sysfs_clients@recycle.html> ([fdo#109271] / [i915#2994])
  *   igt@sysfs_preempt_timeout@timeout@vcs0:

     *   shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20139/shard-apl7/igt@sysfs_preempt_timeout@timeout@vcs0.html> ([i915#1755] / [i915#3457]) +1 similar issue
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c
index 4c8cd08c672d..25576fa73ff0 100644
--- a/drivers/gpu/drm/i915/i915_mm.c
+++ b/drivers/gpu/drm/i915/i915_mm.c
@@ -47,7 +47,7 @@  int remap_io_sg(struct vm_area_struct *vma,
 		struct scatterlist *sgl, resource_size_t iobase)
 {
 	unsigned long pfn, len, remapped = 0;
-	int err;
+	int err = 0;
 
 	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
 	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);