| Message ID | 20210518082701.997251-8-thomas.hellstrom@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Move LMEM (VRAM) management over to TTM | expand |
Op 18-05-2021 om 10:26 schreef Thomas Hellström: > For the upcoming kmapping i915 memcpy_move, export ttm_bo_tt_destroy(). > A future change might be to move the new memcpy_move into ttm, replacing > the old ioremapping one. > > Cc: Christian König <christian.koenig@amd.com> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > drivers/gpu/drm/ttm/ttm_bo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index ca1b098b6a56..4479c55aaa1d 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -1221,3 +1221,4 @@ void ttm_bo_tt_destroy(struct ttm_buffer_object *bo) > ttm_tt_destroy(bo->bdev, bo->ttm); > bo->ttm = NULL; > } > +EXPORT_SYMBOL(ttm_bo_tt_destroy); Looks sane, could we reorder the patches to put all ttm changes first? Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Am 18.05.21 um 10:26 schrieb Thomas Hellström: > For the upcoming kmapping i915 memcpy_move, export ttm_bo_tt_destroy(). > A future change might be to move the new memcpy_move into ttm, replacing > the old ioremapping one. Well this is an upfront NAK for that approach. I've worked quite hard to not export those functions any more since this is not something drivers should be allowed to mess with. If you need this we should probably move the functionality into TTM instead. Regards, Christian. > > Cc: Christian König <christian.koenig@amd.com> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > drivers/gpu/drm/ttm/ttm_bo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index ca1b098b6a56..4479c55aaa1d 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -1221,3 +1221,4 @@ void ttm_bo_tt_destroy(struct ttm_buffer_object *bo) > ttm_tt_destroy(bo->bdev, bo->ttm); > bo->ttm = NULL; > } > +EXPORT_SYMBOL(ttm_bo_tt_destroy);
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index ca1b098b6a56..4479c55aaa1d 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -1221,3 +1221,4 @@ void ttm_bo_tt_destroy(struct ttm_buffer_object *bo) ttm_tt_destroy(bo->bdev, bo->ttm); bo->ttm = NULL; } +EXPORT_SYMBOL(ttm_bo_tt_destroy);
For the upcoming kmapping i915 memcpy_move, export ttm_bo_tt_destroy(). A future change might be to move the new memcpy_move into ttm, replacing the old ioremapping one. Cc: Christian König <christian.koenig@amd.com> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + 1 file changed, 1 insertion(+)