From patchwork Wed Aug 25 03:25:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lee, Shawn C" X-Patchwork-Id: 12456293 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817BCC4338F for ; Wed, 25 Aug 2021 03:22:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B9A261052 for ; Wed, 25 Aug 2021 03:22:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B9A261052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F78A6E104; Wed, 25 Aug 2021 03:22:44 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E67766E104 for ; Wed, 25 Aug 2021 03:22:43 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="204574021" X-IronPort-AV: E=Sophos;i="5.84,349,1620716400"; d="scan'208";a="204574021" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 20:22:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,349,1620716400"; d="scan'208";a="643392517" Received: from shawnle1-build-machine.itwn.intel.com ([10.5.253.12]) by orsmga005.jf.intel.com with ESMTP; 24 Aug 2021 20:22:41 -0700 From: Lee Shawn C To: intel-gfx@lists.freedesktop.org Cc: Lee Shawn C , Chris Wilson , Mika Kuoppala , Ville Syrjala , Jani Nikula , Cooper Chiou , Huang Derek Date: Wed, 25 Aug 2021 11:25:09 +0800 Message-Id: <20210825032509.12230-1-shawn.c.lee@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [Intel-gfx] [PATCH] drm/i915/gt: do_idle_maps on gen8 and later platform. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" We are seeing "DMAR faults [reason 7, next page table ptr is invalid]" on TGL while running suspend stress test. Refer to 'commit 84361529ee85 ("drm/i915: Sleep around performing iommu unmaps on Tigerlake")'. Driver check needs_idle_maps() in i915_gmch_probe() but it applicable for gen5 and earlier generations. Add needs_idle_maps() in gen8_gmch_probe() then it will benifit gen8 and later platform. Cc: Chris Wilson Cc: Mika Kuoppala Cc: Ville Syrjala Cc: Jani Nikula Cc: Cooper Chiou Cc: Huang Derek Signed-off-by: Lee Shawn C --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c index de3ac58fceec..9510da0ae6b5 100644 --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c @@ -911,6 +911,12 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt) ggtt->vm.alloc_pt_dma = alloc_pt_dma; + if (needs_idle_maps(i915)) { + drm_notice(&i915->drm, + "Flushing DMA requests before IOMMU unmaps; performance may be degraded\n"); + ggtt->do_idle_maps = true; + } + ggtt->vm.total = (size / sizeof(gen8_pte_t)) * I915_GTT_PAGE_SIZE; ggtt->vm.cleanup = gen6_gmch_remove; ggtt->vm.insert_page = gen8_ggtt_insert_page;