diff mbox series

[v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation

Message ID 20210914212507.177511-1-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation | expand

Commit Message

Souza, Jose Sept. 14, 2021, 9:25 p.m. UTC 
As the SU_REGION_START begins at 0, the SU_REGION_END should be number
of lines - 1.

BSpec: 50424
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Souza, Jose Sept. 17, 2021, 5:52 p.m. UTC | #1 
On Fri, 2021-09-17 at 04:29 +0000, Patchwork wrote:
> Patch Details
> Series:	series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev5)
> URL:	https://patchwork.freedesktop.org/series/94674/
> State:	failure
> Details:	https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21082/index.html
> CI Bug Log - changes from CI_DRM_10600_full -> Patchwork_21082_full
> Summary
> FAILURE
> 
> Serious unknown changes coming with Patchwork_21082_full absolutely need to be
> verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_21082_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> 
> Possible new issues
> Here are the unknown changes that may have been introduced in Patchwork_21082_full:
> 
> IGT changes
> Possible regressions
> igt@i915_pm_rpm@gem-mmap-type:

Another INCOMPLETE because of audio issues, not related.

> 
> shard-kbl: NOTRUN -> INCOMPLETE
> igt@kms_atomic@plane-invalid-params:
> 
> shard-iclb: PASS -> DMESG-WARN

This is a missing FBC case, not related to this changes.

Pushing this series even with CI not 100% back, 4 of 5 patches here only affects a feature that is not enabled by default the remaining one only makes
sure that EDP_PSR2_FRAME_BEFORE_SU() minimum is 2 and not 1.

The discussing going in 'drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled' are not specific about that patch.

Thanks for the reviews GG.

> Known issues
> Here are the changes found in Patchwork_21082_full that come from known issues:
> 
> IGT changes
> Issues hit
> igt@device_reset@unbind-reset-rebind:
> 
> shard-kbl: NOTRUN -> DMESG-WARN (i915#4130)
> igt@feature_discovery@chamelium:
> 
> shard-skl: NOTRUN -> SKIP (fdo#109271) +18 similar issues
> igt@gem_eio@unwedge-stress:
> 
> shard-skl: PASS -> TIMEOUT (i915#2369 / i915#3063)
> igt@gem_exec_fair@basic-none-solo@rcs0:
> 
> shard-tglb: NOTRUN -> FAIL (i915#2842)
> igt@gem_exec_fair@basic-pace@vcs0:
> 
> shard-kbl: PASS -> FAIL (i915#2842)
> igt@gem_exec_fair@basic-pace@vcs1:
> 
> shard-iclb: NOTRUN -> FAIL (i915#2842)
> igt@gem_pread@exhaustion:
> 
> shard-tglb: NOTRUN -> WARN (i915#2658)
> 
> shard-kbl: NOTRUN -> WARN (i915#2658)
> 
> igt@gem_userptr_blits@input-checking:
> 
> shard-kbl: NOTRUN -> DMESG-WARN (i915#3002)
> igt@gen9_exec_parse@bb-start-cmd:
> 
> shard-tglb: NOTRUN -> SKIP (i915#2856)
> igt@i915_pm_rc6_residency@media-rc6-accuracy:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#109289 / fdo#111719)
> igt@i915_pm_rpm@modeset-pc8-residency-stress:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#109506 / i915#2411)
> igt@i915_suspend@fence-restore-untiled:
> 
> shard-kbl: NOTRUN -> DMESG-WARN (i915#180) +1 similar issue
> igt@kms_atomic@crtc-invalid-params-fence:
> 
> shard-iclb: PASS -> DMESG-WARN (i915#3728)
> igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
> 
> shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#3777) +1 similar issue
> igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
> 
> shard-skl: NOTRUN -> FAIL (i915#3763)
> igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#111615) +1 similar issue
> igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
> 
> shard-tglb: NOTRUN -> SKIP (i915#3689)
> igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
> 
> shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#3886) +6 similar issues
> igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
> 
> shard-skl: NOTRUN -> SKIP (fdo#109271 / i915#3886) +1 similar issue
> igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
> 
> shard-tglb: NOTRUN -> SKIP (i915#3689 / i915#3886) +2 similar issues
> igt@kms_chamelium@dp-hpd-storm:
> 
> shard-skl: NOTRUN -> SKIP (fdo#109271 / fdo#111827)
> igt@kms_chamelium@hdmi-hpd-for-each-pipe:
> 
> shard-kbl: NOTRUN -> SKIP (fdo#109271 / fdo#111827) +12 similar issues
> igt@kms_color_chamelium@pipe-c-gamma:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#109284 / fdo#111827) +6 similar issues
> igt@kms_cursor_crc@pipe-c-cursor-512x170-rapid-movement:
> 
> shard-tglb: NOTRUN -> SKIP (i915#3359) +1 similar issue
> igt@kms_cursor_crc@pipe-d-cursor-512x170-sliding:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#109279 / i915#3359)
> igt@kms_cursor_crc@pipe-d-cursor-suspend:
> 
> shard-kbl: NOTRUN -> SKIP (fdo#109271) +98 similar issues
> igt@kms_flip@flip-vs-expired-vblank@a-edp1:
> 
> shard-skl: PASS -> FAIL (i915#79) +1 similar issue
> igt@kms_flip@flip-vs-suspend@a-edp1:
> 
> shard-tglb: PASS -> INCOMPLETE (i915#456) +3 similar issues
> igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#111825) +10 similar issues
> igt@kms_frontbuffer_tracking@fbcpsr-suspend:
> 
> shard-tglb: PASS -> INCOMPLETE (i915#2411 / i915#456)
> igt@kms_hdr@bpc-switch-dpms:
> 
> shard-skl: PASS -> FAIL (i915#1188)
> igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
> 
> shard-kbl: PASS -> DMESG-WARN (i915#180) +4 similar issues
> igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
> 
> shard-skl: PASS -> FAIL (fdo#108145 / i915#265) +1 similar issue
> igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
> 
> shard-kbl: NOTRUN -> FAIL (fdo#108145 / i915#265)
> igt@kms_plane_lowres@pipe-c-tiling-x:
> 
> shard-tglb: NOTRUN -> SKIP (i915#3536)
> igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#112054)
> igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
> 
> shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#658) +2 similar issues
> igt@kms_psr@psr2_no_drrs:
> 
> shard-iclb: PASS -> SKIP (fdo#109441)
> igt@kms_sysfs_edid_timing:
> 
> shard-kbl: NOTRUN -> FAIL (IGT#2)
> igt@nouveau_crc@pipe-b-ctx-flip-detection:
> 
> shard-tglb: NOTRUN -> SKIP (i915#2530)
> igt@perf@polling-small-buf:
> 
> shard-tglb: PASS -> FAIL (i915#1722)
> igt@prime_nv_api@i915_nv_double_import:
> 
> shard-tglb: NOTRUN -> SKIP (fdo#109291) +2 similar issues
> igt@sysfs_clients@recycle:
> 
> shard-kbl: NOTRUN -> SKIP (fdo#109271 / i915#2994)
> Possible fixes
> igt@gem_ctx_persistence@many-contexts:
> 
> shard-tglb: FAIL (i915#2410) -> PASS
> igt@gem_exec_fair@basic-none-share@rcs0:
> 
> shard-iclb: FAIL (i915#2842) -> PASS
> 
> shard-tglb: FAIL (i915#2842) -> PASS +1 similar issue
> 
> igt@gen9_exec_parse@allowed-single:
> 
> shard-skl: DMESG-WARN (i915#1436 / i915#716) -> PASS
> igt@i915_pm_rpm@system-suspend-execbuf:
> 
> shard-tglb: INCOMPLETE (i915#2411 / i915#456 / i915#750) -> PASS
> igt@kms_cursor_crc@pipe-a-cursor-suspend:
> 
> shard-kbl: DMESG-WARN (i915#180) -> PASS +9 similar issues
> igt@kms_flip@flip-vs-expired-vblank@b-edp1:
> 
> shard-skl: FAIL (i915#79) -> PASS
> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
> 
> shard-tglb: INCOMPLETE (i915#2828 / i915#456) -> PASS
> igt@kms_psr2_su@frontbuffer:
> 
> shard-iclb: SKIP (fdo#109642 / fdo#111068 / i915#658) -> PASS
> Warnings
> igt@gem_exec_fair@basic-pace@vecs0:
> 
> shard-kbl: FAIL (i915#2842) -> SKIP (fdo#109271)
> igt@i915_pm_rc6_residency@rc6-fence:
> 
> shard-iclb: WARN (i915#1804 / i915#2684) -> WARN (i915#2684)
> igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
> 
> shard-skl: FAIL (i915#3722) -> FAIL (i915#3743)
> igt@runner@aborted:
> 
> shard-kbl: (FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL) (fdo#109271 / i915#1436 / i915#180 / i915#1814 /
i915#3002 / i915#3363 / i915#602) -> (FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL, FAIL) (fdo#109271 / i915#1436 / i915#180
/ i915#1814 / i915#2722 / i915#3002 / i915#3363)
> 
> shard-iclb: (FAIL, FAIL) (i915#1814 / i915#3002) -> (FAIL, FAIL, FAIL, FAIL) (i915#1814 / i915#3002 / i915#3728)
> 
> shard-skl: (FAIL, FAIL, FAIL) (i915#1436 / i915#1814 / i915#3002 / i915#3363) -> (FAIL, FAIL) (i915#1814 / i915#3002 / i915#3363)
> 
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> Participating hosts (10 -> 10)
> No changes in participating hosts
> 
> Build changes
> Linux: CI_DRM_10600 -> Patchwork_21082
> CI-20190529: 20190529
> CI_DRM_10600: 6d030d2f188222b72833db764662393e8d492325 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6211: 7b275b3eb17ddf6e7c5b7b9ba359b7f5345a5311 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_21082: b6be0c424a24e0f408d9ff52b5a2ae04f11513f3 @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 3f6fb7d67f84d..36816abb3bcc0 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1501,7 +1501,7 @@  static void psr2_man_trk_ctl_calc(struct intel_crtc_state *crtc_state,
 
 	if (IS_ALDERLAKE_P(dev_priv)) {
 		val |= ADLP_PSR2_MAN_TRK_CTL_SU_REGION_START_ADDR(clip->y1);
-		val |= ADLP_PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR(clip->y2);
+		val |= ADLP_PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR(clip->y2 - 1);
 	} else {
 		drm_WARN_ON(crtc_state->uapi.crtc->dev, clip->y1 % 4 || clip->y2 % 4);