| Message ID | 20211115235345.32206-1-clinton.a.taylor@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/adlp: Remove require_force_probe protection | expand |
On Mon, Nov 15, 2021 at 03:53:45PM -0800, clinton.a.taylor@intel.com wrote: > From: Clint Taylor <clinton.a.taylor@intel.com> > > drm/i915/adlp: Remove require_force_probe protection > > Removing force probe protection from ADL_P platform. Did > not observe warnings, errors, flickering or any visual > defects while doing ordinary tasks like browsing and > editing documents in a two monitor setup. some strange alignment here... please remove the extra tabs here. > > For more info drm-tip idle run results : > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html? hmm... I could swear that I had seen the ADL-P green there a few days ago as well... But right now I couldn't see ADL-P there... So that fails on having a *reliable* green CI picture... Any idea why that is down at this moment? > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> > --- > drivers/gpu/drm/i915/i915_pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 4c7fcc5f9a97..af9f4988bd88 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -970,7 +970,6 @@ static const struct intel_device_info adl_p_info = { > GEN12_FEATURES, > XE_LPD_FEATURES, > PLATFORM(INTEL_ALDERLAKE_P), > - .require_force_probe = 1, > .cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | > BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | > BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), > -- > 2.33.1 >
Assuming the whitespace cleanup requested below is completed: Acked-by: Jon Bloomfield <jon.bloomfield@intel.com> > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Rodrigo Vivi > Sent: Tuesday, November 16, 2021 2:33 PM > To: Taylor, Clinton A <clinton.a.taylor@intel.com> > Cc: Intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/adlp: Remove > require_force_probe protection > > On Mon, Nov 15, 2021 at 03:53:45PM -0800, clinton.a.taylor@intel.com > wrote: > > From: Clint Taylor <clinton.a.taylor@intel.com> > > > > drm/i915/adlp: Remove require_force_probe protection > > > > Removing force probe protection from ADL_P platform. Did > > not observe warnings, errors, flickering or any visual > > defects while doing ordinary tasks like browsing and > > editing documents in a two monitor setup. > > some strange alignment here... please remove the extra > tabs here. > > > > > For more info drm-tip idle run results : > > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html? > > hmm... I could swear that I had seen the ADL-P green there a few > days ago as well... But right now I couldn't see ADL-P there... > > So that fails on having a *reliable* green CI picture... > Any idea why that is down at this moment? > > > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> > > --- > > drivers/gpu/drm/i915/i915_pci.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c > b/drivers/gpu/drm/i915/i915_pci.c > > index 4c7fcc5f9a97..af9f4988bd88 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -970,7 +970,6 @@ static const struct intel_device_info adl_p_info = { > > GEN12_FEATURES, > > XE_LPD_FEATURES, > > PLATFORM(INTEL_ALDERLAKE_P), > > - .require_force_probe = 1, > > .cpu_transcoder_mask = BIT(TRANSCODER_A) | > BIT(TRANSCODER_B) | > > BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | > > BIT(TRANSCODER_DSI_0) | > BIT(TRANSCODER_DSI_1), > > -- > > 2.33.1 > >
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 4c7fcc5f9a97..af9f4988bd88 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -970,7 +970,6 @@ static const struct intel_device_info adl_p_info = { GEN12_FEATURES, XE_LPD_FEATURES, PLATFORM(INTEL_ALDERLAKE_P), - .require_force_probe = 1, .cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1),