| Message ID | 20211117151838.627622-1-mika.kahola@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/display/dg2: Introduce CD clock squashing table | expand |
Please ignore this. These CD clock squashing patches needs to be sent as a series.
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Wednesday, November 17, 2021 10:59 PM
To: Kahola, Mika <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.BAT: failure for drm/i915/display/dg2: Introduce CD clock squashing table
Patch Details
Series:
drm/i915/display/dg2: Introduce CD clock squashing table
URL:
https://patchwork.freedesktop.org/series/97030/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/index.html
CI Bug Log - changes from CI_DRM_10896 -> Patchwork_21618
Summary
FAILURE
Serious unknown changes coming with Patchwork_21618 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_21618, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/index.html
Participating hosts (40 -> 35)
Additional (1): fi-tgl-1115g4
Missing (6): bat-dg1-6 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 bat-jsl-2 bat-jsl-1
Possible new issues
Here are the unknown changes that may have been introduced in Patchwork_21618:
IGT changes
Possible regressions
* igt@gem_lmem_swapping@verify-random:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@gem_lmem_swapping@verify-random.html> +3 similar issues
* igt@kms_psr@primary_page_flip:
* fi-skl-6600u: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-skl-6600u/igt@kms_psr@primary_page_flip.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-skl-6600u/igt@kms_psr@primary_page_flip.html>
Known issues
Here are the changes found in Patchwork_21618 that come from known issues:
IGT changes
Issues hit
* igt@amdgpu/amd_basic@cs-gfx:
* fi-rkl-guc: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html> (fdo#109315<https://bugs.freedesktop.org/show_bug.cgi?id=109315>) +17 similar issues
* igt@amdgpu/amd_basic@query-info:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html> (fdo#109315<https://bugs.freedesktop.org/show_bug.cgi?id=109315>)
* igt@amdgpu/amd_cs_nop@nop-gfx0:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html> (fdo#109315<https://bugs.freedesktop.org/show_bug.cgi?id=109315> / i915#2575<https://gitlab.freedesktop.org/drm/intel/issues/2575>) +16 similar issues
* igt@core_hotunplug@unbind-rebind:
* fi-tgl-u2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html> (i915#4006<https://gitlab.freedesktop.org/drm/intel/issues/4006>)
* igt@gem_exec_suspend@basic-s0:
* fi-tgl-1115g4: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html> (i915#1888<https://gitlab.freedesktop.org/drm/intel/issues/1888>)
* igt@gem_huc_copy@huc-copy:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html> (i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)
* igt@i915_pm_backlight@basic-brightness:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html> (i915#1155<https://gitlab.freedesktop.org/drm/intel/issues/1155>)
* igt@kms_chamelium@common-hpd-after-suspend:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103>) +1 similar issue
* igt@kms_force_connector_basic@force-load-detect:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
* igt@kms_psr@primary_mmap_gtt:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3 similar issues
* igt@prime_vgem@basic-userptr:
* fi-tgl-1115g4: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html> (i915#3301<https://gitlab.freedesktop.org/drm/intel/issues/3301>)
* igt@runner@aborted:
* fi-skl-6600u: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-skl-6600u/igt@runner@aborted.html> (i915#3363<https://gitlab.freedesktop.org/drm/intel/issues/3363> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)
* fi-tgl-u2: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-tgl-u2/igt@runner@aborted.html> (i915#1602<https://gitlab.freedesktop.org/drm/intel/issues/1602> / i915#2722<https://gitlab.freedesktop.org/drm/intel/issues/2722> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)
Possible fixes
* igt@i915_selftest@live@evict:
* fi-kbl-soraka: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-kbl-soraka/igt@i915_selftest@live@evict.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-kbl-soraka/igt@i915_selftest@live@evict.html>
* igt@i915_selftest@live@gt_engines:
* fi-rkl-guc: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10896/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21618/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html>
Build changes
* Linux: CI_DRM_10896 -> Patchwork_21618
CI-20190529: 20190529
CI_DRM_10896: bf11e5f354ac51635d032893d80a1d0015d277dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6283: a2cd90a7c24bb7a4c19ca74c75ed8c950820dee2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21618: b93af6229243b5f6968744935169502567a8ddf3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b93af6229243 drm/i915/display/dg2: Introduce CD clock squashing table
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 91c19e0a98d7..7af4cb965060 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1313,12 +1313,19 @@ static const struct intel_cdclk_vals adlp_cdclk_table[] = { }; static const struct intel_cdclk_vals dg2_cdclk_table[] = { - { .refclk = 38400, .cdclk = 172800, .divider = 2, .ratio = 9 }, - { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 }, - { .refclk = 38400, .cdclk = 307200, .divider = 2, .ratio = 16 }, - { .refclk = 38400, .cdclk = 326400, .divider = 4, .ratio = 34 }, - { .refclk = 38400, .cdclk = 556800, .divider = 2, .ratio = 29 }, - { .refclk = 38400, .cdclk = 652800, .divider = 2, .ratio = 34 }, + { .refclk = 38400, .cdclk = 163200, .divider = 2, .ratio = 34, .waveform = 0x8888 }, + { .refclk = 38400, .cdclk = 204000, .divider = 2, .ratio = 34, .waveform = 0x9248 }, + { .refclk = 38400, .cdclk = 244800, .divider = 2, .ratio = 34, .waveform = 0xa4a4 }, + { .refclk = 38400, .cdclk = 285600, .divider = 2, .ratio = 34, .waveform = 0xa54a }, + { .refclk = 38400, .cdclk = 326400, .divider = 2, .ratio = 34, .waveform = 0xaaaa }, + { .refclk = 38400, .cdclk = 367200, .divider = 2, .ratio = 34, .waveform = 0xad5a }, + { .refclk = 38400, .cdclk = 408000, .divider = 2, .ratio = 34, .waveform = 0xb6b6 }, + { .refclk = 38400, .cdclk = 448800, .divider = 2, .ratio = 34, .waveform = 0xdbb6 }, + { .refclk = 38400, .cdclk = 489600, .divider = 2, .ratio = 34, .waveform = 0xeeee }, + { .refclk = 38400, .cdclk = 530400, .divider = 2, .ratio = 34, .waveform = 0xf7de }, + { .refclk = 38400, .cdclk = 571200, .divider = 2, .ratio = 34, .waveform = 0xfefe }, + { .refclk = 38400, .cdclk = 612000, .divider = 2, .ratio = 34, .waveform = 0xfffe }, + { .refclk = 38400, .cdclk = 652800, .divider = 2, .ratio = 34, .waveform = 0xffff }, {} }; diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.h b/drivers/gpu/drm/i915/display/intel_cdclk.h index 309b3f394e24..89ca59c46102 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.h +++ b/drivers/gpu/drm/i915/display/intel_cdclk.h @@ -19,6 +19,7 @@ struct intel_crtc_state; struct intel_cdclk_vals { u32 cdclk; u16 refclk; + u16 waveform; u8 divider; /* CD2X divider * 2 */ u8 ratio; };
For CD clock squashing method, we need to define corresponding CD clock table for reference clocks, dividers and ratios for all CD clock options. BSpec: 54034 v2: Add CD squashing waveforms as part of CD clock table (Ville) v3: Waveform is 16 bits wide (Ville) [v4: vsyrjala: Nuke the non-squasher based table, Set .divider=2 for consistency, Pack intel_cdclk_vals a bit nicer] v5: Fix error in waveform value (Swati) v6 (Lucas): Rebase on upstream v7 (MattR): Drop 40.8, 81.6, and 122.4 MHz frequencies to reflect new bspec update. Signed-off-by: Mika Kahola <mika.kahola@intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 19 +++++++++++++------ drivers/gpu/drm/i915/display/intel_cdclk.h | 1 + 2 files changed, 14 insertions(+), 6 deletions(-)