| Message ID | 20220131210552.482606-11-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | some fbcon patches, mostly locking | expand |
On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > It was only used by fbcon, and that now switched to its own, > private work. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Helge Deller <deller@gmx.de> > Cc: linux-fbdev@vger.kernel.org I would merge this with the patch that drops the usage > --- > include/linux/fb.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/fb.h b/include/linux/fb.h > index 02f362c661c8..a8a00d2ba1f3 100644 > --- a/include/linux/fb.h > +++ b/include/linux/fb.h > @@ -449,7 +449,6 @@ struct fb_info { > struct fb_var_screeninfo var; /* Current var */ > struct fb_fix_screeninfo fix; /* Current fix */ > struct fb_monspecs monspecs; /* Current Monitor specs */ > - struct work_struct queue; /* Framebuffer event queue */ > struct fb_pixmap pixmap; /* Image hardware mapper */ > struct fb_pixmap sprite; /* Cursor hardware mapper */ > struct fb_cmap cmap; /* Current cmap */ > -- > 2.33.0
On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > > It was only used by fbcon, and that now switched to its own, > > private work. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Helge Deller <deller@gmx.de> > > Cc: linux-fbdev@vger.kernel.org > I would merge this with the patch that drops the usage Yeah, but I like to split these out so that if this does break something, it's much easier to revert. In case I overlooked something somewhere. It's imo different if the cleanup is directly related to the preceeding prep work, but this is a generic workqueue, and the cursor logic is rather unrelated. And if I remember my history digging right, there were actually other uses of this. -Daniel > > > --- > > include/linux/fb.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/fb.h b/include/linux/fb.h > > index 02f362c661c8..a8a00d2ba1f3 100644 > > --- a/include/linux/fb.h > > +++ b/include/linux/fb.h > > @@ -449,7 +449,6 @@ struct fb_info { > > struct fb_var_screeninfo var; /* Current var */ > > struct fb_fix_screeninfo fix; /* Current fix */ > > struct fb_monspecs monspecs; /* Current Monitor specs */ > > - struct work_struct queue; /* Framebuffer event queue */ > > struct fb_pixmap pixmap; /* Image hardware mapper */ > > struct fb_pixmap sprite; /* Cursor hardware mapper */ > > struct fb_cmap cmap; /* Current cmap */ > > -- > > 2.33.0
Hi Daniel, On Tue, Feb 08, 2022 at 02:46:33PM +0100, Daniel Vetter wrote: > On Thu, Feb 03, 2022 at 10:31:00PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > > > It was only used by fbcon, and that now switched to its own, > > > private work. > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > Cc: Helge Deller <deller@gmx.de> > > > Cc: linux-fbdev@vger.kernel.org > > I would merge this with the patch that drops the usage > > Yeah, but I like to split these out so that if this does break something, > it's much easier to revert. In case I overlooked something somewhere. > > It's imo different if the cleanup is directly related to the preceeding > prep work, but this is a generic workqueue, and the cursor logic is rather > unrelated. And if I remember my history digging right, there were actually > other uses of this. So you basically say that because in the past there may have been other users, this deserves a dedicated removal commit. That works for me too. Acked-by: Sam Ravnborg <sam@ravnborg.org> Sam
diff --git a/include/linux/fb.h b/include/linux/fb.h index 02f362c661c8..a8a00d2ba1f3 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -449,7 +449,6 @@ struct fb_info { struct fb_var_screeninfo var; /* Current var */ struct fb_fix_screeninfo fix; /* Current fix */ struct fb_monspecs monspecs; /* Current Monitor specs */ - struct work_struct queue; /* Framebuffer event queue */ struct fb_pixmap pixmap; /* Image hardware mapper */ struct fb_pixmap sprite; /* Cursor hardware mapper */ struct fb_cmap cmap; /* Current cmap */
It was only used by fbcon, and that now switched to its own, private work. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org --- include/linux/fb.h | 1 - 1 file changed, 1 deletion(-)