| Message ID | 20220607074433.1202917-1-luca@coelho.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: remove noisy logs in intel_dp_dsc_get_output_bpp() | expand |
On Tue, 07 Jun 2022, Luca Coelho <luca@coelho.fi> wrote: > From: Luca Coelho <luciano.coelho@intel.com> > > The intel_dp_dsc_get_output_bpp() function outputs two lines of > unconditional logs, which was okay when it was called only once. But > now, we also call this function from intel_dp_mode_valid(), which is > in turn called for every mode we need to validate. This causes a lot > of useless noise. > > Remove the unconditional prints to avoid spamming the logs. Also > remove one more print that is not unconditional, but is related. > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Some of these might be useful on the compute config path, but meh. Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index b8e2d3cd4d68..e198c6d7e3b5 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -658,7 +658,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > */ > bits_per_pixel = (link_clock * lane_count * 8) / > intel_dp_mode_to_fec_clock(mode_clock); > - drm_dbg_kms(&i915->drm, "Max link bpp: %u\n", bits_per_pixel); > > /* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */ > max_bpp_small_joiner_ram = small_joiner_ram_size_bits(i915) / > @@ -667,9 +666,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > if (bigjoiner) > max_bpp_small_joiner_ram *= 2; > > - drm_dbg_kms(&i915->drm, "Max small joiner bpp: %u\n", > - max_bpp_small_joiner_ram); > - > /* > * Greatest allowed DSC BPP = MIN (output BPP from available Link BW > * check, output bpp from small joiner RAM check) > @@ -681,7 +677,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > i915->max_cdclk_freq * 48 / > intel_dp_mode_to_fec_clock(mode_clock); > > - drm_dbg_kms(&i915->drm, "Max big joiner bpp: %u\n", max_bpp_bigjoiner); > bits_per_pixel = min(bits_per_pixel, max_bpp_bigjoiner); > }
On Tue, 2022-06-07 at 11:05 +0300, Jani Nikula wrote: > On Tue, 07 Jun 2022, Luca Coelho <luca@coelho.fi> wrote: > > From: Luca Coelho <luciano.coelho@intel.com> > > > > The intel_dp_dsc_get_output_bpp() function outputs two lines of > > unconditional logs, which was okay when it was called only once. But > > now, we also call this function from intel_dp_mode_valid(), which is > > in turn called for every mode we need to validate. This causes a lot > > of useless noise. > > > > Remove the unconditional prints to avoid spamming the logs. Also > > remove one more print that is not unconditional, but is related. > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > > Some of these might be useful on the compute config path, but meh. Yeah, as we discussed offline, it was not worth refactoring it for the config path. If needed, we can add them back in a less noisy way. > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Thanks! -- Cheers, Luca.
On Tue, 07 Jun 2022, Luca Coelho <luca@coelho.fi> wrote: > From: Luca Coelho <luciano.coelho@intel.com> > > The intel_dp_dsc_get_output_bpp() function outputs two lines of > unconditional logs, which was okay when it was called only once. But > now, we also call this function from intel_dp_mode_valid(), which is > in turn called for every mode we need to validate. This causes a lot > of useless noise. > > Remove the unconditional prints to avoid spamming the logs. Also > remove one more print that is not unconditional, but is related. > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> Thanks, pushed to drm-intel-next. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index b8e2d3cd4d68..e198c6d7e3b5 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -658,7 +658,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > */ > bits_per_pixel = (link_clock * lane_count * 8) / > intel_dp_mode_to_fec_clock(mode_clock); > - drm_dbg_kms(&i915->drm, "Max link bpp: %u\n", bits_per_pixel); > > /* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */ > max_bpp_small_joiner_ram = small_joiner_ram_size_bits(i915) / > @@ -667,9 +666,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > if (bigjoiner) > max_bpp_small_joiner_ram *= 2; > > - drm_dbg_kms(&i915->drm, "Max small joiner bpp: %u\n", > - max_bpp_small_joiner_ram); > - > /* > * Greatest allowed DSC BPP = MIN (output BPP from available Link BW > * check, output bpp from small joiner RAM check) > @@ -681,7 +677,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, > i915->max_cdclk_freq * 48 / > intel_dp_mode_to_fec_clock(mode_clock); > > - drm_dbg_kms(&i915->drm, "Max big joiner bpp: %u\n", max_bpp_bigjoiner); > bits_per_pixel = min(bits_per_pixel, max_bpp_bigjoiner); > }
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index b8e2d3cd4d68..e198c6d7e3b5 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -658,7 +658,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, */ bits_per_pixel = (link_clock * lane_count * 8) / intel_dp_mode_to_fec_clock(mode_clock); - drm_dbg_kms(&i915->drm, "Max link bpp: %u\n", bits_per_pixel); /* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */ max_bpp_small_joiner_ram = small_joiner_ram_size_bits(i915) / @@ -667,9 +666,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, if (bigjoiner) max_bpp_small_joiner_ram *= 2; - drm_dbg_kms(&i915->drm, "Max small joiner bpp: %u\n", - max_bpp_small_joiner_ram); - /* * Greatest allowed DSC BPP = MIN (output BPP from available Link BW * check, output bpp from small joiner RAM check) @@ -681,7 +677,6 @@ static u16 intel_dp_dsc_get_output_bpp(struct drm_i915_private *i915, i915->max_cdclk_freq * 48 / intel_dp_mode_to_fec_clock(mode_clock); - drm_dbg_kms(&i915->drm, "Max big joiner bpp: %u\n", max_bpp_bigjoiner); bits_per_pixel = min(bits_per_pixel, max_bpp_bigjoiner); }