| Message ID | 20220727173306.16247-1-nirmoy.das@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/i915: disable pci resize on 32-bit machine | expand |
Hi Nirmoy, On Wed, Jul 27, 2022 at 07:33:06PM +0200, Nirmoy Das wrote: > PCI bar resize only works with 64 bit BAR so disable > this on 32-bit machine and resolve below compilation error: > > drivers/gpu/drm/i915/gt/intel_region_lmem.c:94:23: error: result of > comparison of constant 4294967296 with expression of type > 'resource_size_t' (aka 'unsigned int') is always false > [-Werror,-Wtautological-constant-out-of-range-compare] > root_res->start > 0x100000000ull) > > Fixes: a91d1a17cd341 ("drm/i915: Add support for LMEM PCIe resizable bar") > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> > Acked-by: Matthew Auld <matthew.auld@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi PS You forgot to CC the author of the patch you are fixing
On 7/27/2022 10:32 PM, Andi Shyti wrote: > Hi Nirmoy, > > On Wed, Jul 27, 2022 at 07:33:06PM +0200, Nirmoy Das wrote: >> PCI bar resize only works with 64 bit BAR so disable >> this on 32-bit machine and resolve below compilation error: >> >> drivers/gpu/drm/i915/gt/intel_region_lmem.c:94:23: error: result of >> comparison of constant 4294967296 with expression of type >> 'resource_size_t' (aka 'unsigned int') is always false >> [-Werror,-Wtautological-constant-out-of-range-compare] >> root_res->start > 0x100000000ull) >> >> Fixes: a91d1a17cd341 ("drm/i915: Add support for LMEM PCIe resizable bar") >> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> >> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> >> Acked-by: Matthew Auld <matthew.auld@intel.com> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> > > Andi > > PS You forgot to CC the author of the patch you are fixing Yes missed that :/ Thanks for reviewing , Andi. Nirmoy
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 6e90032e12e9..aa6aed837194 100644 --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c @@ -15,6 +15,7 @@ #include "gt/intel_gt_mcr.h" #include "gt/intel_gt_regs.h" +#ifdef CONFIG_64BIT static void _release_bars(struct pci_dev *pdev) { int resno; @@ -111,6 +112,9 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t pci_assign_unassigned_bus_resources(pdev->bus); pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd); } +#else +static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {} +#endif static int region_lmem_release(struct intel_memory_region *mem)
PCI bar resize only works with 64 bit BAR so disable this on 32-bit machine and resolve below compilation error: drivers/gpu/drm/i915/gt/intel_region_lmem.c:94:23: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] root_res->start > 0x100000000ull) Fixes: a91d1a17cd341 ("drm/i915: Add support for LMEM PCIe resizable bar") Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> Acked-by: Matthew Auld <matthew.auld@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++++ 1 file changed, 4 insertions(+)