| Message ID | 20220914141553.16864-1-anshuman.gupta@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm | expand |
On Wed, Sep 14, 2022 at 07:45:53PM +0530, Anshuman Gupta wrote: > DG1 and DG2 has lmem, and cpu can access the lmem objects > via mmap and i915 internal i915_gem_object_pin_map() for > i915 own usages. Both of these methods has pre-requisite > requirement to keep GFX PCI endpoint in D0 for a supported > iomem transaction over PCI link. (Refer PCIe specs 5.3.1.4.1) > > TODO: > With respect to i915_gem_object_pin_map(), every caller > has to grab a wakeref if gem object lies in lmem. > > Till we fix all issues related to runtime PM, we need > to keep runtime PM disable on both DG1 and DG2. > > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/i915_pci.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 77e7df21f539..f31d7f5399cc 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -931,6 +931,26 @@ static const struct intel_device_info dg1_info = { > BIT(VCS0) | BIT(VCS2), > /* Wa_16011227922 */ > .__runtime.ppgtt_size = 47, > + > + /* > + * FIXME: Temporary hammer to disable rpm. > + * As per PCIe specs 5.3.1.4.1, all iomem read write request over a PCIe > + * function will be unsupported in case PCIe endpoint function is in D3. > + * But both DG1/DG2 has a hardware bug that violates the PCIe specs > + * and supports the iomem read write transaction over PCIe bus despite > + * endpoint is D3 state. > + * Due to above H/W bug, we had never observed any issue with i915 runtime > + * PM versus lmem access. > + * But this issue gets discover when PCIe gfx endpoint's upstream > + * bridge enters to D3, at this point any lmem read/write access will be > + * returned as unsupported request. But again this issue is not observed > + * on every platform because it has been observed on few host machines > + * DG1/DG2 endpoint's upstream bridge does not binds with pcieport driver. > + * which really disables the PCIe power savings and leaves the bridge to D0 > + * state. > + * Let's disable i915 rpm till we fix all known issue with lmem access in D3. > + */ > + .has_runtime_pm = 0, > }; > > static const struct intel_device_info adl_s_info = { > @@ -1076,6 +1096,7 @@ static const struct intel_device_info dg2_info = { > XE_LPD_FEATURES, > .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | > BIT(TRANSCODER_C) | BIT(TRANSCODER_D), > + .has_runtime_pm = 0, The FIXME msg can be smaller, but it also needs to be here. With this in place fell free to use: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Since the proper solution might take a while let's protect from this case, regardless of any other on going discussion about the force_probe protection. > .require_force_probe = 1, > }; > > -- > 2.26.2 >
Hi Anshuman, On Wed, Sep 14, 2022 at 10:33:15AM -0400, Rodrigo Vivi wrote: > On Wed, Sep 14, 2022 at 07:45:53PM +0530, Anshuman Gupta wrote: > > DG1 and DG2 has lmem, and cpu can access the lmem objects > > via mmap and i915 internal i915_gem_object_pin_map() for > > i915 own usages. Both of these methods has pre-requisite > > requirement to keep GFX PCI endpoint in D0 for a supported > > iomem transaction over PCI link. (Refer PCIe specs 5.3.1.4.1) > > > > TODO: > > With respect to i915_gem_object_pin_map(), every caller > > has to grab a wakeref if gem object lies in lmem. > > > > Till we fix all issues related to runtime PM, we need > > to keep runtime PM disable on both DG1 and DG2. > > > > Cc: Matthew Auld <matthew.auld@intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > --- > > drivers/gpu/drm/i915/i915_pci.c | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > > index 77e7df21f539..f31d7f5399cc 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -931,6 +931,26 @@ static const struct intel_device_info dg1_info = { > > BIT(VCS0) | BIT(VCS2), > > /* Wa_16011227922 */ > > .__runtime.ppgtt_size = 47, > > + > > + /* > > + * FIXME: Temporary hammer to disable rpm. > > + * As per PCIe specs 5.3.1.4.1, all iomem read write request over a PCIe > > + * function will be unsupported in case PCIe endpoint function is in D3. > > + * But both DG1/DG2 has a hardware bug that violates the PCIe specs /has/have/ > > + * and supports the iomem read write transaction over PCIe bus despite /supports/support/ > > + * endpoint is D3 state. > > + * Due to above H/W bug, we had never observed any issue with i915 runtime > > + * PM versus lmem access. > > + * But this issue gets discover when PCIe gfx endpoint's upstream /gets discover/becomes visible/ > > + * bridge enters to D3, at this point any lmem read/write access will be > > + * returned as unsupported request. But again this issue is not observed > > + * on every platform because it has been observed on few host machines > > + * DG1/DG2 endpoint's upstream bridge does not binds with pcieport driver. /binds/bind/ > > + * which really disables the PCIe power savings and leaves the bridge to D0 > > + * state. > > + * Let's disable i915 rpm till we fix all known issue with lmem access in D3. > > + */ > > + .has_runtime_pm = 0, > > }; > > > > static const struct intel_device_info adl_s_info = { > > @@ -1076,6 +1096,7 @@ static const struct intel_device_info dg2_info = { > > XE_LPD_FEATURES, > > .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | > > BIT(TRANSCODER_C) | BIT(TRANSCODER_D), > > + .has_runtime_pm = 0, > > The FIXME msg can be smaller, but it also needs to be here. I actually like the comment, is very clear and helps understanding the issue :) Thanks again for addressing the issue and with the hope to see the proper fix soon: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi > With this in place fell free to use: > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Since the proper solution might take a while let's protect from this case, > regardless of any other on going discussion about the force_probe protection. > > > > .require_force_probe = 1, > > }; > > > > -- > > 2.26.2 > >
> -----Original Message----- > From: Andi Shyti <andi.shyti@linux.intel.com> > Sent: Wednesday, September 14, 2022 8:13 PM > To: Vivi, Rodrigo <rodrigo.vivi@intel.com> > Cc: Gupta, Anshuman <anshuman.gupta@intel.com>; intel- > gfx@lists.freedesktop.org; joonas.lahtinen@linux.intel.com; Ewins, Jon > <jon.ewins@intel.com>; andi.shyti@linux.intel.com; Auld, Matthew > <matthew.auld@intel.com> > Subject: Re: [PATCH] drm/i915/DG{1,2}: FIXME Temporary hammer to disable > rpm > > Hi Anshuman, > > On Wed, Sep 14, 2022 at 10:33:15AM -0400, Rodrigo Vivi wrote: > > On Wed, Sep 14, 2022 at 07:45:53PM +0530, Anshuman Gupta wrote: > > > DG1 and DG2 has lmem, and cpu can access the lmem objects via mmap > > > and i915 internal i915_gem_object_pin_map() for > > > i915 own usages. Both of these methods has pre-requisite requirement > > > to keep GFX PCI endpoint in D0 for a supported iomem transaction > > > over PCI link. (Refer PCIe specs 5.3.1.4.1) > > > > > > TODO: > > > With respect to i915_gem_object_pin_map(), every caller has to grab > > > a wakeref if gem object lies in lmem. > > > > > > Till we fix all issues related to runtime PM, we need to keep > > > runtime PM disable on both DG1 and DG2. > > > > > > Cc: Matthew Auld <matthew.auld@intel.com> > > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > > --- > > > drivers/gpu/drm/i915/i915_pci.c | 21 +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c > > > b/drivers/gpu/drm/i915/i915_pci.c index 77e7df21f539..f31d7f5399cc > > > 100644 > > > --- a/drivers/gpu/drm/i915/i915_pci.c > > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > > @@ -931,6 +931,26 @@ static const struct intel_device_info dg1_info = { > > > BIT(VCS0) | BIT(VCS2), > > > /* Wa_16011227922 */ > > > .__runtime.ppgtt_size = 47, > > > + > > > + /* > > > + * FIXME: Temporary hammer to disable rpm. > > > + * As per PCIe specs 5.3.1.4.1, all iomem read write request over a PCIe > > > + * function will be unsupported in case PCIe endpoint function is in D3. > > > + * But both DG1/DG2 has a hardware bug that violates the PCIe > > > +specs > > /has/have/ > > > > + * and supports the iomem read write transaction over PCIe bus > > > +despite > > /supports/support/ > > > > + * endpoint is D3 state. > > > + * Due to above H/W bug, we had never observed any issue with i915 > runtime > > > + * PM versus lmem access. > > > + * But this issue gets discover when PCIe gfx endpoint's upstream > > /gets discover/becomes visible/ > > > > + * bridge enters to D3, at this point any lmem read/write access will be > > > + * returned as unsupported request. But again this issue is not observed > > > + * on every platform because it has been observed on few host > machines > > > + * DG1/DG2 endpoint's upstream bridge does not binds with pcieport > driver. > > /binds/bind/ > > > > + * which really disables the PCIe power savings and leaves the bridge to > D0 > > > + * state. > > > + * Let's disable i915 rpm till we fix all known issue with lmem access in > D3. > > > + */ > > > + .has_runtime_pm = 0, > > > }; > > > > > > static const struct intel_device_info adl_s_info = { @@ -1076,6 > > > +1096,7 @@ static const struct intel_device_info dg2_info = { > > > XE_LPD_FEATURES, > > > .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | > BIT(TRANSCODER_B) | > > > BIT(TRANSCODER_C) | BIT(TRANSCODER_D), > > > + .has_runtime_pm = 0, > > > > The FIXME msg can be smaller, but it also needs to be here. > > I actually like the comment, is very clear and helps understanding the issue :) Shall I move the comment to commit log , and keep a smaller comment for both DG1 and DG2 ? With that I can address your comment and Rodrigo comment as well. Keeping such a big comment at two places will not make any sense. Thanks, Anshuman Gupta. > > Thanks again for addressing the issue and with the hope to see the proper fix > soon: > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> > > Thanks, > Andi > > > With this in place fell free to use: > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > Since the proper solution might take a while let's protect from this > > case, regardless of any other on going discussion about the force_probe > protection. > > > > > > > .require_force_probe = 1, > > > }; > > > > > > -- > > > 2.26.2 > > >
Hi Anshuman, [...] > > > > + * which really disables the PCIe power savings and leaves the bridge to > > D0 > > > > + * state. > > > > + * Let's disable i915 rpm till we fix all known issue with lmem access in > > D3. > > > > + */ > > > > + .has_runtime_pm = 0, > > > > }; > > > > > > > > static const struct intel_device_info adl_s_info = { @@ -1076,6 > > > > +1096,7 @@ static const struct intel_device_info dg2_info = { > > > > XE_LPD_FEATURES, > > > > .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | > > BIT(TRANSCODER_B) | > > > > BIT(TRANSCODER_C) | BIT(TRANSCODER_D), > > > > + .has_runtime_pm = 0, > > > > > > The FIXME msg can be smaller, but it also needs to be here. > > > > I actually like the comment, is very clear and helps understanding the issue :) > Shall I move the comment to commit log , and keep a smaller comment for both DG1 and DG2 ? > With that I can address your comment and Rodrigo comment as well. > Keeping such a big comment at two places will not make any sense. OK for me! Thanks! Andi
On 9/14/2022 9:13 PM, Patchwork wrote: > *Patch Details* > *Series:* drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm (rev2) > *URL:* https://patchwork.freedesktop.org/series/108477/ > <https://patchwork.freedesktop.org/series/108477/> > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.html > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.html> > > > CI Bug Log - changes from CI_DRM_12134 -> Patchwork_108477v2 > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_108477v2 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_108477v2, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.html > > > Participating hosts (40 -> 41) > > Additional (5): fi-icl-u2 bat-dg2-9 bat-adln-1 bat-rplp-1 bat-jsl-1 > Missing (4): fi-ctg-p8600 fi-hsw-4770 fi-rkl-11600 fi-tgl-dsi > > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_108477v2: > > > IGT changes > > > Possible regressions > > * igt@i915_pm_rpm@module-reload: > o bat-dg1-5: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-dg1-5/igt@i915_pm_rpm@module-reload.html> -> SKIP <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg1-5/igt@i915_pm_rpm@module-reload.html> +2 similar issues Hi Lakshmi , With this series i915_pm_rpm test are expected to fail on DG1/DG2 as this patch disables runtime PM. Could you please re-report the result so that BAT can resume. Thanks, Anshuman Gupta. > > > Suppressed > > The following results come from untrusted machines, tests, or statuses. > They do not affect the overall result. > > * > > igt@i915_pm_rpm@basic-pci-d3-state: > > o {bat-dg2-8}: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-dg2-8/igt@i915_pm_rpm@basic-pci-d3-state.html> -> SKIP <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg2-8/igt@i915_pm_rpm@basic-pci-d3-state.html> +2 similar issues > * > > igt@i915_pm_rpm@basic-rte: > > o {bat-dg2-9}: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg2-9/igt@i915_pm_rpm@basic-rte.html> +2 similar issues > > > Known issues > > Here are the changes found in Patchwork_108477v2 that come from known > issues: > > > IGT changes > > > Issues hit > > * > > igt@gem_huc_copy@huc-copy: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@gem_huc_copy@huc-copy.html> (i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > * > > igt@gem_lmem_swapping@random-engines: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html> (i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues > * > > igt@i915_pm_rpm@module-reload: > > o fi-cfl-8109u: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html> -> DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html> (i915#62 <https://gitlab.freedesktop.org/drm/intel/issues/62>) > * > > igt@i915_selftest@live@ring_submission: > > o fi-cfl-8109u: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html> -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html> (i915#5904 <https://gitlab.freedesktop.org/drm/intel/issues/5904>) +30 similar issues > * > > igt@i915_suspend@basic-s2idle-without-i915: > > o fi-cfl-8109u: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html> -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html> (i915#5904 <https://gitlab.freedesktop.org/drm/intel/issues/5904> / i915#62 <https://gitlab.freedesktop.org/drm/intel/issues/62>) > * > > igt@kms_chamelium@common-hpd-after-suspend: > > o fi-bdw-5557u: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > * > > igt@kms_chamelium@hdmi-hpd-fast: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html> (fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues > * > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html> (i915#4103 <https://gitlab.freedesktop.org/drm/intel/issues/4103>) > * > > igt@kms_force_connector_basic@force-connector-state: > > o fi-icl-u2: NOTRUN -> WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@kms_force_connector_basic@force-connector-state.html> (i915#6008 <https://gitlab.freedesktop.org/drm/intel/issues/6008>) > * > > igt@kms_force_connector_basic@force-load-detect: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>) > * > > igt@kms_frontbuffer_tracking@basic: > > o fi-cfl-8109u: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html> -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html> (i915#62 <https://gitlab.freedesktop.org/drm/intel/issues/62>) +12 similar issues > * > > igt@kms_setmode@basic-clone-single-crtc: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>) > * > > igt@prime_vgem@basic-userptr: > > o fi-icl-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2/igt@prime_vgem@basic-userptr.html> (fdo#109295 <https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3301 <https://gitlab.freedesktop.org/drm/intel/issues/3301>) > > > Possible fixes > > * igt@i915_selftest@live@guc: > o {bat-rpls-1}: DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-rpls-1/igt@i915_selftest@live@guc.html> (i915#6471 <https://gitlab.freedesktop.org/drm/intel/issues/6471>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-rpls-1/igt@i915_selftest@live@guc.html> > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > > Build changes > > * Linux: CI_DRM_12134 -> Patchwork_108477v2 > > CI-20190529: 20190529 > CI_DRM_12134: a84a8c8d23dac90008acab56508b4dab70d6148d @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_6655: 1c26b484df1d07ddb403883c88b8b82db7d63877 @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_108477v2: a84a8c8d23dac90008acab56508b4dab70d6148d @ > git://anongit.freedesktop.org/gfx-ci/linux > > > Linux commits > > bf2345672e11 drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm >
> -----Original Message----- > From: Gupta, Anshuman > Sent: Wednesday, September 14, 2022 9:36 PM > To: intel-gfx@lists.freedesktop.org; ", lakshminarayana.vudum"@intel.com; > ",rodrigo.vivi"@intel.com > Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/DG{1, 2}: FIXME Temporary > hammer to disable rpm (rev2) > > > > On 9/14/2022 9:13 PM, Patchwork wrote: > > *Patch Details* > > *Series:* drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm > (rev2) > > *URL:* https://patchwork.freedesktop.org/series/108477/ > > <https://patchwork.freedesktop.org/series/108477/> > > *State:* failure > > *Details:* > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.html > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.htm > > l> > > > > > > CI Bug Log - changes from CI_DRM_12134 -> Patchwork_108477v2 > > > > > > Summary > > > > *FAILURE* > > > > Serious unknown changes coming with Patchwork_108477v2 absolutely need > > to be verified manually. > > > > If you think the reported changes have nothing to do with the changes > > introduced in Patchwork_108477v2, please notify your bug team to allow > > them to document this new failure mode, which will reduce false positives in > CI. > > > > External URL: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.html > > > > > > Participating hosts (40 -> 41) > > > > Additional (5): fi-icl-u2 bat-dg2-9 bat-adln-1 bat-rplp-1 bat-jsl-1 > > Missing (4): fi-ctg-p8600 fi-hsw-4770 fi-rkl-11600 fi-tgl-dsi > > > > > > Possible new issues > > > > Here are the unknown changes that may have been introduced in > > Patchwork_108477v2: > > > > > > IGT changes > > > > > > Possible regressions > > > > * igt@i915_pm_rpm@module-reload: > > o bat-dg1-5: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-dg1-5/igt@i > > 915_pm_rpm@module-reload.html> -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg1-5 > > /igt@i915_pm_rpm@module-reload.html> +2 similar issues > Hi Lakshmi , > With this series i915_pm_rpm test are expected to fail on DG1/DG2 as this > patch disables runtime PM. > Could you please re-report the result so that BAT can resume. > Thanks, > Anshuman Gupta. > > > > > > Suppressed > > > > The following results come from untrusted machines, tests, or statuses. > > They do not affect the overall result. > > > > * > > > > igt@i915_pm_rpm@basic-pci-d3-state: > > > > o {bat-dg2-8}: PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-dg2- > 8/igt@i915_pm_rpm@basic-pci-d3-state.html> -> SKIP <https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg2- > 8/igt@i915_pm_rpm@basic-pci-d3-state.html> +2 similar issues > > * > > > > igt@i915_pm_rpm@basic-rte: > > > > o {bat-dg2-9}: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg2-9 > > /igt@i915_pm_rpm@basic-rte.html> +2 similar issues > > > > > > Known issues > > > > Here are the changes found in Patchwork_108477v2 that come from known > > issues: > > > > > > IGT changes > > > > > > Issues hit > > > > * > > > > igt@gem_huc_copy@huc-copy: > > > > o fi-icl-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@gem_huc_copy@huc-copy.html> (i915#2190 > <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > > * > > > > igt@gem_lmem_swapping@random-engines: > > > > o fi-icl-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@gem_lmem_swapping@random-engines.html> (i915#4613 > <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues > > * > > > > igt@i915_pm_rpm@module-reload: > > > > o fi-cfl-8109u: PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@i915_pm_rpm@module-reload.html> -> DMESG-FAIL <https://intel- > gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@i915_pm_rpm@module-reload.html> (i915#62 > <https://gitlab.freedesktop.org/drm/intel/issues/62>) > > * > > > > igt@i915_selftest@live@ring_submission: > > > > o fi-cfl-8109u: PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@i915_selftest@live@ring_submission.html> -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@i915_selftest@live@ring_submission.html> (i915#5904 > <https://gitlab.freedesktop.org/drm/intel/issues/5904>) +30 similar issues > > * > > > > igt@i915_suspend@basic-s2idle-without-i915: > > > > o fi-cfl-8109u: PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@i915_suspend@basic-s2idle-without-i915.html> -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@i915_suspend@basic-s2idle-without-i915.html> (i915#5904 > <https://gitlab.freedesktop.org/drm/intel/issues/5904> / i915#62 > <https://gitlab.freedesktop.org/drm/intel/issues/62>) > > * > > > > igt@kms_chamelium@common-hpd-after-suspend: > > > > o fi-bdw-5557u: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-bdw- > 5557u/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > > * > > > > igt@kms_chamelium@hdmi-hpd-fast: > > > > o fi-icl-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_chamelium@hdmi-hpd-fast.html> (fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar issues > > * > > > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor: > > > > o fi-icl-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html> (i915#4103 > <https://gitlab.freedesktop.org/drm/intel/issues/4103>) > > * > > > > igt@kms_force_connector_basic@force-connector-state: > > > > o fi-icl-u2: NOTRUN -> WARN > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_force_connector_basic@force-connector-state.html> (i915#6008 > <https://gitlab.freedesktop.org/drm/intel/issues/6008>) > > * > > > > igt@kms_force_connector_basic@force-load-detect: > > > > o fi-icl-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285 > <https://bugs.freedesktop.org/show_bug.cgi?id=109285>) > > * > > > > igt@kms_frontbuffer_tracking@basic: > > > > o fi-cfl-8109u: PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@kms_frontbuffer_tracking@basic.html> -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@kms_frontbuffer_tracking@basic.html> (i915#62 > <https://gitlab.freedesktop.org/drm/intel/issues/62>) +12 similar issues > > * > > > > igt@kms_setmode@basic-clone-single-crtc: > > > > o fi-icl-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555 > <https://gitlab.freedesktop.org/drm/intel/issues/3555>) > > * > > > > igt@prime_vgem@basic-userptr: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl-u2 > > /igt@prime_vgem@basic-userptr.html> (fdo#109295 > > <https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3301 > > <https://gitlab.freedesktop.org/drm/intel/issues/3301>) > > > > > > Possible fixes > > > > * igt@i915_selftest@live@guc: > > o {bat-rpls-1}: DMESG-WARN > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-rpls-1/igt@ > > i915_selftest@live@guc.html> (i915#6471 > > <https://gitlab.freedesktop.org/drm/intel/issues/6471>) -> PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-rpls- > > 1/igt@i915_selftest@live@guc.html> > > > > {name}: This element is suppressed. This means it is ignored when > > computing the status of the difference (SUCCESS, WARNING, or FAILURE). > > > > > > Build changes > > > > * Linux: CI_DRM_12134 -> Patchwork_108477v2 > > > > CI-20190529: 20190529 > > CI_DRM_12134: a84a8c8d23dac90008acab56508b4dab70d6148d @ > > git://anongit.freedesktop.org/gfx-ci/linux > > IGT_6655: 1c26b484df1d07ddb403883c88b8b82db7d63877 @ > > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > > Patchwork_108477v2: a84a8c8d23dac90008acab56508b4dab70d6148d @ > > git://anongit.freedesktop.org/gfx-ci/linux > > > > > > Linux commits > > > > bf2345672e11 drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm > >
https://gitlab.freedesktop.org/drm/intel/-/issues/6844 [DG1][DG2] igt@i915_pm_rpm@.* - skip - Test requirement: has_runtime_pm, Last errno: 5, Input/output error, SKIP Issue closed as expected and re-reported. Lakshmi. -----Original Message----- From: Gupta, Anshuman <anshuman.gupta@intel.com> Sent: Wednesday, September 14, 2022 9:10 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com> Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm (rev2) > -----Original Message----- > From: Gupta, Anshuman > Sent: Wednesday, September 14, 2022 9:36 PM > To: intel-gfx@lists.freedesktop.org; ", > lakshminarayana.vudum"@intel.com; ",rodrigo.vivi"@intel.com > Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/DG{1, 2}: FIXME > Temporary hammer to disable rpm (rev2) > > > > On 9/14/2022 9:13 PM, Patchwork wrote: > > *Patch Details* > > *Series:* drm/i915/DG{1, 2}: FIXME Temporary hammer to disable rpm > (rev2) > > *URL:* https://patchwork.freedesktop.org/series/108477/ > > <https://patchwork.freedesktop.org/series/108477/> > > *State:* failure > > *Details:* > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.ht > > ml > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.h > > tm > > l> > > > > > > CI Bug Log - changes from CI_DRM_12134 -> Patchwork_108477v2 > > > > > > Summary > > > > *FAILURE* > > > > Serious unknown changes coming with Patchwork_108477v2 absolutely > > need to be verified manually. > > > > If you think the reported changes have nothing to do with the > > changes introduced in Patchwork_108477v2, please notify your bug > > team to allow them to document this new failure mode, which will > > reduce false positives in > CI. > > > > External URL: > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/index.ht > > ml > > > > > > Participating hosts (40 -> 41) > > > > Additional (5): fi-icl-u2 bat-dg2-9 bat-adln-1 bat-rplp-1 bat-jsl-1 > > Missing (4): fi-ctg-p8600 fi-hsw-4770 fi-rkl-11600 fi-tgl-dsi > > > > > > Possible new issues > > > > Here are the unknown changes that may have been introduced in > > Patchwork_108477v2: > > > > > > IGT changes > > > > > > Possible regressions > > > > * igt@i915_pm_rpm@module-reload: > > o bat-dg1-5: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-dg1-5/igt > > @i 915_pm_rpm@module-reload.html> -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg1 > > -5 /igt@i915_pm_rpm@module-reload.html> +2 similar issues > Hi Lakshmi , > With this series i915_pm_rpm test are expected to fail on DG1/DG2 as > this patch disables runtime PM. > Could you please re-report the result so that BAT can resume. > Thanks, > Anshuman Gupta. > > > > > > Suppressed > > > > The following results come from untrusted machines, tests, or statuses. > > They do not affect the overall result. > > > > * > > > > igt@i915_pm_rpm@basic-pci-d3-state: > > > > o {bat-dg2-8}: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-dg2- > 8/igt@i915_pm_rpm@basic-pci-d3-state.html> -> SKIP <https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg2- > 8/igt@i915_pm_rpm@basic-pci-d3-state.html> +2 similar issues > > * > > > > igt@i915_pm_rpm@basic-rte: > > > > o {bat-dg2-9}: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-dg2 > > -9 /igt@i915_pm_rpm@basic-rte.html> +2 similar issues > > > > > > Known issues > > > > Here are the changes found in Patchwork_108477v2 that come from > > known > > issues: > > > > > > IGT changes > > > > > > Issues hit > > > > * > > > > igt@gem_huc_copy@huc-copy: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@gem_huc_copy@huc-copy.html> (i915#2190 > <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > > * > > > > igt@gem_lmem_swapping@random-engines: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@gem_lmem_swapping@random-engines.html> (i915#4613 > <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar > issues > > * > > > > igt@i915_pm_rpm@module-reload: > > > > o fi-cfl-8109u: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@i915_pm_rpm@module-reload.html> -> DMESG-FAIL > <https://intel- > gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@i915_pm_rpm@module-reload.html> (i915#62 > <https://gitlab.freedesktop.org/drm/intel/issues/62>) > > * > > > > igt@i915_selftest@live@ring_submission: > > > > o fi-cfl-8109u: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@i915_selftest@live@ring_submission.html> -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@i915_selftest@live@ring_submission.html> (i915#5904 > <https://gitlab.freedesktop.org/drm/intel/issues/5904>) +30 similar > issues > > * > > > > igt@i915_suspend@basic-s2idle-without-i915: > > > > o fi-cfl-8109u: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@i915_suspend@basic-s2idle-without-i915.html> -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@i915_suspend@basic-s2idle-without-i915.html> (i915#5904 > <https://gitlab.freedesktop.org/drm/intel/issues/5904> / i915#62 > <https://gitlab.freedesktop.org/drm/intel/issues/62>) > > * > > > > igt@kms_chamelium@common-hpd-after-suspend: > > > > o fi-bdw-5557u: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-bdw- > 5557u/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > > * > > > > igt@kms_chamelium@hdmi-hpd-fast: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_chamelium@hdmi-hpd-fast.html> (fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8 similar > issues > > * > > > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html> > (i915#4103 > <https://gitlab.freedesktop.org/drm/intel/issues/4103>) > > * > > > > igt@kms_force_connector_basic@force-connector-state: > > > > o fi-icl-u2: NOTRUN -> WARN > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_force_connector_basic@force-connector-state.html> > (i915#6008 > <https://gitlab.freedesktop.org/drm/intel/issues/6008>) > > * > > > > igt@kms_force_connector_basic@force-load-detect: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285 > <https://bugs.freedesktop.org/show_bug.cgi?id=109285>) > > * > > > > igt@kms_frontbuffer_tracking@basic: > > > > o fi-cfl-8109u: PASS > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/fi-cfl- > 8109u/igt@kms_frontbuffer_tracking@basic.html> -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-cfl- > 8109u/igt@kms_frontbuffer_tracking@basic.html> (i915#62 > <https://gitlab.freedesktop.org/drm/intel/issues/62>) +12 similar > issues > > * > > > > igt@kms_setmode@basic-clone-single-crtc: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > u2/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555 > <https://gitlab.freedesktop.org/drm/intel/issues/3555>) > > * > > > > igt@prime_vgem@basic-userptr: > > > > o fi-icl-u2: NOTRUN -> SKIP > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/fi-icl- > > u2 /igt@prime_vgem@basic-userptr.html> (fdo#109295 > > <https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3301 > > <https://gitlab.freedesktop.org/drm/intel/issues/3301>) > > > > > > Possible fixes > > > > * igt@i915_selftest@live@guc: > > o {bat-rpls-1}: DMESG-WARN > > > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12134/bat-rpls-1/ig > > t@ i915_selftest@live@guc.html> (i915#6471 > > <https://gitlab.freedesktop.org/drm/intel/issues/6471>) -> PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108477v2/bat-rpl > > s- > > 1/igt@i915_selftest@live@guc.html> > > > > {name}: This element is suppressed. This means it is ignored when > > computing the status of the difference (SUCCESS, WARNING, or FAILURE). > > > > > > Build changes > > > > * Linux: CI_DRM_12134 -> Patchwork_108477v2 > > > > CI-20190529: 20190529 > > CI_DRM_12134: a84a8c8d23dac90008acab56508b4dab70d6148d @ > > git://anongit.freedesktop.org/gfx-ci/linux > > IGT_6655: 1c26b484df1d07ddb403883c88b8b82db7d63877 @ > > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > > Patchwork_108477v2: a84a8c8d23dac90008acab56508b4dab70d6148d @ > > git://anongit.freedesktop.org/gfx-ci/linux > > > > > > Linux commits > > > > bf2345672e11 drm/i915/DG{1, 2}: FIXME Temporary hammer to disable > > rpm > >
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 77e7df21f539..f31d7f5399cc 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -931,6 +931,26 @@ static const struct intel_device_info dg1_info = { BIT(VCS0) | BIT(VCS2), /* Wa_16011227922 */ .__runtime.ppgtt_size = 47, + + /* + * FIXME: Temporary hammer to disable rpm. + * As per PCIe specs 5.3.1.4.1, all iomem read write request over a PCIe + * function will be unsupported in case PCIe endpoint function is in D3. + * But both DG1/DG2 has a hardware bug that violates the PCIe specs + * and supports the iomem read write transaction over PCIe bus despite + * endpoint is D3 state. + * Due to above H/W bug, we had never observed any issue with i915 runtime + * PM versus lmem access. + * But this issue gets discover when PCIe gfx endpoint's upstream + * bridge enters to D3, at this point any lmem read/write access will be + * returned as unsupported request. But again this issue is not observed + * on every platform because it has been observed on few host machines + * DG1/DG2 endpoint's upstream bridge does not binds with pcieport driver. + * which really disables the PCIe power savings and leaves the bridge to D0 + * state. + * Let's disable i915 rpm till we fix all known issue with lmem access in D3. + */ + .has_runtime_pm = 0, }; static const struct intel_device_info adl_s_info = { @@ -1076,6 +1096,7 @@ static const struct intel_device_info dg2_info = { XE_LPD_FEATURES, .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | BIT(TRANSCODER_C) | BIT(TRANSCODER_D), + .has_runtime_pm = 0, .require_force_probe = 1, };
DG1 and DG2 has lmem, and cpu can access the lmem objects via mmap and i915 internal i915_gem_object_pin_map() for i915 own usages. Both of these methods has pre-requisite requirement to keep GFX PCI endpoint in D0 for a supported iomem transaction over PCI link. (Refer PCIe specs 5.3.1.4.1) TODO: With respect to i915_gem_object_pin_map(), every caller has to grab a wakeref if gem object lies in lmem. Till we fix all issues related to runtime PM, we need to keep runtime PM disable on both DG1 and DG2. Cc: Matthew Auld <matthew.auld@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/i915_pci.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)