| Message ID | 20221102155709.31717-1-nirmoy.das@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/selftests: Reduce oversaturation of request smoketesting | expand |
On 02/11/2022 15:57, Nirmoy Das wrote: > From: Chris Wilson <chris@chris-wilson.co.uk> > > The goal in launching the request smoketest is to have sufficient tasks > running across the system such that we are likely to detect concurrency > issues. We aim to have 2 tasks using the same engine, gt, device (each > level of locking around submission and signaling) running at the same > time. While tasks may not be running all the time as they synchronise > with the gpu, they will be running most of the time, in which case > having many more tasks than cores available is wasteful (and > dramatically increases the workload causing excess runtime). Aim to > limit the number of tasks such that there is at least 2 running per > engine, spreading surplus cores around the engines (rather than running > a task per core per engine.) > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index a46350c37e9d..4380473ceb98 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1710,7 +1710,8 @@ static int live_breadcrumbs_smoketest(void *arg) > { > struct drm_i915_private *i915 = arg; > const unsigned int nengines = num_uabi_engines(i915); > - const unsigned int ncpus = num_online_cpus(); > + const unsigned int ncpus = /* saturate with nengines * ncpus */ > + max_t(int, 2, DIV_ROUND_UP(num_online_cpus(), nengines)); > unsigned long num_waits, num_fences; > struct intel_engine_cs *engine; > struct smoke_thread *threads; > @@ -1782,7 +1783,7 @@ static int live_breadcrumbs_smoketest(void *arg) > goto out_flush; > } > /* One ring interleaved between requests from all cpus */ > - smoke[idx].max_batch /= num_online_cpus() + 1; > + smoke[idx].max_batch /= ncpus + 1; > pr_debug("Limiting batches to %d requests on %s\n", > smoke[idx].max_batch, engine->name); > Makes sense to me. Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko
On 11/2/2022 4:57 PM, Nirmoy Das wrote: > From: Chris Wilson <chris@chris-wilson.co.uk> > > The goal in launching the request smoketest is to have sufficient tasks > running across the system such that we are likely to detect concurrency > issues. We aim to have 2 tasks using the same engine, gt, device (each > level of locking around submission and signaling) running at the same > time. While tasks may not be running all the time as they synchronise > with the gpu, they will be running most of the time, in which case > having many more tasks than cores available is wasteful (and > dramatically increases the workload causing excess runtime). Aim to > limit the number of tasks such that there is at least 2 running per > engine, spreading surplus cores around the engines (rather than running > a task per core per engine.) > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Tested-by: Nirmoy Das <nirmoy.das@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Nirmoy > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index a46350c37e9d..4380473ceb98 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1710,7 +1710,8 @@ static int live_breadcrumbs_smoketest(void *arg) > { > struct drm_i915_private *i915 = arg; > const unsigned int nengines = num_uabi_engines(i915); > - const unsigned int ncpus = num_online_cpus(); > + const unsigned int ncpus = /* saturate with nengines * ncpus */ > + max_t(int, 2, DIV_ROUND_UP(num_online_cpus(), nengines)); > unsigned long num_waits, num_fences; > struct intel_engine_cs *engine; > struct smoke_thread *threads; > @@ -1782,7 +1783,7 @@ static int live_breadcrumbs_smoketest(void *arg) > goto out_flush; > } > /* One ring interleaved between requests from all cpus */ > - smoke[idx].max_batch /= num_online_cpus() + 1; > + smoke[idx].max_batch /= ncpus + 1; > pr_debug("Limiting batches to %d requests on %s\n", > smoke[idx].max_batch, engine->name); >
On 11/3/2022 12:38 AM, Patchwork wrote: > Project List - Patchwork *Patch Details* > *Series:* drm/i915/selftests: Reduce oversaturation of request > smoketesting > *URL:* https://patchwork.freedesktop.org/series/110426/ > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/index.html > > > CI Bug Log - changes from CI_DRM_12332_full -> Patchwork_110426v1_full > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_110426v1_full absolutely > need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_110426v1_full, please notify your bug team to > allow them > to document this new failure mode, which will reduce false positives > in CI. > > > Participating hosts (9 -> 9) > > No changes in participating hosts > > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_110426v1_full: > > > IGT changes > > > Possible regressions > > * > > igt@api_intel_allocator@two-level-inception: > > o shard-tglb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-tglb6/igt@api_intel_allocator@two-level-inception.html> > -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-tglb2/igt@api_intel_allocator@two-level-inception.html> > * > > igt@gem_ctx_create@basic-files: > > o shard-tglb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-tglb2/igt@gem_ctx_create@basic-files.html> > -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-tglb1/igt@gem_ctx_create@basic-files.html> > Unrelated failure the patch only changes "i915_selftest --run live --dyn requests" > * > > > Known issues > > Here are the changes found in Patchwork_110426v1_full that come from > known issues: > > > CI changes > > > Issues hit > > * boot: > o shard-skl: (PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl9/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl9/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl9/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl4/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl4/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl4/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl3/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl3/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl3/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl10/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl10/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl10/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl10/boot.html>) > -> (PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl10/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl10/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl10/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl4/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl4/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl4/boot.html>, > FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl5/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl6/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl7/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl9/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl9/boot.html>, > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl9/boot.html>) > (i915#5032 <https://gitlab.freedesktop.org/drm/intel/issues/5032>) > > > IGT changes > > > Issues hit > > * > > igt@feature_discovery@psr2: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb2/igt@feature_discovery@psr2.html> > -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@feature_discovery@psr2.html> > (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>) > * > > igt@gem_ctx_exec@basic-nohangcheck: > > o shard-tglb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-tglb5/igt@gem_ctx_exec@basic-nohangcheck.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html> > (i915#6268 <https://gitlab.freedesktop.org/drm/intel/issues/6268>) > * > > igt@gem_ctx_isolation@preservation-s3@bcs0: > > o shard-apl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-apl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html> > -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html> > (i915#180 > <https://gitlab.freedesktop.org/drm/intel/issues/180>) +2 > similar issues > * > > igt@gem_exec_balancer@parallel-balancer: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb1/igt@gem_exec_balancer@parallel-balancer.html> > -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb7/igt@gem_exec_balancer@parallel-balancer.html> > (i915#4525 > <https://gitlab.freedesktop.org/drm/intel/issues/4525>) +1 > similar issue > * > > igt@gem_exec_fair@basic-deadline: > > o shard-glk: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk8/igt@gem_exec_fair@basic-deadline.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk5/igt@gem_exec_fair@basic-deadline.html> > (i915#2846 <https://gitlab.freedesktop.org/drm/intel/issues/2846>) > * > > igt@gem_exec_fair@basic-pace-share@rcs0: > > o shard-glk: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html> > (i915#2842 > <https://gitlab.freedesktop.org/drm/intel/issues/2842>) +1 > similar issue > * > > igt@gem_huc_copy@huc-copy: > > o shard-tglb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-tglb2/igt@gem_huc_copy@huc-copy.html> > -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-tglb7/igt@gem_huc_copy@huc-copy.html> > (i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > * > > igt@gem_lmem_swapping@basic: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@gem_lmem_swapping@basic.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#4613 > <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +1 > similar issue > * > > igt@gem_lmem_swapping@massive: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl7/igt@gem_lmem_swapping@massive.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) > * > > igt@gem_tiled_wb: > > o shard-skl: NOTRUN -> TIMEOUT > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@gem_tiled_wb.html> > (i915#6990 <https://gitlab.freedesktop.org/drm/intel/issues/6990>) > * > > igt@gen9_exec_parse@allowed-single: > > o shard-apl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-apl1/igt@gen9_exec_parse@allowed-single.html> > -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl2/igt@gen9_exec_parse@allowed-single.html> > (i915#5566 > <https://gitlab.freedesktop.org/drm/intel/issues/5566> / > i915#716 <https://gitlab.freedesktop.org/drm/intel/issues/716>) > * > > igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#3886 > <https://gitlab.freedesktop.org/drm/intel/issues/3886>) +1 > similar issue > * > > igt@kms_chamelium@hdmi-edid-change-during-suspend: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl1/igt@kms_chamelium@hdmi-edid-change-during-suspend.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > * > > igt@kms_color_chamelium@gamma: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@kms_color_chamelium@gamma.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > * > > igt@kms_flip@flip-vs-expired-vblank@a-edp1: > > o shard-skl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html> > (i915#79 <https://gitlab.freedesktop.org/drm/intel/issues/79>) > * > > igt@kms_flip@flip-vs-suspend@c-dp1: > > o shard-apl: NOTRUN -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl3/igt@kms_flip@flip-vs-suspend@c-dp1.html> > (i915#180 <https://gitlab.freedesktop.org/drm/intel/issues/180>) > * > > igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1: > > o shard-skl: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html> > (i915#2122 > <https://gitlab.freedesktop.org/drm/intel/issues/2122>) +1 > similar issue > * > > igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html> > (i915#2587 > <https://gitlab.freedesktop.org/drm/intel/issues/2587> / > i915#2672 <https://gitlab.freedesktop.org/drm/intel/issues/2672>) > * > > igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html> > (i915#2672 > <https://gitlab.freedesktop.org/drm/intel/issues/2672>) +3 > similar issues > * > > igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode: > > o shard-iclb: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html> > (i915#2672 > <https://gitlab.freedesktop.org/drm/intel/issues/2672> / > i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>) > * > > igt@kms_frontbuffer_tracking@fbcpsr-suspend: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +55 > similar issues > * > > igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb5/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html> > -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html> > (i915#5176 > <https://gitlab.freedesktop.org/drm/intel/issues/5176>) +1 > similar issue > * > > igt@kms_psr2_sf@cursor-plane-move-continuous-sf: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#658 > <https://gitlab.freedesktop.org/drm/intel/issues/658>) +1 > similar issue > * > > igt@kms_psr@psr2_basic: > > o shard-apl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl3/igt@kms_psr@psr2_basic.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +20 > similar issues > * > > igt@kms_psr@psr2_cursor_blt: > > o shard-iclb: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html> > -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html> > (fdo#109441 <https://bugs.freedesktop.org/show_bug.cgi?id=109441>) > * > > igt@kms_writeback@writeback-invalid-parameters: > > o shard-skl: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@kms_writeback@writeback-invalid-parameters.html> > (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / > i915#2437 <https://gitlab.freedesktop.org/drm/intel/issues/2437>) > * > > igt@perf_pmu@enable-race@vecs0: > > o shard-glk: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk2/igt@perf_pmu@enable-race@vecs0.html> > -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk2/igt@perf_pmu@enable-race@vecs0.html> > (i915#118 <https://gitlab.freedesktop.org/drm/intel/issues/118>) > > > Possible fixes > > * > > igt@gem_exec_balancer@parallel-contexts: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb6/igt@gem_exec_balancer@parallel-contexts.html> > (i915#4525 > <https://gitlab.freedesktop.org/drm/intel/issues/4525>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb1/igt@gem_exec_balancer@parallel-contexts.html> > * > > igt@gem_mmap_offset@bad-object: > > o shard-skl: DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl4/igt@gem_mmap_offset@bad-object.html> > (i915#1982 > <https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl10/igt@gem_mmap_offset@bad-object.html> > +3 similar issues > * > > igt@gem_workarounds@suspend-resume-context: > > o shard-apl: DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-apl3/igt@gem_workarounds@suspend-resume-context.html> > (i915#180 > <https://gitlab.freedesktop.org/drm/intel/issues/180>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl1/igt@gem_workarounds@suspend-resume-context.html> > +2 similar issues > * > > igt@i915_pm_rpm@basic-pci-d3-state: > > o shard-iclb: FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb3/igt@i915_pm_rpm@basic-pci-d3-state.html> > -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@i915_pm_rpm@basic-pci-d3-state.html> > * > > igt@i915_pm_rps@engine-order: > > o shard-apl: FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-apl8/igt@i915_pm_rps@engine-order.html> > (i915#6537 > <https://gitlab.freedesktop.org/drm/intel/issues/6537>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-apl2/igt@i915_pm_rps@engine-order.html> > * > > igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1: > > o shard-skl: FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl5/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html> > (i915#2122 > <https://gitlab.freedesktop.org/drm/intel/issues/2122>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl4/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html> > +2 similar issues > * > > igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1: > > o shard-glk: DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk9/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html> > (i915#118 > <https://gitlab.freedesktop.org/drm/intel/issues/118>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk6/igt@kms_plane_lowres@tiling-y@pipe-a-hdmi-a-1.html> > * > > igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1: > > o shard-glk: FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk9/igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1.html> > (i915#7307 > <https://gitlab.freedesktop.org/drm/intel/issues/7307>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk6/igt@kms_plane_lowres@tiling-y@pipe-c-hdmi-a-1.html> > +1 similar issue > * > > igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html> > (i915#5176 > <https://gitlab.freedesktop.org/drm/intel/issues/5176>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html> > +2 similar issues > * > > igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html> > (i915#5235 > <https://gitlab.freedesktop.org/drm/intel/issues/5235>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html> > +2 similar issues > * > > igt@kms_psr@psr2_basic: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb3/igt@kms_psr@psr2_basic.html> > (fdo#109441 > <https://bugs.freedesktop.org/show_bug.cgi?id=109441>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb2/igt@kms_psr@psr2_basic.html> > * > > igt@kms_psr_stress_test@invalidate-primary-flip-overlay: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb5/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html> > (i915#5519 > <https://gitlab.freedesktop.org/drm/intel/issues/5519>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html> > * > > igt@perf@polling: > > o shard-skl: FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl9/igt@perf@polling.html> > (i915#1542 > <https://gitlab.freedesktop.org/drm/intel/issues/1542>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl9/igt@perf@polling.html> > * > > igt@prime_mmap_coherency@ioctl-errors: > > o shard-skl: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl3/igt@prime_mmap_coherency@ioctl-errors.html> > (i915#2295 > <https://gitlab.freedesktop.org/drm/intel/issues/2295>) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@prime_mmap_coherency@ioctl-errors.html> > > > Warnings > > * > > igt@gem_pread@exhaustion: > > o > > shard-tglb: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-tglb5/igt@gem_pread@exhaustion.html> > (i915#7248 > <https://gitlab.freedesktop.org/drm/intel/issues/7248>) -> > WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-tglb3/igt@gem_pread@exhaustion.html> > (i915#2658 <https://gitlab.freedesktop.org/drm/intel/issues/2658>) > > o > > shard-glk: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk9/igt@gem_pread@exhaustion.html> > (i915#7248 > <https://gitlab.freedesktop.org/drm/intel/issues/7248>) -> > WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk6/igt@gem_pread@exhaustion.html> > (i915#2658 <https://gitlab.freedesktop.org/drm/intel/issues/2658>) > > * > > igt@gem_pwrite@basic-exhaustion: > > o > > shard-glk: WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-glk5/igt@gem_pwrite@basic-exhaustion.html> > (i915#2658 > <https://gitlab.freedesktop.org/drm/intel/issues/2658>) -> > INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-glk7/igt@gem_pwrite@basic-exhaustion.html> > (i915#7248 <https://gitlab.freedesktop.org/drm/intel/issues/7248>) > > o > > shard-skl: TIMEOUT > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl3/igt@gem_pwrite@basic-exhaustion.html> > (i915#7248 > <https://gitlab.freedesktop.org/drm/intel/issues/7248>) -> > INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl1/igt@gem_pwrite@basic-exhaustion.html> > (i915#7248 <https://gitlab.freedesktop.org/drm/intel/issues/7248>) > > * > > igt@i915_pm_dc@dc3co-vpb-simulation: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html> > (i915#588 > <https://gitlab.freedesktop.org/drm/intel/issues/588>) -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html> > (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>) > * > > igt@kms_cursor_legacy@cursor-vs-flip@toggle: > > o shard-skl: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-skl6/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html> > -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-skl9/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html> > (i915#5072 <https://gitlab.freedesktop.org/drm/intel/issues/5072>) > * > > igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf: > > o shard-iclb: SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html> > (i915#2920 > <https://gitlab.freedesktop.org/drm/intel/issues/2920>) -> > SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110426v1/shard-iclb6/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html> > (i915#658 <https://gitlab.freedesktop.org/drm/intel/issues/658>) > > > Build changes > > * Linux: CI_DRM_12332 -> Patchwork_110426v1 > > CI-20190529: 20190529 > CI_DRM_12332: 601b2ef606e4b83d5518aa6a5011bb2b1c5954d9 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_110426v1: 601b2ef606e4b83d5518aa6a5011bb2b1c5954d9 @ > git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ > git://anongit.freedesktop.org/piglit >
Hi Nirmoy, On Wed, Nov 02, 2022 at 04:57:09PM +0100, Nirmoy Das wrote: > From: Chris Wilson <chris@chris-wilson.co.uk> > > The goal in launching the request smoketest is to have sufficient tasks > running across the system such that we are likely to detect concurrency > issues. We aim to have 2 tasks using the same engine, gt, device (each > level of locking around submission and signaling) running at the same > time. While tasks may not be running all the time as they synchronise > with the gpu, they will be running most of the time, in which case > having many more tasks than cores available is wasteful (and > dramatically increases the workload causing excess runtime). Aim to > limit the number of tasks such that there is at least 2 running per > engine, spreading surplus cores around the engines (rather than running > a task per core per engine.) > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Pushed in intel-drm-gt-next. Thanks, Andi > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c > index a46350c37e9d..4380473ceb98 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_request.c > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c > @@ -1710,7 +1710,8 @@ static int live_breadcrumbs_smoketest(void *arg) > { > struct drm_i915_private *i915 = arg; > const unsigned int nengines = num_uabi_engines(i915); > - const unsigned int ncpus = num_online_cpus(); > + const unsigned int ncpus = /* saturate with nengines * ncpus */ > + max_t(int, 2, DIV_ROUND_UP(num_online_cpus(), nengines)); > unsigned long num_waits, num_fences; > struct intel_engine_cs *engine; > struct smoke_thread *threads; > @@ -1782,7 +1783,7 @@ static int live_breadcrumbs_smoketest(void *arg) > goto out_flush; > } > /* One ring interleaved between requests from all cpus */ > - smoke[idx].max_batch /= num_online_cpus() + 1; > + smoke[idx].max_batch /= ncpus + 1; > pr_debug("Limiting batches to %d requests on %s\n", > smoke[idx].max_batch, engine->name); > > -- > 2.38.0
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c index a46350c37e9d..4380473ceb98 100644 --- a/drivers/gpu/drm/i915/selftests/i915_request.c +++ b/drivers/gpu/drm/i915/selftests/i915_request.c @@ -1710,7 +1710,8 @@ static int live_breadcrumbs_smoketest(void *arg) { struct drm_i915_private *i915 = arg; const unsigned int nengines = num_uabi_engines(i915); - const unsigned int ncpus = num_online_cpus(); + const unsigned int ncpus = /* saturate with nengines * ncpus */ + max_t(int, 2, DIV_ROUND_UP(num_online_cpus(), nengines)); unsigned long num_waits, num_fences; struct intel_engine_cs *engine; struct smoke_thread *threads; @@ -1782,7 +1783,7 @@ static int live_breadcrumbs_smoketest(void *arg) goto out_flush; } /* One ring interleaved between requests from all cpus */ - smoke[idx].max_batch /= num_online_cpus() + 1; + smoke[idx].max_batch /= ncpus + 1; pr_debug("Limiting batches to %d requests on %s\n", smoke[idx].max_batch, engine->name);