diff mbox series

[v2] drm/i915/psr: Add continuous full frame bit together with single

Message ID 20221201072308.1905679-1-jouni.hogander@intel.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm/i915/psr: Add continuous full frame bit together with single | expand

Commit Message

Hogander, Jouni Dec. 1, 2022, 7:23 a.m. UTC 
Currently we are observing occasionally display flickering or complete
freeze. This is narrowed down to be caused by single full frame update
(SFF).

SFF bit after it's written gets cleared by HW in subsequent vblank
i.e. when the update is sent to the panel. SFF bit is required to be
written together with partial frame update (PFU) bit. After the SFF
bit gets cleared by the HW psr2 man trk ctl register still contains
PFU bit. If there is subsequent update for any reason we will end up
having selective update/fetch configuration where start line is 0 and
end line is 0. Also selective fetch configuration for the planes is
not properly performed. This seems to be causing problems with some
panels.

Using CFF without SFF doesn't work either because it may happen that
psr2 man track ctl register is overwritten by next update before
vblank triggers sending the update. This is causing problems to
psr_invalidate/flush. Using CFF and SFF together solves the problems
as SFF is cleared only by HW in subsequent vblank and the update gets
sent.

Fix the flickering/freeze issue by keeping CFF bit as set when PSR2 is
enabled unless there is a properly configured selective update via
atomic commit.

v2:
 - Improve commit message and comments
 - No functional changes

This is also workaround for HSD 14014971508

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>

Reported-by: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Tested-by: Lee Shawn C <shawn.c.lee@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Hogander, Jouni Dec. 21, 2022, 2:42 p.m. UTC | #1 
Possible regression found by CI is not related to my patch. Failure is in device without PSR2 panel while my patch is just changing PSR2 flows.

BR,

Jouni Högander

On Thu, 2022-12-01 at 18:44 +0000, Patchwork wrote:
Patch Details
Series: drm/i915/psr: Add continuous full frame bit together with single (rev2)
URL:    https://patchwork.freedesktop.org/series/111420/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/index.html
CI Bug Log - changes from CI_DRM_12457_full -> Patchwork_111420v2_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_111420v2_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111420v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (11 -> 11)

No changes in participating hosts

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_111420v2_full:

IGT changes
Possible regressions

  *   igt@kms_rotation_crc@multiplane-rotation-cropping-top:
     *   shard-iclb: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html>

Known issues

Here are the changes found in Patchwork_111420v2_full that come from known issues:

CI changes
Issues hit

  *   boot:
     *   shard-snb: (PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-snb4/boot.html>) -> (PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb5/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>, PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb4/boot.html>) (i915#4338<https://gitlab.freedesktop.org/drm/intel/issues/4338>)

IGT changes
Issues hit

  *   igt@gem_create@create-massive:

     *   shard-skl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl7/igt@gem_create@create-massive.html> (i915#4991<https://gitlab.freedesktop.org/drm/intel/issues/4991>)
  *   igt@gem_ctx_persistence@engines-queued:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/igt@gem_ctx_persistence@engines-queued.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#1099<https://gitlab.freedesktop.org/drm/intel/issues/1099>)
  *   igt@gem_exec_balancer@parallel-keep-in-fence:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html> (i915#4525<https://gitlab.freedesktop.org/drm/intel/issues/4525>)
  *   igt@gem_softpin@evict-single-offset:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-tglb5/igt@gem_softpin@evict-single-offset.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-tglb7/igt@gem_softpin@evict-single-offset.html> (i915#4171<https://gitlab.freedesktop.org/drm/intel/issues/4171>)
  *   igt@gem_userptr_blits@unsync-unmap:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@gem_userptr_blits@unsync-unmap.html> (i915#3297<https://gitlab.freedesktop.org/drm/intel/issues/3297>)
  *   igt@gem_vm_create@invalid-create:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/igt@gem_vm_create@invalid-create.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +76 similar issues
  *   igt@i915_pm_dc@dc6-dpms:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html> (i915#3989<https://gitlab.freedesktop.org/drm/intel/issues/3989> / i915#454<https://gitlab.freedesktop.org/drm/intel/issues/454>)
  *   igt@i915_pm_sseu@full-enable:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl9/igt@i915_pm_sseu@full-enable.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@i915_pm_sseu@full-enable.html> (i915#6991<https://gitlab.freedesktop.org/drm/intel/issues/6991>)
  *   igt@i915_suspend@forcewake:

     *   shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl3/igt@i915_suspend@forcewake.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-apl8/igt@i915_suspend@forcewake.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>)
  *   igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180.html> (fdo#110723<https://bugs.freedesktop.org/show_bug.cgi?id=110723>)
  *   igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#3886<https://gitlab.freedesktop.org/drm/intel/issues/3886>)
  *   igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html> (fdo#109278<https://bugs.freedesktop.org/show_bug.cgi?id=109278>) +1 similar issue
  *   igt@kms_chamelium@dp-edid-read:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_chamelium@dp-edid-read.html> (fdo#109284<https://bugs.freedesktop.org/show_bug.cgi?id=109284> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>)
  *   igt@kms_chamelium@hdmi-crc-nonplanar-formats:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-snb7/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +2 similar issues
  *   igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>)
  *   igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>) +1 similar issue
  *   igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html> (i915#2672<https://gitlab.freedesktop.org/drm/intel/issues/2672>) +2 similar issues
  *   igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html> (i915#2587<https://gitlab.freedesktop.org/drm/intel/issues/2587> / i915#2672<https://gitlab.freedesktop.org/drm/intel/issues/2672>) +2 similar issues
  *   igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555>) +1 similar issue
  *   igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html> (fdo#109280<https://bugs.freedesktop.org/show_bug.cgi?id=109280>) +3 similar issues
  *   igt@kms_multipipe_modeset@basic-max-pipe-crc-check:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html> (i915#1839<https://gitlab.freedesktop.org/drm/intel/issues/1839>)
  *   igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1:

     *   shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1.html> (i915#4573<https://gitlab.freedesktop.org/drm/intel/issues/4573>) +1 similar issue
  *   igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1:

     *   shard-skl: NOTRUN -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1.html> (IGT#6<https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6>)
  *   igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html> (fdo#111068<https://bugs.freedesktop.org/show_bug.cgi?id=111068> / i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>)
  *   igt@kms_psr2_su@page_flip-p010:

     *   shard-iclb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@kms_psr2_su@page_flip-p010.html> (fdo#109642<https://bugs.freedesktop.org/show_bug.cgi?id=109642> / fdo#111068<https://bugs.freedesktop.org/show_bug.cgi?id=111068> / i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>)
  *   igt@kms_psr@psr2_cursor_blt:

     *   shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) +2 similar issues
  *   igt@kms_vrr@flipline:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@kms_vrr@flipline.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +31 similar issues
  *   igt@kms_writeback@writeback-check-output:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl7/igt@kms_writeback@writeback-check-output.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2437<https://gitlab.freedesktop.org/drm/intel/issues/2437>)
  *   igt@perf@blocking:

     *   shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl9/igt@perf@blocking.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl6/igt@perf@blocking.html> (i915#1542<https://gitlab.freedesktop.org/drm/intel/issues/1542>)
  *   igt@perf_pmu@interrupts:

     *   shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@perf_pmu@interrupts.html> (i915#7318<https://gitlab.freedesktop.org/drm/intel/issues/7318>)
  *   igt@sysfs_clients@busy:

     *   shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl9/igt@sysfs_clients@busy.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2994<https://gitlab.freedesktop.org/drm/intel/issues/2994>)

Possible fixes

  *   igt@fbdev@unaligned-write:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@fbdev@unaligned-write.html> (i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@fbdev@unaligned-write.html>
  *   igt@feature_discovery@psr2:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@feature_discovery@psr2.html> (i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@feature_discovery@psr2.html>
  *   igt@gem_ctx_persistence@legacy-engines-hang@blt:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html> (i915#6252<https://gitlab.freedesktop.org/drm/intel/issues/6252>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@gem_ctx_persistence@legacy-engines-hang@blt.html>
  *   igt@gem_eio@reset-stress:

     *   {shard-dg1}: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-dg1-17/igt@gem_eio@reset-stress.html> (i915#5784<https://gitlab.freedesktop.org/drm/intel/issues/5784>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-dg1-15/igt@gem_eio@reset-stress.html>
  *   igt@gem_exec_balancer@parallel-out-fence:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@gem_exec_balancer@parallel-out-fence.html> (i915#4525<https://gitlab.freedesktop.org/drm/intel/issues/4525>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html> +1 similar issue
  *   igt@gem_exec_fair@basic-pace-share@rcs0:

     *   {shard-rkl}: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-6/igt@gem_exec_fair@basic-pace-share@rcs0.html> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html>
  *   igt@gem_exec_reloc@basic-gtt:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-4/igt@gem_exec_reloc@basic-gtt.html> (i915#3281<https://gitlab.freedesktop.org/drm/intel/issues/3281>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-5/igt@gem_exec_reloc@basic-gtt.html> +4 similar issues
  *   igt@gem_exec_whisper@basic-contexts-forked:

     *   shard-iclb: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb1/igt@gem_exec_whisper@basic-contexts-forked.html> (i915#6453<https://gitlab.freedesktop.org/drm/intel/issues/6453>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@gem_exec_whisper@basic-contexts-forked.html>
  *   igt@gem_partial_pwrite_pread@write-snoop:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@gem_partial_pwrite_pread@write-snoop.html> (i915#3282<https://gitlab.freedesktop.org/drm/intel/issues/3282>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-5/igt@gem_partial_pwrite_pread@write-snoop.html>
  *   igt@gen9_exec_parse@bb-start-out:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@gen9_exec_parse@bb-start-out.html> (i915#2527<https://gitlab.freedesktop.org/drm/intel/issues/2527>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html> +1 similar issue
  *   igt@i915_pipe_stress@stress-xrgb8888-ytiled:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html> (i915#4098<https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html> +1 similar issue
  *   igt@i915_pm_rc6_residency@rc6-idle@vcs0:

     *   shard-skl: WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl10/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html> (i915#1804<https://gitlab.freedesktop.org/drm/intel/issues/1804>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl9/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html>
  *   igt@i915_pm_rpm@modeset-lpsp:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@i915_pm_rpm@modeset-lpsp.html> (i915#1397<https://gitlab.freedesktop.org/drm/intel/issues/1397>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp.html>
  *   igt@i915_pm_rpm@pm-tiling:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@i915_pm_rpm@pm-tiling.html> (fdo#109308<https://bugs.freedesktop.org/show_bug.cgi?id=109308>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@i915_pm_rpm@pm-tiling.html>
  *   igt@i915_pm_rps@engine-order:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl6/igt@i915_pm_rps@engine-order.html> (i915#6537<https://gitlab.freedesktop.org/drm/intel/issues/6537>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-apl8/igt@i915_pm_rps@engine-order.html>
  *   igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:

     *   shard-iclb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html>
  *   igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl6/igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1.html> (i915#2122<https://gitlab.freedesktop.org/drm/intel/issues/2122>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-apl2/igt@kms_flip@plain-flip-ts-check-interruptible@a-dp1.html>
  *   igt@kms_frontbuffer_tracking@fbc-tiling-linear:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#4098<https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html> +20 similar issues
  *   igt@kms_frontbuffer_tracking@psr-suspend:

     *   shard-skl: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl10/igt@kms_frontbuffer_tracking@psr-suspend.html> (i915#7255<https://gitlab.freedesktop.org/drm/intel/issues/7255>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@kms_frontbuffer_tracking@psr-suspend.html>
  *   igt@kms_plane@plane-position-covered@pipe-a-planes:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-5/igt@kms_plane@plane-position-covered@pipe-a-planes.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#3558<https://gitlab.freedesktop.org/drm/intel/issues/3558>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@kms_plane@plane-position-covered@pipe-a-planes.html> +1 similar issue
  *   igt@kms_prime@basic-crc-vgem@second-to-first:

     *   shard-skl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl7/igt@kms_prime@basic-crc-vgem@second-to-first.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl1/igt@kms_prime@basic-crc-vgem@second-to-first.html>
  *   igt@kms_psr@psr2_no_drrs:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_psr@psr2_no_drrs.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb2/igt@kms_psr@psr2_no_drrs.html> +1 similar issue
  *   igt@kms_psr@sprite_plane_move:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@kms_psr@sprite_plane_move.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@kms_psr@sprite_plane_move.html> +1 similar issue
  *   igt@kms_psr_stress_test@invalidate-primary-flip-overlay:

     *   shard-tglb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-tglb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html> (i915#5519<https://gitlab.freedesktop.org/drm/intel/issues/5519>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-tglb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html>
  *   igt@kms_rotation_crc@exhaust-fences:

     *   {shard-rkl}: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-rkl-2/igt@kms_rotation_crc@exhaust-fences.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845> / i915#4098<https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-rkl-6/igt@kms_rotation_crc@exhaust-fences.html> +28 similar issues
  *   igt@kms_sysfs_edid_timing:

     *   shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl4/igt@kms_sysfs_edid_timing.html> (i915#6493<https://gitlab.freedesktop.org/drm/intel/issues/6493>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl1/igt@kms_sysfs_edid_timing.html>

Warnings

  *   igt@dmabuf@all@dma_fence_chain:

     *   shard-skl: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl10/igt@dmabuf@all@dma_fence_chain.html> (i915#6949<https://gitlab.freedesktop.org/drm/intel/issues/6949>) -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl7/igt@dmabuf@all@dma_fence_chain.html> (i915#6949<https://gitlab.freedesktop.org/drm/intel/issues/6949>)
  *   igt@gem_pread@exhaustion:

     *   shard-tglb: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-tglb3/igt@gem_pread@exhaustion.html> (i915#7248<https://gitlab.freedesktop.org/drm/intel/issues/7248>) -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-tglb2/igt@gem_pread@exhaustion.html> (i915#2658<https://gitlab.freedesktop.org/drm/intel/issues/2658>)
  *   igt@i915_pm_dc@dc3co-vpb-simulation:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html> (i915#588<https://gitlab.freedesktop.org/drm/intel/issues/588>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html> (i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>)
  *   igt@i915_pm_rc6_residency@rc6-idle@vecs0:

     *   shard-iclb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html> (i915#2684<https://gitlab.freedesktop.org/drm/intel/issues/2684>) -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb3/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html> (i915#2684<https://gitlab.freedesktop.org/drm/intel/issues/2684>)
  *   igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html> (i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html> (i915#2920<https://gitlab.freedesktop.org/drm/intel/issues/2920>)
  *   igt@kms_psr2_sf@overlay-plane-update-continuous-sf:

     *   shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html> (fdo#111068<https://bugs.freedesktop.org/show_bug.cgi?id=111068> / i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html> (i915#2920<https://gitlab.freedesktop.org/drm/intel/issues/2920>)
  *   igt@runner@aborted:

     *   shard-apl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-apl6/igt@runner@aborted.html>) (i915#3002<https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-apl7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-apl1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-apl8/igt@runner@aborted.html>) (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180> / i915#3002<https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)

     *   shard-skl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl10/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12457/shard-skl10/igt@runner@aborted.html>) (i915#3002<https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312> / i915#6949<https://gitlab.freedesktop.org/drm/intel/issues/6949>) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl10/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111420v2/shard-skl7/igt@runner@aborted.html>) (i915#3002<https://gitlab.freedesktop.org/drm/intel/issues/3002> / i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

  *   Linux: CI_DRM_12457 -> Patchwork_111420v2

CI-20190529: 20190529
CI_DRM_12457: 42273934c8b473fd88e6689a589e9b4050c46bec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7076: 888725538e0d6bbb94bbbb1ac278d4afcbbbdad0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111420v2: 42273934c8b473fd88e6689a589e9b4050c46bec @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 5b678916e6db..619d532bf322 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1510,7 +1510,8 @@  static void psr_force_hw_tracking_exit(struct intel_dp *intel_dp)
 			       PSR2_MAN_TRK_CTL(intel_dp->psr.transcoder),
 			       man_trk_ctl_enable_bit_get(dev_priv) |
 			       man_trk_ctl_partial_frame_bit_get(dev_priv) |
-			       man_trk_ctl_single_full_frame_bit_get(dev_priv));
+			       man_trk_ctl_single_full_frame_bit_get(dev_priv) |
+			       man_trk_ctl_continuos_full_frame(dev_priv));
 
 	/*
 	 * Display WA #0884: skl+
@@ -1624,11 +1625,8 @@  static void psr2_man_trk_ctl_calc(struct intel_crtc_state *crtc_state,
 	val |= man_trk_ctl_partial_frame_bit_get(dev_priv);
 
 	if (full_update) {
-		/*
-		 * Not applying Wa_14014971508:adlp as we do not support the
-		 * feature that requires this workaround.
-		 */
 		val |= man_trk_ctl_single_full_frame_bit_get(dev_priv);
+		val |= man_trk_ctl_continuos_full_frame(dev_priv);
 		goto exit;
 	}
 
@@ -2307,12 +2305,15 @@  static void _psr_flush_handle(struct intel_dp *intel_dp)
 			/* can we turn CFF off? */
 			if (intel_dp->psr.busy_frontbuffer_bits == 0) {
 				u32 val = man_trk_ctl_enable_bit_get(dev_priv) |
-					  man_trk_ctl_partial_frame_bit_get(dev_priv) |
-					  man_trk_ctl_single_full_frame_bit_get(dev_priv);
+					man_trk_ctl_partial_frame_bit_get(dev_priv) |
+					man_trk_ctl_single_full_frame_bit_get(dev_priv) |
+					man_trk_ctl_continuos_full_frame(dev_priv);
 
 				/*
-				 * turn continuous full frame off and do a single
-				 * full frame
+				 * Set psr2_sel_fetch_cff_enabled as false to allow selective
+				 * updates. Still keep cff bit enabled as we don't have proper
+				 * SU configuration in case update is sent for any reason after
+				 * sff bit gets cleared by the HW on next vblank.
 				 */
 				intel_de_write(dev_priv, PSR2_MAN_TRK_CTL(intel_dp->psr.transcoder),
 					       val);