| Message ID | 20230215161405.187368-4-thomas.hellstrom@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add a TTM shrinker | expand |
Am 15.02.23 um 17:13 schrieb Thomas Hellström: > New code is recommended to use the BIT macro instead of the explicit > shifts. Change the older defines so that we can keep the style consistent > with upcoming changes. > > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > --- > include/drm/ttm/ttm_tt.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h > index b7d3f3843f1e..cc54be1912e1 100644 > --- a/include/drm/ttm/ttm_tt.h > +++ b/include/drm/ttm/ttm_tt.h > @@ -83,12 +83,12 @@ struct ttm_tt { > * set by TTM after ttm_tt_populate() has successfully returned, and is > * then unset when TTM calls ttm_tt_unpopulate(). > */ > -#define TTM_TT_FLAG_SWAPPED (1 << 0) > -#define TTM_TT_FLAG_ZERO_ALLOC (1 << 1) > -#define TTM_TT_FLAG_EXTERNAL (1 << 2) > -#define TTM_TT_FLAG_EXTERNAL_MAPPABLE (1 << 3) > +#define TTM_TT_FLAG_SWAPPED BIT(0) > +#define TTM_TT_FLAG_ZERO_ALLOC BIT(1) > +#define TTM_TT_FLAG_EXTERNAL BIT(2) > +#define TTM_TT_FLAG_EXTERNAL_MAPPABLE BIT(3) > > -#define TTM_TT_FLAG_PRIV_POPULATED (1U << 31) > +#define TTM_TT_FLAG_PRIV_POPULATED BIT(31) While at it please just use BIT(4) for this, there is actually nothing special about it. Christian. > uint32_t page_flags; > /** @num_pages: Number of pages in the page array. */ > uint32_t num_pages;
diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h index b7d3f3843f1e..cc54be1912e1 100644 --- a/include/drm/ttm/ttm_tt.h +++ b/include/drm/ttm/ttm_tt.h @@ -83,12 +83,12 @@ struct ttm_tt { * set by TTM after ttm_tt_populate() has successfully returned, and is * then unset when TTM calls ttm_tt_unpopulate(). */ -#define TTM_TT_FLAG_SWAPPED (1 << 0) -#define TTM_TT_FLAG_ZERO_ALLOC (1 << 1) -#define TTM_TT_FLAG_EXTERNAL (1 << 2) -#define TTM_TT_FLAG_EXTERNAL_MAPPABLE (1 << 3) +#define TTM_TT_FLAG_SWAPPED BIT(0) +#define TTM_TT_FLAG_ZERO_ALLOC BIT(1) +#define TTM_TT_FLAG_EXTERNAL BIT(2) +#define TTM_TT_FLAG_EXTERNAL_MAPPABLE BIT(3) -#define TTM_TT_FLAG_PRIV_POPULATED (1U << 31) +#define TTM_TT_FLAG_PRIV_POPULATED BIT(31) uint32_t page_flags; /** @num_pages: Number of pages in the page array. */ uint32_t num_pages;
New code is recommended to use the BIT macro instead of the explicit shifts. Change the older defines so that we can keep the style consistent with upcoming changes. Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> --- include/drm/ttm/ttm_tt.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)