From patchwork Sat Mar 18 00:46:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Harrison X-Patchwork-Id: 13179640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2497CC6FD1D for ; Sat, 18 Mar 2023 00:47:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C52E10E158; Sat, 18 Mar 2023 00:47:58 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B62A10E158 for ; Sat, 18 Mar 2023 00:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679100476; x=1710636476; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Msi1NikWIi16Ei2S1R8vvyEju2cIcpebbUpp3VinUKQ=; b=iy3N+XDFE/uFOeIMR8PiHsplVQUYkB4opZ0oAJKcVnDgwpZvt2hXKe7+ PaQErs0Qk5WawVeO8Xv/NndM2WHJrb86iO5HZGa3rtiAZdEiC9tiRBbiR X6gwp4n4BOvme/d4VWU8LW3740az7nWyHQCTXaEwG+yGPfUYXciKpHb3Q iiy/skVs+B7XOocF8tHtOh6PPhd44dd6ESUAGB84SGCn/46HVCAZhqCoA 3C85it0GbLP6tzAn30mIdo7POmUJ4M+se2JCoekAjqczAXCIxgKXj3fyA gEsxcjBWqrHrh48vpEwmyQ5Pz3iZeAhccOho/1RydAnumDsfipltiGrlI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="318792387" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="318792387" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 17:47:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="790942111" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="790942111" Received: from relo-linux-5.jf.intel.com ([10.165.21.152]) by fmsmga002.fm.intel.com with ESMTP; 17 Mar 2023 17:47:50 -0700 From: John.C.Harrison@Intel.com To: stable@vger.kernel.org Date: Fri, 17 Mar 2023 17:46:59 -0700 Message-Id: <20230318004659.817361-1-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <167820537619158@kroah.com> References: <167820537619158@kroah.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 5.10.y] drm/i915: Don't use stolen memory for ring buffers with LLC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Chris Wilson , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: John Harrison Direction from hardware is that stolen memory should never be used for ring buffer allocations on platforms with LLC. There are too many caching pitfalls due to the way stolen memory accesses are routed. So it is safest to just not use it. Signed-off-by: John Harrison Fixes: c58b735fc762 ("drm/i915: Allocate rings from stolen") Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: # v4.9+ Tested-by: Jouni Högander Reviewed-by: Daniele Ceraolo Spurio Link: https://patchwork.freedesktop.org/patch/msgid/20230216011101.1909009-2-John.C.Harrison@Intel.com (cherry picked from commit f54c1f6c697c4297f7ed94283c184acc338a5cf8) Signed-off-by: Jani Nikula (cherry picked from commit 690e0ec8e63da9a29b39fedc6ed5da09c7c82651) Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c index 69b2e5509d67..de67b2745258 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring.c +++ b/drivers/gpu/drm/i915/gt/intel_ring.c @@ -108,7 +108,7 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size) struct i915_vma *vma; obj = ERR_PTR(-ENODEV); - if (i915_ggtt_has_aperture(ggtt)) + if (i915_ggtt_has_aperture(ggtt) && !HAS_LLC(i915)) obj = i915_gem_object_create_stolen(i915, size); if (IS_ERR(obj)) obj = i915_gem_object_create_internal(i915, size);