From patchwork Fri Mar 31 20:01:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umesh Nerlige Ramappa X-Patchwork-Id: 13196545 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E258BC761A6 for ; Fri, 31 Mar 2023 20:01:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E45D010F2F5; Fri, 31 Mar 2023 20:01:34 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4EC310E569 for ; Fri, 31 Mar 2023 20:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680292891; x=1711828891; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Cei3VrE9UWDNlhW6Ni6AMveChFqzffmdyzLsLxuAASE=; b=f9Ubp1/YEm+cPsJ+JlUNu0VfNt5YTeNG0F1I/h0nv5zGK/iuFkOw2fkr kBpJfwf7XW8KS1OccWmr7NbJLNv7UgZE1pJ9MZ1ulr/8sVgc+jp9lrRSw N+Qd5gxotTrS1Y9P7B7CWUTzz5dKIa4YsBU3wUQgiFmUHfCQm2gtwP8NJ FR8Xm6Etr8KkzUfN1o2RXGJ5BZrKyEDvqRTW3e3y2tSFndo5EbJ+GvteB PsR29nDfyDOLNyP5cNakDDFpcuWRESfoABW4wPYavTBSL2VC4TUPKmClQ MaKiLU1AkC7UjDKYeIsqOAVkh5zV8z2nDeYeNRXEkKe+XBnZLHhMfKN17 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="427827017" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="427827017" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 13:01:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="635409213" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="635409213" Received: from orsosgc001.jf.intel.com ([10.165.21.138]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 13:01:31 -0700 From: Umesh Nerlige Ramappa To: intel-gfx@lists.freedesktop.org Date: Fri, 31 Mar 2023 13:01:26 -0700 Message-Id: <20230331200126.1435110-1-umesh.nerlige.ramappa@intel.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The underlying mechanism used to provide the client specific utilization in fdinfo is context busyness. When a context switches out, the HW records the runtime in the specific context field. This information is accumulated in fdinfo. This information is independent of the scheduling backend as long as contexts are switching out in reasonable time. If a context is actively running on the engine, then the active busyness is calculated by using the delta between current time and the context switch in time. This part of the calculation depends on the scheduling backend. For GuC backends, this data comes entirely from GuC FW. The FW implementation is WIP. Enable fdinfo for GuC based platforms with the exception that long running contexts will not provide reliable busyness data unless they switch out at some reasonable point in time. Revert "drm/i915: Don't show engine information in fdinfo with GuC submission" This reverts commit 8d0e3decf26bc423d8b1c42c05636ccc05ea6b17. Resolves: https://gitlab.freedesktop.org/drm/intel/issues/8303 Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_drm_client.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c index e8fa172ebe5e..d18d0a3ed905 100644 --- a/drivers/gpu/drm/i915/i915_drm_client.c +++ b/drivers/gpu/drm/i915/i915_drm_client.c @@ -147,11 +147,7 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f) PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)); seq_printf(m, "drm-client-id:\t%u\n", client->id); - /* - * Temporarily skip showing client engine information with GuC submission till - * fetching engine busyness is implemented in the GuC submission backend - */ - if (GRAPHICS_VER(i915) < 8 || intel_uc_uses_guc_submission(&i915->gt0.uc)) + if (GRAPHICS_VER(i915) < 8) return; for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++)