From patchwork Sat May 6 00:58:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umesh Nerlige Ramappa X-Patchwork-Id: 13233203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1F4DC77B75 for ; Sat, 6 May 2023 00:58:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A817010E0EB; Sat, 6 May 2023 00:58:18 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 707BF10E0EB for ; Sat, 6 May 2023 00:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683334697; x=1714870697; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=vSHl0S4PqDkMqUJgW6ktHNSERN24+BULofJ6wFAAtfg=; b=PV5U5whN1zlkwPKYfEHIU8g9h5XnaZ8ei5A5W2ZTRVigvFtPpgmEfbOk rsenFcSLqICojOIa4QLc5j7ax2hDn4iehKAfjOY88sIXtY6JPoeWDNriD cUas66pKapujeemMIBcTpdDa1z/pt1y/wNEKtzk9z4zFKJBS+0PNIhXnS ZIlOZHgs9UYdeHBjgfSo7X2jsWgBPVT+hFQ04eQnaErcl/6naQVukvDTr 8YNzzrbyfFawYWMnNIqn+4YPX2rtkiv0byo39gOhxWw/FmOk0z47A7/UC awAYgy8dSVZC8hQ70eOEM7M/yIKT07JWPb9dGN26lhe9kbNA29Jhh0BRm A==; X-IronPort-AV: E=McAfee;i="6600,9927,10701"; a="377408312" X-IronPort-AV: E=Sophos;i="5.99,253,1677571200"; d="scan'208";a="377408312" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2023 17:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10701"; a="767326030" X-IronPort-AV: E=Sophos;i="5.99,253,1677571200"; d="scan'208";a="767326030" Received: from orsosgc001.jf.intel.com ([10.165.21.138]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2023 17:58:16 -0700 From: Umesh Nerlige Ramappa To: intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Ashutosh Dixit Date: Fri, 5 May 2023 17:58:12 -0700 Message-Id: <20230506005816.1891043-3-umesh.nerlige.ramappa@intel.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20230506005816.1891043-1-umesh.nerlige.ramappa@intel.com> References: <20230506005816.1891043-1-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 2/6] drm/i915/pmu: Skip sampling engines with no enabled counters X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Tvrtko Ursulin As we have more and more engines do not waste time sampling the ones no- one is monitoring. Signed-off-by: Tvrtko Ursulin Signed-off-by: Umesh Nerlige Ramappa Reviewed-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_pmu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c index 67fa6cd77529..ba769f7fc385 100644 --- a/drivers/gpu/drm/i915/i915_pmu.c +++ b/drivers/gpu/drm/i915/i915_pmu.c @@ -339,6 +339,9 @@ engines_sample(struct intel_gt *gt, unsigned int period_ns) return; for_each_engine(engine, gt, id) { + if (!engine->pmu.enable) + continue; + if (!intel_engine_pm_get_if_awake(engine)) continue;