From patchwork Fri Jun 16 22:11:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dong, Zhanjun" X-Patchwork-Id: 13283346 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E265EB64D7 for ; Fri, 16 Jun 2023 22:11:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5614E10E142; Fri, 16 Jun 2023 22:11:15 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BD5D10E142; Fri, 16 Jun 2023 22:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686953474; x=1718489474; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=MsOHNhkZdw47mpRisnLrelTXF7tLgbhgwW8ZJ6fjMEk=; b=gD7fL3vD6/NkMr5RtIl35Zlicxt+W/TxlVKQgWcekCIclY/cntmo/KRk kPz5JLPZ1T2PXRPmWSL326Sq0qDXM9v23IDySCEC7QJnFFSDReY4KuXm+ XmBxY0jgaR41OaBmE4Uve4obORa0RI2PSfN1HI1dcRkRZbgSOUyIpyqPU 8x/F0V/hhucsxVw+nvN7e88xxc/U2Qz/XG+EPogMviwrQGH0B78/RUyg0 YAkDwSf3dMnMjvMJ6tqD0ILtAy4dcJ2OIYTbHegiOihA6dxQwTHhLsJ2w bT7+VebQBb3oaxJvOS8hps90K+D8aXrIVj94ZmghVH7AQXEDQIP8mJxxp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10743"; a="359333674" X-IronPort-AV: E=Sophos;i="6.00,248,1681196400"; d="scan'208";a="359333674" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2023 15:11:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10743"; a="690403337" X-IronPort-AV: E=Sophos;i="6.00,248,1681196400"; d="scan'208";a="690403337" Received: from guc-pnp-dev-box-1.fm.intel.com ([10.1.27.12]) by orsmga006.jf.intel.com with ESMTP; 16 Jun 2023 15:11:12 -0700 From: Zhanjun Dong To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Date: Fri, 16 Jun 2023 15:11:10 -0700 Message-Id: <20230616221110.1045918-1-zhanjun.dong@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed. Signed-off-by: Zhanjun Dong Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c index b9640212d659..693d18e14b00 100644 --- a/drivers/gpu/drm/i915/gt/intel_timeline.c +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c @@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt) if (IS_ERR(obj)) return ERR_CAST(obj); - i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC); - vma = i915_vma_instance(obj, >->ggtt->vm, NULL); if (IS_ERR(vma)) i915_gem_object_put(obj);