diff mbox series

[2/4] drm/i915/adlp: Stop calling gen12lp_init_clock_gating()

Message ID 20230906234732.3728630-8-matthew.d.roper@intel.com (mailing list archive)
State New, archived
Headers show
Series Separate display workarounds from clock gating | expand

Commit Message

Matt Roper Sept. 6, 2023, 11:47 p.m. UTC 
The only programming that happens in gen12lp_init_clock_gating is for
display workarounds that are specific to display version 12 and are not
relevant to ADL-P's display version 13.

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/intel_clock_gating.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Lucas De Marchi Sept. 8, 2023, 9:46 p.m. UTC | #1 
On Wed, Sep 06, 2023 at 04:47:35PM -0700, Matt Roper wrote:
>The only programming that happens in gen12lp_init_clock_gating is for
>display workarounds that are specific to display version 12 and are not
>relevant to ADL-P's display version 13.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/i915/intel_clock_gating.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_clock_gating.c b/drivers/gpu/drm/i915/intel_clock_gating.c
>index 1f2e2d7087cb..2a4714c662b8 100644
>--- a/drivers/gpu/drm/i915/intel_clock_gating.c
>+++ b/drivers/gpu/drm/i915/intel_clock_gating.c
>@@ -375,8 +375,6 @@ static void gen12lp_init_clock_gating(struct drm_i915_private *i915)
>
> static void adlp_init_clock_gating(struct drm_i915_private *i915)
> {
>-	gen12lp_init_clock_gating(i915);
>-
> 	/* Wa_22011091694:adlp */
> 	intel_de_rmw(i915, GEN9_CLKGATE_DIS_5, 0, DPCE_GATING_DIS);
>
>-- 
>2.41.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_clock_gating.c b/drivers/gpu/drm/i915/intel_clock_gating.c
index 1f2e2d7087cb..2a4714c662b8 100644
--- a/drivers/gpu/drm/i915/intel_clock_gating.c
+++ b/drivers/gpu/drm/i915/intel_clock_gating.c
@@ -375,8 +375,6 @@  static void gen12lp_init_clock_gating(struct drm_i915_private *i915)
 
 static void adlp_init_clock_gating(struct drm_i915_private *i915)
 {
-	gen12lp_init_clock_gating(i915);
-
 	/* Wa_22011091694:adlp */
 	intel_de_rmw(i915, GEN9_CLKGATE_DIS_5, 0, DPCE_GATING_DIS);