From patchwork Mon Sep 18 13:42:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 13389665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC072CD13D2 for ; Mon, 18 Sep 2023 13:52:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC46C10E18E; Mon, 18 Sep 2023 13:52:32 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDA9210E18E; Mon, 18 Sep 2023 13:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695045148; x=1726581148; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Iu15LpajJeFsdcvmrO2uBd2L8V2RaUiH1BfPdkx8lqU=; b=OyrOXz/AV1nhYTcu6SCNjBgUrCm6Uw59rS0O0lJq4q1xXY2iJqQcwpge ZqjElz1KOtTwB3PxZlzdJgNnXvxgV7LSjtmP5v0kGpmv8XvBJ+GYU/sWl hjONKOkcreg7bT5AJEqRLHLocAUHTwigGkBANE81guU4YVC/RVt2IyaYk zUmeA0UvlfEF9Y7JnH0RGtQ/hy1YVD1O/rD6bnM7pcruA8dTB3s2mV0jq ptW2bN1aTe9y+YBVoScYGG6j6ePIAV/2IgSviTmxX/f4qJ2hQVjuWiuU+ l5FypHXhszB5CPDYNKTZEEzPPatyZsV1u70GoYaXWxKliq89SiafbGS3H Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="376969507" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="376969507" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 06:52:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="749030453" X-IronPort-AV: E=Sophos;i="6.02,156,1688454000"; d="scan'208";a="749030453" Received: from jkrzyszt-mobl2.ger.corp.intel.com ([10.213.18.199]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2023 06:52:26 -0700 From: Janusz Krzysztofik To: igt-dev@lists.freedesktop.org Date: Mon, 18 Sep 2023 15:42:52 +0200 Message-ID: <20230918134249.31645-21-janusz.krzysztofik@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230918134249.31645-19-janusz.krzysztofik@linux.intel.com> References: <20230918134249.31645-19-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t v3 02/17] lib/kunit: Stop loading kunit module explicitly X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, =?utf-8?q?Dominik_Karol_Pi=C4=85tkowski?= , Isabella Basso , Mauro Carvalho Chehab , intel-xe@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Since kmod functions we use for module loading can process module dependencies, there is no need to load the "kunit" module explicitly before loading a kunit test module. For the same reason we already don't unload the "kunit" module explicitly on cleanup. Drop the unnecessary operation. Signed-off-by: Janusz Krzysztofik Acked-by: Mauro Carvalho Chehab --- lib/igt_kmod.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c index 97667a896f..faf31afabc 100644 --- a/lib/igt_kmod.c +++ b/lib/igt_kmod.c @@ -789,12 +789,6 @@ static void __igt_kunit(const char *module_name, const char *opts) goto unload; } - /* The KUnit module is required for running any KUnit tests */ - ret = igt_kmod_load("kunit", NULL); - if (ret) { - skip = ret; - goto unload; - } ret = kmod_module_new_from_name(kmod_ctx(), "kunit", &kunit_kmod); if (ret) { igt_warn("Unable to load KUnit\n");