From patchwork Wed Sep 20 11:29:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jani Nikula X-Patchwork-Id: 13392561 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1C06CE79AA for ; Wed, 20 Sep 2023 11:29:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F034A10E170; Wed, 20 Sep 2023 11:29:08 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9531010E170 for ; Wed, 20 Sep 2023 11:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695209347; x=1726745347; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=epqE+Hkw13arMcKNAcqpQVy237ecwFpNj6OqLP5ylI4=; b=mKHsd9vkEgDhh4uD0deyJV43j1+07YaNA2ftv7kBK4EzUwrGDt6VObWi 3tarzwtRKxj8DKXYGa6Xnixh+sw4HCa5VzCwiTh4AAswCV+uwWQ4eBCoG BPad4AeL5/r3Ed8Gtyb8Knb//nEDA+AlRAup8Zz9JzZSNIvlYEL2us+xM 5G5r1C3dTyeWcKqRxM6LTSPtOmLfDVZbGBioeYipdkLYIaHdjizp6d4Tc fnCG+Uu2XUOpWmUGELvHImaf7gTKOyw6EXZuaMR837n5t4iDKdilw6nn0 i3CizO/H8YSGne4GXSFjuYCKnMABcxULvwIaXEaMKdQ1ZlzZRO/7wIQUm A==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="365244322" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="365244322" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 04:29:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="749864631" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="749864631" Received: from ptelkov-mobl2.ccr.corp.intel.com (HELO localhost) ([10.252.38.103]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 04:29:05 -0700 From: Jani Nikula To: intel-gfx@lists.freedesktop.org Date: Wed, 20 Sep 2023 14:29:01 +0300 Message-Id: <20230920112901.3315876-1-jani.nikula@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: [Intel-gfx] [PATCH] drm/i915: add a note about fec_enable with 128b/132b X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Add a note that fec_enable actually means FEC is to be enabled explicitly. 128b/132b always has FEC enabled, the driver doesn't need to enable it separately, and fec_enable will be false. Cc: Ville Syrjälä Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display_types.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h index 3c54fe2bfddd..f781a9755a52 100644 --- a/drivers/gpu/drm/i915/display/intel_display_types.h +++ b/drivers/gpu/drm/i915/display/intel_display_types.h @@ -1364,7 +1364,12 @@ struct intel_crtc_state { bool enhanced_framing; - /* Forward Error correction State */ + /* + * Forward Error Correction. + * + * Note: This will be false for 128b/132b, which will always have FEC + * enabled automatically. + */ bool fec_enable; bool sdp_split_enable;