| Message ID | 20230926091157.635438-1-arun.r.murthy@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Remove the module parameter 'fastboot' | expand |
On Tue, 26 Sep 2023, Arun R Murthy <arun.r.murthy@intel.com> wrote: > By default fastboot is enabled on all Display 9+ platforms and disabled > on older platforms. Its not necessary to retain this as a module > parameter. Cc: Ville Acked-by: Jani Nikula <jani.nikula@intel.com> > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 --- > drivers/gpu/drm/i915/i915_params.c | 5 ----- > drivers/gpu/drm/i915/i915_params.h | 1 - > 3 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index edbcf5968804..9d6e2d19d636 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -4986,9 +4986,6 @@ pipe_config_mismatch(bool fastset, const struct intel_crtc *crtc, > > static bool fastboot_enabled(struct drm_i915_private *dev_priv) > { > - if (dev_priv->params.fastboot != -1) > - return dev_priv->params.fastboot; > - > /* Enable fastboot by default on Skylake and newer */ > if (DISPLAY_VER(dev_priv) >= 9) > return true; > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 0a171b57fd8f..036c4c3ed6ed 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)"); > i915_param_named_unsafe(enable_dpt, bool, 0400, > "Enable display page table (DPT) (default: true)"); > > -i915_param_named(fastboot, int, 0400, > - "Try to skip unnecessary mode sets at boot time " > - "(0=disabled, 1=enabled) " > - "Default: -1 (use per-chip default)"); > - > i915_param_named_unsafe(load_detect_test, bool, 0400, > "Force-enable the VGA load detect code for testing (default:false). " > "For developers only."); > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h > index 68abf0ad6c00..d5194b039aab 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -72,7 +72,6 @@ struct drm_printer; > param(int, edp_vswing, 0, 0400) \ > param(unsigned int, reset, 3, 0600) \ > param(unsigned int, inject_probe_failure, 0, 0) \ > - param(int, fastboot, -1, 0600) \ > param(int, enable_dpcd_backlight, -1, 0600) \ > param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ > param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT, CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \
On Tue, Sep 26, 2023 at 02:41:57PM +0530, Arun R Murthy wrote: > By default fastboot is enabled on all Display 9+ platforms and disabled > on older platforms. Its not necessary to retain this as a module > parameter. > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 --- > drivers/gpu/drm/i915/i915_params.c | 5 ----- > drivers/gpu/drm/i915/i915_params.h | 1 - > 3 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index edbcf5968804..9d6e2d19d636 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -4986,9 +4986,6 @@ pipe_config_mismatch(bool fastset, const struct intel_crtc *crtc, > > static bool fastboot_enabled(struct drm_i915_private *dev_priv) > { > - if (dev_priv->params.fastboot != -1) > - return dev_priv->params.fastboot; > - > /* Enable fastboot by default on Skylake and newer */ > if (DISPLAY_VER(dev_priv) >= 9) > return true; I'd like to see a patch to eliminate fastboot_enabled() and associated logic entirely. Could be a separate patch I suppose. > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 0a171b57fd8f..036c4c3ed6ed 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)"); > i915_param_named_unsafe(enable_dpt, bool, 0400, > "Enable display page table (DPT) (default: true)"); > > -i915_param_named(fastboot, int, 0400, > - "Try to skip unnecessary mode sets at boot time " > - "(0=disabled, 1=enabled) " > - "Default: -1 (use per-chip default)"); > - > i915_param_named_unsafe(load_detect_test, bool, 0400, > "Force-enable the VGA load detect code for testing (default:false). " > "For developers only."); > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h > index 68abf0ad6c00..d5194b039aab 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -72,7 +72,6 @@ struct drm_printer; > param(int, edp_vswing, 0, 0400) \ > param(unsigned int, reset, 3, 0600) \ > param(unsigned int, inject_probe_failure, 0, 0) \ > - param(int, fastboot, -1, 0600) \ > param(int, enable_dpcd_backlight, -1, 0600) \ > param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ > param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT, CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \ > -- > 2.25.1
> -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: Wednesday, September 27, 2023 6:28 PM > To: Murthy, Arun R <arun.r.murthy@intel.com> > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com> > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove the module parameter > 'fastboot' > > On Tue, Sep 26, 2023 at 02:41:57PM +0530, Arun R Murthy wrote: > > By default fastboot is enabled on all Display 9+ platforms and > > disabled on older platforms. Its not necessary to retain this as a > > module parameter. > > > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 3 --- > > drivers/gpu/drm/i915/i915_params.c | 5 ----- > > drivers/gpu/drm/i915/i915_params.h | 1 - > > 3 files changed, 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > > b/drivers/gpu/drm/i915/display/intel_display.c > > index edbcf5968804..9d6e2d19d636 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -4986,9 +4986,6 @@ pipe_config_mismatch(bool fastset, const struct > > intel_crtc *crtc, > > > > static bool fastboot_enabled(struct drm_i915_private *dev_priv) { > > - if (dev_priv->params.fastboot != -1) > > - return dev_priv->params.fastboot; > > - > > /* Enable fastboot by default on Skylake and newer */ > > if (DISPLAY_VER(dev_priv) >= 9) > > return true; > > I'd like to see a patch to eliminate fastboot_enabled() and associated logic > entirely. Could be a separate patch I suppose. > Sure will take it up separately. Thanks and Regards, Arun R Murthy -------------------- > > diff --git a/drivers/gpu/drm/i915/i915_params.c > > b/drivers/gpu/drm/i915/i915_params.c > > index 0a171b57fd8f..036c4c3ed6ed 100644 > > --- a/drivers/gpu/drm/i915/i915_params.c > > +++ b/drivers/gpu/drm/i915/i915_params.c > > @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, > > "Enable IPS (default: true)"); i915_param_named_unsafe(enable_dpt, bool, > 0400, > > "Enable display page table (DPT) (default: true)"); > > > > -i915_param_named(fastboot, int, 0400, > > - "Try to skip unnecessary mode sets at boot time " > > - "(0=disabled, 1=enabled) " > > - "Default: -1 (use per-chip default)"); > > - > > i915_param_named_unsafe(load_detect_test, bool, 0400, > > "Force-enable the VGA load detect code for testing (default:false). " > > "For developers only."); > > diff --git a/drivers/gpu/drm/i915/i915_params.h > > b/drivers/gpu/drm/i915/i915_params.h > > index 68abf0ad6c00..d5194b039aab 100644 > > --- a/drivers/gpu/drm/i915/i915_params.h > > +++ b/drivers/gpu/drm/i915/i915_params.h > > @@ -72,7 +72,6 @@ struct drm_printer; > > param(int, edp_vswing, 0, 0400) \ > > param(unsigned int, reset, 3, 0600) \ > > param(unsigned int, inject_probe_failure, 0, 0) \ > > - param(int, fastboot, -1, 0600) \ > > param(int, enable_dpcd_backlight, -1, 0600) \ > > param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ > > param(unsigned int, request_timeout_ms, > > CONFIG_DRM_I915_REQUEST_TIMEOUT, > CONFIG_DRM_I915_REQUEST_TIMEOUT ? > > 0600 : 0) \ > > -- > > 2.25.1 > > -- > Ville Syrjälä > Intel
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Arun R > Murthy > Sent: Tuesday, September 26, 2023 2:42 PM > To: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com> > Subject: [Intel-gfx] [PATCH] drm/i915: Remove the module parameter 'fastboot' > > By default fastboot is enabled on all Display 9+ platforms and disabled on older > platforms. Its not necessary to retain this as a module parameter. Pushed to drm-intel-next. Thanks for the patch and reviews. @Arun R Murthy Please work on the follow-up patch as highlighted by Ville. Regards, Uma Shankar > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 --- > drivers/gpu/drm/i915/i915_params.c | 5 ----- > drivers/gpu/drm/i915/i915_params.h | 1 - > 3 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index edbcf5968804..9d6e2d19d636 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -4986,9 +4986,6 @@ pipe_config_mismatch(bool fastset, const struct > intel_crtc *crtc, > > static bool fastboot_enabled(struct drm_i915_private *dev_priv) { > - if (dev_priv->params.fastboot != -1) > - return dev_priv->params.fastboot; > - > /* Enable fastboot by default on Skylake and newer */ > if (DISPLAY_VER(dev_priv) >= 9) > return true; > diff --git a/drivers/gpu/drm/i915/i915_params.c > b/drivers/gpu/drm/i915/i915_params.c > index 0a171b57fd8f..036c4c3ed6ed 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, > "Enable IPS (default: true)"); i915_param_named_unsafe(enable_dpt, bool, 0400, > "Enable display page table (DPT) (default: true)"); > > -i915_param_named(fastboot, int, 0400, > - "Try to skip unnecessary mode sets at boot time " > - "(0=disabled, 1=enabled) " > - "Default: -1 (use per-chip default)"); > - > i915_param_named_unsafe(load_detect_test, bool, 0400, > "Force-enable the VGA load detect code for testing (default:false). " > "For developers only."); > diff --git a/drivers/gpu/drm/i915/i915_params.h > b/drivers/gpu/drm/i915/i915_params.h > index 68abf0ad6c00..d5194b039aab 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -72,7 +72,6 @@ struct drm_printer; > param(int, edp_vswing, 0, 0400) \ > param(unsigned int, reset, 3, 0600) \ > param(unsigned int, inject_probe_failure, 0, 0) \ > - param(int, fastboot, -1, 0600) \ > param(int, enable_dpcd_backlight, -1, 0600) \ > param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ > param(unsigned int, request_timeout_ms, > CONFIG_DRM_I915_REQUEST_TIMEOUT, > CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \ > -- > 2.25.1
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index edbcf5968804..9d6e2d19d636 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -4986,9 +4986,6 @@ pipe_config_mismatch(bool fastset, const struct intel_crtc *crtc, static bool fastboot_enabled(struct drm_i915_private *dev_priv) { - if (dev_priv->params.fastboot != -1) - return dev_priv->params.fastboot; - /* Enable fastboot by default on Skylake and newer */ if (DISPLAY_VER(dev_priv) >= 9) return true; diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0a171b57fd8f..036c4c3ed6ed 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)"); i915_param_named_unsafe(enable_dpt, bool, 0400, "Enable display page table (DPT) (default: true)"); -i915_param_named(fastboot, int, 0400, - "Try to skip unnecessary mode sets at boot time " - "(0=disabled, 1=enabled) " - "Default: -1 (use per-chip default)"); - i915_param_named_unsafe(load_detect_test, bool, 0400, "Force-enable the VGA load detect code for testing (default:false). " "For developers only."); diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 68abf0ad6c00..d5194b039aab 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_params.h @@ -72,7 +72,6 @@ struct drm_printer; param(int, edp_vswing, 0, 0400) \ param(unsigned int, reset, 3, 0600) \ param(unsigned int, inject_probe_failure, 0, 0) \ - param(int, fastboot, -1, 0600) \ param(int, enable_dpcd_backlight, -1, 0600) \ param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT, CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \
By default fastboot is enabled on all Display 9+ platforms and disabled on older platforms. Its not necessary to retain this as a module parameter. Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 3 --- drivers/gpu/drm/i915/i915_params.c | 5 ----- drivers/gpu/drm/i915/i915_params.h | 1 - 3 files changed, 9 deletions(-)