| Message ID | 20231115-eols-v1-1-d47a2f52b807@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gt: add missing new-line to GT_TRACE | expand |
On Wednesday, 15 November 2023 13:10:33 CET Andrzej Hajda wrote: > Trace requires new-line at the end of message (in opposition to printk), > otherwise trace dump becomes messy. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Acked-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c > index f5899d503e234b..471b7cdc10ba0f 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c > @@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force) > enum intel_engine_id id; > intel_wakeref_t wakeref; > > - GT_TRACE(gt, "force:%s", str_yes_no(force)); > + GT_TRACE(gt, "force:%s\n", str_yes_no(force)); > > /* Use a raw wakeref to avoid calling intel_display_power_get early */ > wakeref = intel_runtime_pm_get(gt->uncore->rpm); > > --- > base-commit: 1489bab52c281a869295414031a56506a375b036 > change-id: 20231115-eols-20f9f52cf338 > > Best regards, >
On 11/15/2023 1:10 PM, Andrzej Hajda wrote: > Trace requires new-line at the end of message (in opposition to printk), > otherwise trace dump becomes messy. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c > index f5899d503e234b..471b7cdc10ba0f 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c > @@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force) > enum intel_engine_id id; > intel_wakeref_t wakeref; > > - GT_TRACE(gt, "force:%s", str_yes_no(force)); > + GT_TRACE(gt, "force:%s\n", str_yes_no(force)); > > /* Use a raw wakeref to avoid calling intel_display_power_get early */ > wakeref = intel_runtime_pm_get(gt->uncore->rpm); > > --- > base-commit: 1489bab52c281a869295414031a56506a375b036 > change-id: 20231115-eols-20f9f52cf338 > > Best regards,
Hi Andrzej, On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote: > Trace requires new-line at the end of message (in opposition to printk), > otherwise trace dump becomes messy. > > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi
On 16.11.2023 12:45, Andi Shyti wrote: > Hi Andrzej, > > On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote: >> Trace requires new-line at the end of message (in opposition to printk), >> otherwise trace dump becomes messy. >> >> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thx all, pushed. Regards Andrzej > Thanks, > Andi
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c index f5899d503e234b..471b7cdc10ba0f 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c @@ -167,7 +167,7 @@ static void gt_sanitize(struct intel_gt *gt, bool force) enum intel_engine_id id; intel_wakeref_t wakeref; - GT_TRACE(gt, "force:%s", str_yes_no(force)); + GT_TRACE(gt, "force:%s\n", str_yes_no(force)); /* Use a raw wakeref to avoid calling intel_display_power_get early */ wakeref = intel_runtime_pm_get(gt->uncore->rpm);
Trace requires new-line at the end of message (in opposition to printk), otherwise trace dump becomes messy. Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 1489bab52c281a869295414031a56506a375b036 change-id: 20231115-eols-20f9f52cf338 Best regards,