| Message ID | 20231116212511.1760446-1-radhakrishna.sripada@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/mtl: Update Wa_22018931422 | expand |
On Thu, Nov 16, 2023 at 01:25:11PM -0800, Radhakrishna Sripada wrote: > Commit 78cc55e0b64c ("drm/i915/mcr: Hold GT forcewake during steering operations") > introduced the workaround which was in early stages. With a valid > lineage number update Workaround for future tracking. > > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> In case anyone is checking, the entries in the workaround database still aren't 100% updated yet, but we've been working directly with the hardware engineers on this one, so we know this is the correct lineage number and that it is indeed needed on the MTL and ARL platforms that this code will execute on. Matt > --- > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > index 34913912d8ae..e253750a51c5 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > @@ -388,8 +388,7 @@ void intel_gt_mcr_lock(struct intel_gt *gt, unsigned long *flags) > * registers. This wakeref will be released in the unlock > * routine. > * > - * This is expected to become a formally documented/numbered > - * workaround soon. > + * Wa_22018931422 > */ > intel_uncore_forcewake_get(gt->uncore, FORCEWAKE_GT); > > -- > 2.34.1 >
On Thu, Nov 16, 2023 at 01:46:25PM -0800, Matt Roper wrote: > On Thu, Nov 16, 2023 at 01:25:11PM -0800, Radhakrishna Sripada wrote: > > Commit 78cc55e0b64c ("drm/i915/mcr: Hold GT forcewake during steering operations") > > introduced the workaround which was in early stages. With a valid > > lineage number update Workaround for future tracking. > > > > Cc: Matt Roper <matthew.d.roper@intel.com> > > Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > > In case anyone is checking, the entries in the workaround database still > aren't 100% updated yet, but we've been working directly with the > hardware engineers on this one, so we know this is the correct lineage > number and that it is indeed needed on the MTL and ARL platforms that > this code will execute on. Line-wrapped the commit message to appease checkpatch and applied to drm-intel-gt-next. Thanks for the patch. Matt > > > Matt > > > --- > > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > index 34913912d8ae..e253750a51c5 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > @@ -388,8 +388,7 @@ void intel_gt_mcr_lock(struct intel_gt *gt, unsigned long *flags) > > * registers. This wakeref will be released in the unlock > > * routine. > > * > > - * This is expected to become a formally documented/numbered > > - * workaround soon. > > + * Wa_22018931422 > > */ > > intel_uncore_forcewake_get(gt->uncore, FORCEWAKE_GT); > > > > -- > > 2.34.1 > > > > -- > Matt Roper > Graphics Software Engineer > Linux GPU Platform Enablement > Intel Corporation
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c index 34913912d8ae..e253750a51c5 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c @@ -388,8 +388,7 @@ void intel_gt_mcr_lock(struct intel_gt *gt, unsigned long *flags) * registers. This wakeref will be released in the unlock * routine. * - * This is expected to become a formally documented/numbered - * workaround soon. + * Wa_22018931422 */ intel_uncore_forcewake_get(gt->uncore, FORCEWAKE_GT);
Commit 78cc55e0b64c ("drm/i915/mcr: Hold GT forcewake during steering operations") introduced the workaround which was in early stages. With a valid lineage number update Workaround for future tracking. Cc: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)