diff mbox series

drm/i915/display: do not use cursor size reduction on MTL

Message ID 20231124-cur_size_reduction-v1-1-30495dba475f@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/display: do not use cursor size reduction on MTL | expand

Commit Message

Andrzej Hajda Nov. 24, 2023, 7:53 a.m. UTC 
Cursor size reduction is not supported since MTL.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 94f973d8238e0d8fd1b0234f220783a1e346f60b
change-id: 20231124-cur_size_reduction-813979149f83

Best regards,

Comments

Andi Shyti Nov. 30, 2023, 3:18 p.m. UTC | #1 
Hi Andrzej,

On Fri, Nov 24, 2023 at 08:53:04AM +0100, Andrzej Hajda wrote:
> Cursor size reduction is not supported since MTL.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi
Andrzej Hajda Dec. 11, 2023, 1:42 p.m. UTC | #2 
On 24.11.2023 08:53, Andrzej Hajda wrote:
> Cursor size reduction is not supported since MTL.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Gently ping.

CC: maintainers

Regards
Andrzej

> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 4299cc452e0504..6610d73f55e6c4 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -36,7 +36,7 @@ struct drm_printer;
>   #define HAS_ASYNC_FLIPS(i915)		(DISPLAY_VER(i915) >= 5)
>   #define HAS_CDCLK_CRAWL(i915)		(DISPLAY_INFO(i915)->has_cdclk_crawl)
>   #define HAS_CDCLK_SQUASH(i915)		(DISPLAY_INFO(i915)->has_cdclk_squash)
> -#define HAS_CUR_FBC(i915)		(!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7)
> +#define HAS_CUR_FBC(i915)		(!HAS_GMCH(i915) && IS_DISPLAY_VER(i915, 7, 13))
>   #define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915))
>   #define HAS_DDI(i915)			(DISPLAY_INFO(i915)->has_ddi)
>   #define HAS_DISPLAY(i915)		(DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0)
> 
> ---
> base-commit: 94f973d8238e0d8fd1b0234f220783a1e346f60b
> change-id: 20231124-cur_size_reduction-813979149f83
> 
> Best regards,
Rodrigo Vivi Dec. 11, 2023, 8:12 p.m. UTC | #3 
On Mon, Dec 11, 2023 at 02:42:30PM +0100, Andrzej Hajda wrote:
> On 24.11.2023 08:53, Andrzej Hajda wrote:
> > Cursor size reduction is not supported since MTL.
> > 
> > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> > ---
> >   drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Gently ping.
> 
> CC: maintainers

pushed to drm-intel-next.
There was probably an hesitation due to CI complains, but from what
I could check there's nothing to worry.

Thanks,
Rodrigo.

> 
> Regards
> Andrzej
> 
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> > index 4299cc452e0504..6610d73f55e6c4 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> > @@ -36,7 +36,7 @@ struct drm_printer;
> >   #define HAS_ASYNC_FLIPS(i915)		(DISPLAY_VER(i915) >= 5)
> >   #define HAS_CDCLK_CRAWL(i915)		(DISPLAY_INFO(i915)->has_cdclk_crawl)
> >   #define HAS_CDCLK_SQUASH(i915)		(DISPLAY_INFO(i915)->has_cdclk_squash)
> > -#define HAS_CUR_FBC(i915)		(!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7)
> > +#define HAS_CUR_FBC(i915)		(!HAS_GMCH(i915) && IS_DISPLAY_VER(i915, 7, 13))
> >   #define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915))
> >   #define HAS_DDI(i915)			(DISPLAY_INFO(i915)->has_ddi)
> >   #define HAS_DISPLAY(i915)		(DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0)
> > 
> > ---
> > base-commit: 94f973d8238e0d8fd1b0234f220783a1e346f60b
> > change-id: 20231124-cur_size_reduction-813979149f83
> > 
> > Best regards,
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
index 4299cc452e0504..6610d73f55e6c4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.h
+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
@@ -36,7 +36,7 @@  struct drm_printer;
 #define HAS_ASYNC_FLIPS(i915)		(DISPLAY_VER(i915) >= 5)
 #define HAS_CDCLK_CRAWL(i915)		(DISPLAY_INFO(i915)->has_cdclk_crawl)
 #define HAS_CDCLK_SQUASH(i915)		(DISPLAY_INFO(i915)->has_cdclk_squash)
-#define HAS_CUR_FBC(i915)		(!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7)
+#define HAS_CUR_FBC(i915)		(!HAS_GMCH(i915) && IS_DISPLAY_VER(i915, 7, 13))
 #define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915))
 #define HAS_DDI(i915)			(DISPLAY_INFO(i915)->has_ddi)
 #define HAS_DISPLAY(i915)		(DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0)