| Message ID | 20231126214142.102106-1-sergeantsagara@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/i915/irq: Improve error logging for unexpected DE Misc interrupts | expand |
On Sun, 26 Nov 2023, Rahul Rameshbabu <sergeantsagara@protonmail.com> wrote: > Dump the iir value in hex when the interrupt is unexpected. > > Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9652#note_2178501 > Cc: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com> > Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> Pushed to drm-intel-next. Thanks for the patch and review. BR, Jani. > --- > > Notes: > Changes: > > v1->v2: > - Change format specifier to pad minimum width > - https://lore.kernel.org/intel-gfx/20231123175638.27650-1-sergeantsagara@protonmail.com/ > > drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c > index bff4a76310c0..7c6f20cd951e 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_irq.c > +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c > @@ -896,7 +896,7 @@ gen8_de_misc_irq_handler(struct drm_i915_private *dev_priv, u32 iir) > } > > if (!found) > - drm_err(&dev_priv->drm, "Unexpected DE Misc interrupt\n"); > + drm_err(&dev_priv->drm, "Unexpected DE Misc interrupt: 0x%08x\n", iir); > } > > static void gen11_dsi_te_interrupt_handler(struct drm_i915_private *dev_priv,
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c index bff4a76310c0..7c6f20cd951e 100644 --- a/drivers/gpu/drm/i915/display/intel_display_irq.c +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c @@ -896,7 +896,7 @@ gen8_de_misc_irq_handler(struct drm_i915_private *dev_priv, u32 iir) } if (!found) - drm_err(&dev_priv->drm, "Unexpected DE Misc interrupt\n"); + drm_err(&dev_priv->drm, "Unexpected DE Misc interrupt: 0x%08x\n", iir); } static void gen11_dsi_te_interrupt_handler(struct drm_i915_private *dev_priv,