From patchwork Fri Dec 1 15:44:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nirmoy Das X-Patchwork-Id: 13476021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00994C4167B for ; Fri, 1 Dec 2023 15:57:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 384C189D8E; Fri, 1 Dec 2023 15:57:43 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 454FD10E0C6; Fri, 1 Dec 2023 15:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701446259; x=1732982259; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=s5skdTv7Xeg2ackpodlWcVbqhKqy3/vsHCfL29KIB28=; b=hlihhprZ4TODyFeUtIFrwDx/PezxQ2OivCwn8J3o+vMBd4Nr51lZkxD9 ShEhS521iPudY3iXt00RilK7hdIIGkh5vLsYwnvVWp6mFH+u/fplkpsoX 55SORqddZ10D2b72E4vBdtQw0OwtTMY46XLH5R77ELavPutPomN0T4fhE TECNhICDQwDmK6Vw3qrMjTsBh6LvNvE/nPp0ueL3JCYCI0AXdAGxmqN4f lG0WmOSPcCowy6kacH2M6qaEjkbSvugp5i6neYUZRMMKQm+BoJRDxY4tk 0G76AbalS0u3sqDyYrntJOcQVwjG41E4YUhkmCoyp5TRqIhCuTLiy1wUx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="397403238" X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="397403238" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 07:57:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,241,1695711600"; d="scan'208";a="11193704" Received: from nirmoyda-desk.igk.intel.com ([10.102.138.190]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2023 07:57:37 -0800 From: Nirmoy Das To: intel-gfx@lists.freedesktop.org Date: Fri, 1 Dec 2023 16:44:43 +0100 Message-ID: <20231201154443.16660-1-nirmoy.das@intel.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Organization: Intel Deutschland GmbH, Registered Address: Am Campeon 10, 85579 Neubiberg, Germany, Commercial Register: Amtsgericht Muenchen HRB 186928 Subject: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let the caller of gen8_engine_reset_prepare() decide if a failure in gen8_engine_reset_prepare is an error or not. Cc: Tvrtko Ursulin Cc: John Harrison Cc: Andi Shyti Cc: Andrzej Hajda Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5591 Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_reset.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index d5ed904f355d..e6fbc6202c80 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -593,10 +593,10 @@ static int gen8_engine_reset_prepare(struct intel_engine_cs *engine) ret = __intel_wait_for_register_fw(uncore, reg, mask, ack, 700, 0, NULL); if (ret) - gt_err(engine->gt, - "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", - engine->name, request, - intel_uncore_read_fw(uncore, reg)); + GT_TRACE(engine->gt, + "%s reset request timed out: {request: %08x, RESET_CTL: %08x}\n", + engine->name, request, + intel_uncore_read_fw(uncore, reg)); return ret; }