diff mbox series

Revert "drm/i915/mtl: Update workaround 14018778641"

Message ID 20240117052042.1419544-1-tejas.upadhyay@intel.com (mailing list archive)
State New, archived
Headers show
Series Revert "drm/i915/mtl: Update workaround 14018778641" | expand

Commit Message

Upadhyay, Tejas Jan. 17, 2024, 5:20 a.m. UTC
Applying WA 14018778641 only on Compute engine has impact on Chrome
related apps. Reverting this patch and applying WA to all engines is
helping with performance on Chrome related apps.

Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Andi Shyti Feb. 8, 2024, 8:27 p.m. UTC | #1
Hi Tejas,

On Wed, Jan 17, 2024 at 10:50:42AM +0530, Tejas Upadhyay wrote:
> Applying WA 14018778641 only on Compute engine has impact on Chrome
> related apps. Reverting this patch and applying WA to all engines is
> helping with performance on Chrome related apps.
> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 270b56fc85e2..ab76025bf617 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1647,6 +1647,7 @@  static void
 xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
 {
 	/* Wa_14018778641 / Wa_18018781329 */
+	wa_mcr_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB);
 	wa_mcr_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB);
 
 	/* Wa_22016670082 */
@@ -1693,6 +1694,8 @@  xelpmp_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
 	 * GT, the media GT's versions are regular singleton registers.
 	 */
 	wa_write_or(wal, XELPMP_GSC_MOD_CTRL, FORCE_MISS_FTLB);
+	wa_write_or(wal, XELPMP_VDBX_MOD_CTRL, FORCE_MISS_FTLB);
+	wa_write_or(wal, XELPMP_VEBX_MOD_CTRL, FORCE_MISS_FTLB);
 
 	/* Wa_22016670082 */
 	wa_write_or(wal, GEN12_SQCNT1, GEN12_STRICT_RAR_ENABLE);