| Message ID | 20240117170503.3884942-1-bhanuprakash.modem@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [i-g-t,1/1] drm/i915/display: Dump display parameters to i915_display_capabilities | expand |
On Wed, 17 Jan 2024, Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote: > Include Display parameters in i915_display_capabilities debugfs. Maybe remove them from i915_capabilities? What's the point in having them in two places? (Or three, if you count the actual debugfs interface to the params!) > > Cc: Jouni Högander <jouni.hogander@intel.com> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_debugfs.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > index 6f2d13c8ccf7..1eb296b5c38a 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c > @@ -625,6 +625,10 @@ static int i915_display_capabilities(struct seq_file *m, void *unused) > struct drm_i915_private *i915 = node_to_i915(m->private); > struct drm_printer p = drm_seq_file_printer(m); > > + kernel_param_lock(THIS_MODULE); > + intel_display_params_dump(i915, &p); > + kernel_param_unlock(THIS_MODULE); The kernel_param_lock/unlock are just cargo cult from the time these were actually module parameters. They should be removed from i915_capabilities as well. BR, Jani. > + > intel_display_device_info_print(DISPLAY_INFO(i915), > DISPLAY_RUNTIME_INFO(i915), &p);
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index 6f2d13c8ccf7..1eb296b5c38a 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -625,6 +625,10 @@ static int i915_display_capabilities(struct seq_file *m, void *unused) struct drm_i915_private *i915 = node_to_i915(m->private); struct drm_printer p = drm_seq_file_printer(m); + kernel_param_lock(THIS_MODULE); + intel_display_params_dump(i915, &p); + kernel_param_unlock(THIS_MODULE); + intel_display_device_info_print(DISPLAY_INFO(i915), DISPLAY_RUNTIME_INFO(i915), &p);
Include Display parameters in i915_display_capabilities debugfs. Cc: Jouni Högander <jouni.hogander@intel.com> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com> --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 4 ++++ 1 file changed, 4 insertions(+)