diff mbox series

drm/i915/lnl: Modeset sequence change for DP on LNL

Message ID 20240229025752.651864-1-shekhar.chauhan@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/lnl: Modeset sequence change for DP on LNL | expand

Commit Message

Chauhan, Shekhar Feb. 29, 2024, 2:57 a.m. UTC
Currently, the driver is only waiting for 1ms for
idle patterns. But starting from LNL and beyond,
the MST wants the driver to wait for 1640us before
timing out (which we round up to 2ms).

BSpec: 68849
Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jani Nikula Feb. 29, 2024, 2:49 p.m. UTC | #1
On Thu, 29 Feb 2024, Shekhar Chauhan <shekhar.chauhan@intel.com> wrote:
> Currently, the driver is only waiting for 1ms for
> idle patterns. But starting from LNL and beyond,
> the MST wants the driver to wait for 1640us before
> timing out (which we round up to 2ms).
>
> BSpec: 68849
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

Replied in the other thread:

https://lore.kernel.org/r/878r338nhs.fsf@intel.com


> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index bea441590204..05ba3642d486 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3680,7 +3680,7 @@ static void intel_ddi_set_idle_link_train(struct intel_dp *intel_dp,
>  
>  	if (intel_de_wait_for_set(dev_priv,
>  				  dp_tp_status_reg(encoder, crtc_state),
> -				  DP_TP_STATUS_IDLE_DONE, 1))
> +				  DP_TP_STATUS_IDLE_DONE, 2))
>  		drm_err(&dev_priv->drm,
>  			"Timed out waiting for DP idle patterns\n");
>  }
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index bea441590204..05ba3642d486 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3680,7 +3680,7 @@  static void intel_ddi_set_idle_link_train(struct intel_dp *intel_dp,
 
 	if (intel_de_wait_for_set(dev_priv,
 				  dp_tp_status_reg(encoder, crtc_state),
-				  DP_TP_STATUS_IDLE_DONE, 1))
+				  DP_TP_STATUS_IDLE_DONE, 2))
 		drm_err(&dev_priv->drm,
 			"Timed out waiting for DP idle patterns\n");
 }