| Message ID | 20240503063413.1008135-3-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Panel replay selective update support | expand |
> -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Friday, May 3, 2024 12:04 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh <animesh.manna@intel.com>; Hogander, Jouni > <jouni.hogander@intel.com> > Subject: [PATCH v9 02/12] drm/i915/display: Do not print "psr: enabled" for > on Panel Replay > > After setting has_psr for panel replay as well crtc state dump is improperly > printing "psr: enabled" for Panel Replay as well. Fix this by checking also > has_panel_replay. > > Fixes: 5afa6e496098 ("drm/i915/psr: Set intel_crtc_state->has_psr on panel > replay as well") > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> LGTM. Reviewed-by: Animesh Manna <animesh.manna@intel.com> > --- > drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > index 1da4c122c52e..bddcc9edeab4 100644 > --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > @@ -252,7 +252,8 @@ void intel_crtc_state_dump(const struct > intel_crtc_state *pipe_config, > str_enabled_disabled(pipe_config- > >sdp_split_enable)); > > drm_printf(&p, "psr: %s, selective update: %s, panel replay: > %s, selective fetch: %s\n", > - str_enabled_disabled(pipe_config->has_psr), > + str_enabled_disabled(pipe_config->has_psr && > + !pipe_config- > >has_panel_replay), > str_enabled_disabled(pipe_config- > >has_sel_update), > str_enabled_disabled(pipe_config- > >has_panel_replay), > str_enabled_disabled(pipe_config- > >enable_psr2_sel_fetch)); > -- > 2.34.1
diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c index 1da4c122c52e..bddcc9edeab4 100644 --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c @@ -252,7 +252,8 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, str_enabled_disabled(pipe_config->sdp_split_enable)); drm_printf(&p, "psr: %s, selective update: %s, panel replay: %s, selective fetch: %s\n", - str_enabled_disabled(pipe_config->has_psr), + str_enabled_disabled(pipe_config->has_psr && + !pipe_config->has_panel_replay), str_enabled_disabled(pipe_config->has_sel_update), str_enabled_disabled(pipe_config->has_panel_replay), str_enabled_disabled(pipe_config->enable_psr2_sel_fetch));
After setting has_psr for panel replay as well crtc state dump is improperly printing "psr: enabled" for Panel Replay as well. Fix this by checking also has_panel_replay. Fixes: 5afa6e496098 ("drm/i915/psr: Set intel_crtc_state->has_psr on panel replay as well") Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)