diff mbox series

[RFC,2/3] drm/xe/display: allow creation of case I915_FORMAT_MOD_4_TILED_XE2_CCS type framebuffer

Message ID 20240506185238.364539-3-juhapekka.heikkila@gmail.com (mailing list archive)
State New, archived
Headers show
Series Introducing I915_FORMAT_MOD_4_TILED_XE2_CCS Modifier for Xe2 | expand

Commit Message

Juha-Pekka Heikkila May 6, 2024, 6:52 p.m. UTC
Add I915_FORMAT_MOD_4_TILED_XE2_CCS to possible created tiling for new framebuffer
on Xe driver.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ville Syrjala May 7, 2024, 4:07 p.m. UTC | #1
On Mon, May 06, 2024 at 09:52:37PM +0300, Juha-Pekka Heikkila wrote:
> Add I915_FORMAT_MOD_4_TILED_XE2_CCS to possible created tiling for new framebuffer
> on Xe driver.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  drivers/gpu/drm/xe/display/xe_plane_initial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> index 9693c56d386b..59adcd15eb31 100644
> --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
> +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> @@ -145,6 +145,7 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
>  	case I915_FORMAT_MOD_X_TILED:
>  	case I915_FORMAT_MOD_Y_TILED:
>  	case I915_FORMAT_MOD_4_TILED:
> +	case I915_FORMAT_MOD_4_TILED_XE2_CCS:

Are we actually expecting GOP to enable compression?

>  		break;
>  	default:
>  		drm_dbg(&dev_priv->drm,
> -- 
> 2.43.2
Juha-Pekka Heikkila May 7, 2024, 4:41 p.m. UTC | #2
On 7.5.2024 19.07, Ville Syrjälä wrote:
> On Mon, May 06, 2024 at 09:52:37PM +0300, Juha-Pekka Heikkila wrote:
>> Add I915_FORMAT_MOD_4_TILED_XE2_CCS to possible created tiling for new framebuffer
>> on Xe driver.
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>>   drivers/gpu/drm/xe/display/xe_plane_initial.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
>> index 9693c56d386b..59adcd15eb31 100644
>> --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
>> +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
>> @@ -145,6 +145,7 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
>>   	case I915_FORMAT_MOD_X_TILED:
>>   	case I915_FORMAT_MOD_Y_TILED:
>>   	case I915_FORMAT_MOD_4_TILED:
>> +	case I915_FORMAT_MOD_4_TILED_XE2_CCS:
> 
> Are we actually expecting GOP to enable compression?

This came in the wrong place, it's not needed here.

> 
>>   		break;
>>   	default:
>>   		drm_dbg(&dev_priv->drm,
>> -- 
>> 2.43.2
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 9693c56d386b..59adcd15eb31 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -145,6 +145,7 @@  intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
 	case I915_FORMAT_MOD_X_TILED:
 	case I915_FORMAT_MOD_Y_TILED:
 	case I915_FORMAT_MOD_4_TILED:
+	case I915_FORMAT_MOD_4_TILED_XE2_CCS:
 		break;
 	default:
 		drm_dbg(&dev_priv->drm,