diff mbox series

[4/4] drm/i915/dsb: Use intel_color_uses_dsb()

Message ID 20240531114101.19994-5-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/dsb: A bit of polish | expand

Commit Message

Ville Syrjala May 31, 2024, 11:41 a.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Use intel_color_uses_dsb() instead of open coding it in
intel_vblank_evade_init(). Make the logic around DSB a bit
more isolated from the rest of the code.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vblank.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Manna, Animesh June 6, 2024, 6:56 p.m. UTC | #1 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Friday, May 31, 2024 5:11 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [PATCH 4/4] drm/i915/dsb: Use intel_color_uses_dsb()
> 
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Use intel_color_uses_dsb() instead of open coding it in
> intel_vblank_evade_init(). Make the logic around DSB a bit more isolated
> from the rest of the code.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Animesh Manna <animesh.manna@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vblank.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c
> b/drivers/gpu/drm/i915/display/intel_vblank.c
> index eb80952b0cfd..789b2db4d95e 100644
> --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> @@ -5,6 +5,7 @@
> 
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> +#include "intel_color.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> @@ -637,7 +638,8 @@ void intel_vblank_evade_init(const struct
> intel_crtc_state *old_crtc_state,
>  	 * DSB execution waits for the transcoder's undelayed vblank,
>  	 * hence we must kick off the commit before that.
>  	 */
> -	if (new_crtc_state->dsb || new_crtc_state->update_m_n ||
> new_crtc_state->update_lrr)
> +	if (intel_color_uses_dsb(new_crtc_state) ||
> +	    new_crtc_state->update_m_n || new_crtc_state->update_lrr)
>  		evade->min -= adjusted_mode->crtc_vblank_start -
> adjusted_mode->crtc_vdisplay;  }
> 
> --
> 2.44.1
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index eb80952b0cfd..789b2db4d95e 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -5,6 +5,7 @@ 
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "intel_color.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
@@ -637,7 +638,8 @@  void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
 	 * DSB execution waits for the transcoder's undelayed vblank,
 	 * hence we must kick off the commit before that.
 	 */
-	if (new_crtc_state->dsb || new_crtc_state->update_m_n || new_crtc_state->update_lrr)
+	if (intel_color_uses_dsb(new_crtc_state) ||
+	    new_crtc_state->update_m_n || new_crtc_state->update_lrr)
 		evade->min -= adjusted_mode->crtc_vblank_start - adjusted_mode->crtc_vdisplay;
 }