| Message ID | 20240605102553.187309-8-jouni.hogander@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Panel Replay eDP support | expand |
> -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Wednesday, June 5, 2024 3:56 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh <animesh.manna@intel.com>; Kahola, Mika > <mika.kahola@intel.com>; Hogander, Jouni <jouni.hogander@intel.com> > Subject: [PATCH v6 07/26] drm/i915/alpm: Make alpm support checks non- > static > > We want to use intel_alpm_aux_wake_supported and > intel_alpm_aux_less_wake_supported in intel_psr.c. Convert them as non- > static. > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > --- > drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- > drivers/gpu/drm/i915/display/intel_alpm.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > b/drivers/gpu/drm/i915/display/intel_alpm.c > index 18c1c5803670..90072f6e3a33 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > @@ -11,12 +11,12 @@ > #include "intel_dp_aux.h" > #include "intel_psr_regs.h" > > -static bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp) > +bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp) > { > return intel_dp->alpm_dpcd & DP_ALPM_CAP; } > > -static bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp) > +bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp) > { > return intel_dp->alpm_dpcd & DP_ALPM_AUX_LESS_CAP; } diff --git > a/drivers/gpu/drm/i915/display/intel_alpm.h > b/drivers/gpu/drm/i915/display/intel_alpm.h > index c82ecc7b4001..d4fb60393c91 100644 > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > @@ -22,4 +22,6 @@ void intel_alpm_lobf_compute_config(struct intel_dp > *intel_dp, void intel_alpm_configure(struct intel_dp *intel_dp, > const struct intel_crtc_state *crtc_state); void > intel_alpm_lobf_debugfs_add(struct intel_connector *connector); > +bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); bool > +intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); The usage is implemented in patch 8, patch 7 and 8 can be squashed together. Regards, Animesh > #endif > -- > 2.34.1
On Thu, 2024-06-06 at 14:44 +0000, Manna, Animesh wrote: > > > > -----Original Message----- > > From: Hogander, Jouni <jouni.hogander@intel.com> > > Sent: Wednesday, June 5, 2024 3:56 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh <animesh.manna@intel.com>; Kahola, Mika > > <mika.kahola@intel.com>; Hogander, Jouni <jouni.hogander@intel.com> > > Subject: [PATCH v6 07/26] drm/i915/alpm: Make alpm support checks > > non- > > static > > > > We want to use intel_alpm_aux_wake_supported and > > intel_alpm_aux_less_wake_supported in intel_psr.c. Convert them as > > non- > > static. > > > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- > > drivers/gpu/drm/i915/display/intel_alpm.h | 2 ++ > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c > > b/drivers/gpu/drm/i915/display/intel_alpm.c > > index 18c1c5803670..90072f6e3a33 100644 > > --- a/drivers/gpu/drm/i915/display/intel_alpm.c > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.c > > @@ -11,12 +11,12 @@ > > #include "intel_dp_aux.h" > > #include "intel_psr_regs.h" > > > > -static bool intel_alpm_aux_wake_supported(struct intel_dp > > *intel_dp) > > +bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp) > > { > > return intel_dp->alpm_dpcd & DP_ALPM_CAP; } > > > > -static bool intel_alpm_aux_less_wake_supported(struct intel_dp > > *intel_dp) > > +bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp) > > { > > return intel_dp->alpm_dpcd & DP_ALPM_AUX_LESS_CAP; } diff > > --git > > a/drivers/gpu/drm/i915/display/intel_alpm.h > > b/drivers/gpu/drm/i915/display/intel_alpm.h > > index c82ecc7b4001..d4fb60393c91 100644 > > --- a/drivers/gpu/drm/i915/display/intel_alpm.h > > +++ b/drivers/gpu/drm/i915/display/intel_alpm.h > > @@ -22,4 +22,6 @@ void intel_alpm_lobf_compute_config(struct > > intel_dp > > *intel_dp, void intel_alpm_configure(struct intel_dp *intel_dp, > > const struct intel_crtc_state > > *crtc_state); void > > intel_alpm_lobf_debugfs_add(struct intel_connector *connector); > > +bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); > > bool > > +intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); > > The usage is implemented in patch 8, patch 7 and 8 can be squashed > together. I'm fine squashing these. Just thought splitting made sense as they are touching different source files. BR, Jouni Högander > > Regards, > Animesh > > > #endif > > -- > > 2.34.1 >
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c index 18c1c5803670..90072f6e3a33 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.c +++ b/drivers/gpu/drm/i915/display/intel_alpm.c @@ -11,12 +11,12 @@ #include "intel_dp_aux.h" #include "intel_psr_regs.h" -static bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp) +bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp) { return intel_dp->alpm_dpcd & DP_ALPM_CAP; } -static bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp) +bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp) { return intel_dp->alpm_dpcd & DP_ALPM_AUX_LESS_CAP; } diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h index c82ecc7b4001..d4fb60393c91 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.h +++ b/drivers/gpu/drm/i915/display/intel_alpm.h @@ -22,4 +22,6 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp, void intel_alpm_configure(struct intel_dp *intel_dp, const struct intel_crtc_state *crtc_state); void intel_alpm_lobf_debugfs_add(struct intel_connector *connector); +bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp); +bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp); #endif
We want to use intel_alpm_aux_wake_supported and intel_alpm_aux_less_wake_supported in intel_psr.c. Convert them as non-static. Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++-- drivers/gpu/drm/i915/display/intel_alpm.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)