| Message ID | 20240611120151.147778-1-mitulkumar.ajitkumar.golani@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/display: Send vrr vsync params whne vrr is enabled | expand |
On Tue, 11 Jun 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote: > == Series Details == > > Series: drm/i915/display: Send vrr vsync params whne vrr is enabled > URL : https://patchwork.freedesktop.org/series/134714/ > State : warning > > == Summary == > > Error: dim checkpatch failed > 711332181393 drm/i915/display: Send vrr vsync params whne vrr is enabled > -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > #26: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:236: > + if (intel_dp_as_sdp_supported(intel_dp) && > + crtc_state->vrr.enable) { Please fix this. > > total: 0 errors, 0 warnings, 1 checks, 9 lines checked > >
Hi @Jani Nikula > -----Original Message----- > From: Jani Nikula <jani.nikula@linux.intel.com> > Sent: Friday, June 14, 2024 1:09 PM > To: Patchwork <patchwork@emeril.freedesktop.org>; Golani, Mitulkumar > Ajitkumar <mitulkumar.ajitkumar.golani@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Send vrr > vsync params whne vrr is enabled > > On Tue, 11 Jun 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote: > > == Series Details == > > > > Series: drm/i915/display: Send vrr vsync params whne vrr is enabled > > URL : https://patchwork.freedesktop.org/series/134714/ > > State : warning > > > > == Summary == > > > > Error: dim checkpatch failed > > 711332181393 drm/i915/display: Send vrr vsync params whne vrr is > enabled > > -:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open > parenthesis > > #26: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:236: > > + if (intel_dp_as_sdp_supported(intel_dp) && > > + crtc_state->vrr.enable) { > > Please fix this. I fixed into next revision and got merged. https://patchwork.freedesktop.org/patch/598089/?series=134714&rev=2 Thanks, Mitul > > > > > > total: 0 errors, 0 warnings, 1 checks, 9 lines checked > > > > > > -- > Jani Nikula, Intel
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c index 05f67dc9d98d..ec3a68577356 100644 --- a/drivers/gpu/drm/i915/display/intel_vrr.c +++ b/drivers/gpu/drm/i915/display/intel_vrr.c @@ -232,7 +232,8 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state, crtc_state->mode_flags |= I915_MODE_FLAG_VRR; } - if (intel_dp_as_sdp_supported(intel_dp)) { + if (intel_dp_as_sdp_supported(intel_dp) && + crtc_state->vrr.enable) { crtc_state->vrr.vsync_start = (crtc_state->hw.adjusted_mode.crtc_vtotal - crtc_state->hw.adjusted_mode.vsync_start);
Compute trans vrr vsync params only when either VRR or CMRR is enabled. Fixes: 5922f45329cd ("drm/i915/display: Compute vrr vsync params") Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Cc: Suraj Kandpal <suraj.kandpal@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> --- drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)