From patchwork Wed Jun 19 06:21:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Hogander, Jouni" X-Patchwork-Id: 13703432 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 761E6C2BB85 for ; Wed, 19 Jun 2024 06:22:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 153A910E89D; Wed, 19 Jun 2024 06:22:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BDl/9UpG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90D8E10E887 for ; Wed, 19 Jun 2024 06:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718778127; x=1750314127; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=psCLqssx13c57mwi7fK+66sD66lszRRl4nuuLtUQOdY=; b=BDl/9UpGbgKGRKJLRmCVPxVnzhUGd5mZjYGfCPRHqMbIiMA7rO3qoxhX CXLWhrm3pQAJobKqE97dHBhz43L+ZiQK+iVQ5TNSpBoUlAXMDTj3r/+KX WjPhES5wyeKveMA54eDpzTNfHyL27+ck3+ZlNTXhKHGtJuWMq+z+G5zP3 LbXDkjhwIsht1aG/INHbDu9ZLzTshAb1wVqzqVZL0v8Q0NFiveDocPSef UxjV0/r8aFWJbjrQaLgoYvxVyWMaj3UB+buiQTwlsgxZsnpQqMiWD3kJM UWCUwhfJ5wrQmyti461uPPVTmcgC90Qg+lt+yC4yZ8AAMvzhexZ+zsLIL w==; X-CSE-ConnectionGUID: 9lfi4yh2T2qEsJpf8HPjtw== X-CSE-MsgGUID: nvB/+zhXQqO4tsrizKF+bA== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="26377384" X-IronPort-AV: E=Sophos;i="6.08,249,1712646000"; d="scan'208";a="26377384" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 23:22:06 -0700 X-CSE-ConnectionGUID: J4GuX7zBRJmSqyeTumnhag== X-CSE-MsgGUID: QDNXWaHVT+6QJOvrlJK3mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,249,1712646000"; d="scan'208";a="41905974" Received: from unknown (HELO jhogande-mobl1..) ([10.245.245.109]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 23:22:05 -0700 From: =?utf-8?q?Jouni_H=C3=B6gander?= To: intel-gfx@lists.freedesktop.org Cc: animesh.manna@intel.com, mika.kahola@intel.com, =?utf-8?q?Jouni_H=C3=B6g?= =?utf-8?q?ander?= Subject: [PATCH v9 04/11] drm/i915/psr: Check panel Early Transport capability for eDP PR Date: Wed, 19 Jun 2024 09:21:24 +0300 Message-Id: <20240619062131.4021196-5-jouni.hogander@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240619062131.4021196-1-jouni.hogander@intel.com> References: <20240619062131.4021196-1-jouni.hogander@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Our HW doesn't support panel replay without Early Transport on eDP. Bspec: 68920 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index a9bd7e379470..601b39204ef8 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -571,11 +571,18 @@ static void _panel_replay_init_dpcd(struct intel_dp *intel_dp) { struct drm_i915_private *i915 = dp_to_i915(intel_dp); - if (intel_dp_is_edp(intel_dp) && - (!intel_alpm_aux_less_wake_supported(intel_dp))) { - drm_dbg_kms(&i915->drm, - "Panel doesn't support AUX-less ALPM, eDP Panel Replay not possible\n"); - return; + if (intel_dp_is_edp(intel_dp)) { + if (!intel_alpm_aux_less_wake_supported(intel_dp)) { + drm_dbg_kms(&i915->drm, + "Panel doesn't support AUX-less ALPM, eDP Panel Replay not possible\n"); + return; + } + + if (!(intel_dp->pr_dpcd & DP_PANEL_REPLAY_EARLY_TRANSPORT_SUPPORT)) { + drm_dbg_kms(&i915->drm, + "Panel doesn't support early transport, eDP Panel Replay not possible\n"); + return; + } } intel_dp->psr.sink_panel_replay_support = true;