| Message ID | 20240924204222.246862-26-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Reconcile i915's and xe's display power mgt sequences | expand |
On Tue, 2024-09-24 at 16:35 -0400, Rodrigo Vivi wrote: > Align placement of HDP poll calls with i915. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/xe/display/xe_display.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com> > > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c > index 4d1dd5294b89..c758874a9059 100644 > --- a/drivers/gpu/drm/xe/display/xe_display.c > +++ b/drivers/gpu/drm/xe/display/xe_display.c > @@ -437,8 +437,6 @@ void xe_display_pm_runtime_suspend(struct xe_device *xe) > > if (xe->d3cold.allowed) > xe_display_to_d3cold(xe); > - > - intel_hpd_poll_enable(xe); > } > > void xe_display_pm_runtime_suspend_late(struct xe_device *xe) > @@ -448,6 +446,8 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe) > > if (xe->d3cold.allowed) > intel_display_power_suspend_late(xe, false); > + > + intel_hpd_poll_enable(xe); > } > > void xe_display_pm_runtime_resume_early(struct xe_device *xe) > @@ -464,12 +464,11 @@ void xe_display_pm_runtime_resume(struct xe_device *xe) > if (!xe->info.probe_display) > return; > > - intel_hpd_poll_disable(xe); > - > if (xe->d3cold.allowed) > xe_display_from_d3cold(xe); > > intel_hpd_init(xe); > + intel_hpd_poll_disable(xe); > } > > static void display_device_remove(struct drm_device *dev, void *arg)
-----Original Message----- From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Rodrigo Vivi Sent: Tuesday, September 24, 2024 1:36 PM To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org Cc: Deak, Imre <imre.deak@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com> Subject: [PATCH 25/31] drm/xe/display: Move hpd_poll calls to later runtime stages > > Align placement of HDP poll calls with i915. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> LGTM. Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> -Jonathan Cavitt > --- > drivers/gpu/drm/xe/display/xe_display.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c > index 4d1dd5294b89..c758874a9059 100644 > --- a/drivers/gpu/drm/xe/display/xe_display.c > +++ b/drivers/gpu/drm/xe/display/xe_display.c > @@ -437,8 +437,6 @@ void xe_display_pm_runtime_suspend(struct xe_device *xe) > > if (xe->d3cold.allowed) > xe_display_to_d3cold(xe); > - > - intel_hpd_poll_enable(xe); > } > > void xe_display_pm_runtime_suspend_late(struct xe_device *xe) > @@ -448,6 +446,8 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe) > > if (xe->d3cold.allowed) > intel_display_power_suspend_late(xe, false); > + > + intel_hpd_poll_enable(xe); > } > > void xe_display_pm_runtime_resume_early(struct xe_device *xe) > @@ -464,12 +464,11 @@ void xe_display_pm_runtime_resume(struct xe_device *xe) > if (!xe->info.probe_display) > return; > > - intel_hpd_poll_disable(xe); > - > if (xe->d3cold.allowed) > xe_display_from_d3cold(xe); > > intel_hpd_init(xe); > + intel_hpd_poll_disable(xe); > } > > static void display_device_remove(struct drm_device *dev, void *arg) > -- > 2.46.0 > >
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c index 4d1dd5294b89..c758874a9059 100644 --- a/drivers/gpu/drm/xe/display/xe_display.c +++ b/drivers/gpu/drm/xe/display/xe_display.c @@ -437,8 +437,6 @@ void xe_display_pm_runtime_suspend(struct xe_device *xe) if (xe->d3cold.allowed) xe_display_to_d3cold(xe); - - intel_hpd_poll_enable(xe); } void xe_display_pm_runtime_suspend_late(struct xe_device *xe) @@ -448,6 +446,8 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe) if (xe->d3cold.allowed) intel_display_power_suspend_late(xe, false); + + intel_hpd_poll_enable(xe); } void xe_display_pm_runtime_resume_early(struct xe_device *xe) @@ -464,12 +464,11 @@ void xe_display_pm_runtime_resume(struct xe_device *xe) if (!xe->info.probe_display) return; - intel_hpd_poll_disable(xe); - if (xe->d3cold.allowed) xe_display_from_d3cold(xe); intel_hpd_init(xe); + intel_hpd_poll_disable(xe); } static void display_device_remove(struct drm_device *dev, void *arg)
Align placement of HDP poll calls with i915. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/xe/display/xe_display.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)