diff mbox series

drm/i915/display: Fuse bit for power management disable removed

Message ID 20241004203540.3884792-1-clinton.a.taylor@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/display: Fuse bit for power management disable removed | expand

Commit Message

Clint Taylor Oct. 4, 2024, 8:35 p.m. UTC
Starting with Display 20 the fuse bit to disable Display PM has been
removed.

BSPEC: 69464
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Matt Roper Oct. 8, 2024, 10:16 p.m. UTC | #1
On Fri, Oct 04, 2024 at 01:35:40PM -0700, Clint Taylor wrote:
> Starting with Display 20 the fuse bit to disable Display PM has been
> removed.
> 
> BSPEC: 69464
> Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index f33062322c66..19aadf635077 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -1653,8 +1653,10 @@ static void __intel_display_device_info_runtime_init(struct drm_i915_private *i9
>  		if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE)
>  			display_runtime->has_hdcp = 0;
>  
> -		if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
> -			display_runtime->fbc_mask = 0;
> +		if (DISPLAY_VER(i915) < 20) {

According to bspec 50075 this bit actually went away in ADL-P.  So we
shouldn't be checking it on ADL-P, MTL, or BMG either.


Matt

> +			if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
> +				display_runtime->fbc_mask = 0;
> +		}
>  
>  		if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
>  			display_runtime->has_dmc = 0;
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
index f33062322c66..19aadf635077 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.c
+++ b/drivers/gpu/drm/i915/display/intel_display_device.c
@@ -1653,8 +1653,10 @@  static void __intel_display_device_info_runtime_init(struct drm_i915_private *i9
 		if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE)
 			display_runtime->has_hdcp = 0;
 
-		if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
-			display_runtime->fbc_mask = 0;
+		if (DISPLAY_VER(i915) < 20) {
+			if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
+				display_runtime->fbc_mask = 0;
+		}
 
 		if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
 			display_runtime->has_dmc = 0;