| Message ID | 20241021105100.2861830-3-mitulkumar.ajitkumar.golani@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add AS_SDP to fastset | expand |
On 10/21/2024 4:20 PM, Mitul Golani wrote: > While running with fixed refresh rate and VRR timing generator set FAVT > mode (Fixed Vtotal) in DP Adaptive Sync SDP to intimate the panel > about Fixed refresh rate. This is not matching with change below. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7e04913bc2ff..b1f68fff524d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2785,7 +2785,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, > as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode); > as_sdp->target_rr_divider = true; > } else { > - as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL; > + as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL; This is done in patch : https://patchwork.freedesktop.org/patch/623895/?series=134383&rev=6 Perhaps we can include this as part of this series? Regards, Ankit > as_sdp->vtotal = adjusted_mode->vtotal; > as_sdp->target_rr = 0; > }
> -----Original Message----- > From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com> > Sent: 18 November 2024 13:30 > To: Golani, Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani@intel.com>; > intel-gfx@lists.freedesktop.org > Cc: ville.syrjala@linux.intel.com > Subject: Re: [PATCH v3 2/3] drm/i915/dp: Set FAVT mode in DP SDP with > fixed refresh rate > > > On 10/21/2024 4:20 PM, Mitul Golani wrote: > > While running with fixed refresh rate and VRR timing generator set > > FAVT mode (Fixed Vtotal) in DP Adaptive Sync SDP to intimate the panel > > about Fixed refresh rate. > > This is not matching with change below. > > > > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > > Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > b/drivers/gpu/drm/i915/display/intel_dp.c > > index 7e04913bc2ff..b1f68fff524d 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -2785,7 +2785,7 @@ static void intel_dp_compute_as_sdp(struct > intel_dp *intel_dp, > > as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode); > > as_sdp->target_rr_divider = true; > > } else { > > - as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL; > > + as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL; > > This is done in patch : > https://patchwork.freedesktop.org/patch/623895/?series=134383&rev=6 > > Perhaps we can include this as part of this series? > Thanks for checking. I will pick https://patchwork.freedesktop.org/patch/623895/?series=134383&rev=6. Thanks > Regards, > > Ankit > > > as_sdp->vtotal = adjusted_mode->vtotal; > > as_sdp->target_rr = 0; > > }
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 7e04913bc2ff..b1f68fff524d 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2785,7 +2785,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode); as_sdp->target_rr_divider = true; } else { - as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL; + as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL; as_sdp->vtotal = adjusted_mode->vtotal; as_sdp->target_rr = 0; }