| Message ID | 20241030195507.2753404-1-clinton.a.taylor@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] drm/i915/display: Fuse bit for power management disable removed | expand |
On Wed, 2024-10-30 at 12:55 -0700, Clint Taylor wrote: > Starting with display version 13 the fuse bit to disable Display PM > has > been removed. > > v2: Bit removed starting with display version 13 (MattR) > v3: DG2 still uses this fuse bit (MattR) > > BSPEC: 50075, 69464 > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com> Reviewed-by: Jouni Högander <jouni.hogander@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c > b/drivers/gpu/drm/i915/display/intel_display_device.c > index a2ae07f6d1b7..7465e1715cc8 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_device.c > +++ b/drivers/gpu/drm/i915/display/intel_display_device.c > @@ -1775,8 +1775,10 @@ static void > __intel_display_device_info_runtime_init(struct drm_i915_private *i9 > if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE) > display_runtime->has_hdcp = 0; > > - if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) > - display_runtime->fbc_mask = 0; > + if (IS_DG2(i915) || DISPLAY_VER(i915) < 13) { > + if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) > + display_runtime->fbc_mask = 0; > + } > > if (DISPLAY_VER(i915) >= 11 && (dfsm & > ICL_DFSM_DMC_DISABLE)) > display_runtime->has_dmc = 0;
On Wed, 2024-10-30 at 12:55 -0700, Clint Taylor wrote: > Starting with display version 13 the fuse bit to disable Display PM has > been removed. > > v2: Bit removed starting with display version 13 (MattR) > v3: DG2 still uses this fuse bit (MattR) > > BSPEC: 50075, 69464 > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c > b/drivers/gpu/drm/i915/display/intel_display_device.c > index a2ae07f6d1b7..7465e1715cc8 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_device.c > +++ b/drivers/gpu/drm/i915/display/intel_display_device.c > @@ -1775,8 +1775,10 @@ static void __intel_display_device_info_runtime_init(struct > drm_i915_private *i9 > if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE) > display_runtime->has_hdcp = 0; > > - if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) > - display_runtime->fbc_mask = 0; > + if (IS_DG2(i915) || DISPLAY_VER(i915) < 13) { > + if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) > + display_runtime->fbc_mask = 0; > + } > > if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE)) > display_runtime->has_dmc = 0;
On Thu, 2024-10-31 at 07:58 +0000, Govindapillai, Vinod wrote: > On Wed, 2024-10-30 at 12:55 -0700, Clint Taylor wrote: > > Starting with display version 13 the fuse bit to disable Display PM has > > been removed. > > > > v2: Bit removed starting with display version 13 (MattR) > > v3: DG2 still uses this fuse bit (MattR) > > > > BSPEC: 50075, 69464 > > Cc: Matt Roper <matthew.d.roper@intel.com> > > Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> > > Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_display_device.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com> > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c > > b/drivers/gpu/drm/i915/display/intel_display_device.c > > index a2ae07f6d1b7..7465e1715cc8 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display_device.c > > +++ b/drivers/gpu/drm/i915/display/intel_display_device.c > > @@ -1775,8 +1775,10 @@ static void __intel_display_device_info_runtime_init(struct > > drm_i915_private *i9 > > if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE) > > display_runtime->has_hdcp = 0; > > > > - if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) > > - display_runtime->fbc_mask = 0; > > + if (IS_DG2(i915) || DISPLAY_VER(i915) < 13) { Btw, just remembered that it is recommended to use "display" over "i915" from now onward. So you could use DISPLAY_VER(display) < 13 here. Previous RB-ed by stays and may be you could update it while merging. BR Vinod > > + if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) > > + display_runtime->fbc_mask = 0; > > + } > > > > if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE)) > > display_runtime->has_dmc = 0; >
diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c index a2ae07f6d1b7..7465e1715cc8 100644 --- a/drivers/gpu/drm/i915/display/intel_display_device.c +++ b/drivers/gpu/drm/i915/display/intel_display_device.c @@ -1775,8 +1775,10 @@ static void __intel_display_device_info_runtime_init(struct drm_i915_private *i9 if (dfsm & SKL_DFSM_DISPLAY_HDCP_DISABLE) display_runtime->has_hdcp = 0; - if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) - display_runtime->fbc_mask = 0; + if (IS_DG2(i915) || DISPLAY_VER(i915) < 13) { + if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) + display_runtime->fbc_mask = 0; + } if (DISPLAY_VER(i915) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE)) display_runtime->has_dmc = 0;