| Message ID | 20241128063427.1792509-1-suraj.kandpal@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/hdcp: Change log level for HDMI HDCP LIC check | expand |
On 11/28/2024 12:04 PM, Suraj Kandpal wrote: > We don't need to shout out loud if there is a Link Integrity > Failure. This does not mean HDCP has failed, it is expected and > taken into account in the HDCP Spec. The real failure happens when > we are not able to reauthenticate and get HDCP running again for > which we already have the right logging. > > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 23c270a8c4aa..fa679b5d5510 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -1607,7 +1607,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port, > if (intel_hdmi_hdcp_check_link_once(dig_port, connector)) > return true; > > - drm_err(display->drm, "Link check failed\n"); > + drm_dbg_kms(display->drm, "Link check failed\n"); I agree, we do re-authentication after this so this is not an error at this point. We already have below debug message in case check_link() fails for either hdmi/dp in intel_hdcp.c drm_dbg_kms(display->drm, "[CONNECTOR:%d:%s] HDCP link failed, retrying authentication\n", connector->base.base.id, connector->base.name); Perhaps just dropping this message altogether will be better. Regards, Ankit > return false; > } >
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 23c270a8c4aa..fa679b5d5510 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -1607,7 +1607,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port, if (intel_hdmi_hdcp_check_link_once(dig_port, connector)) return true; - drm_err(display->drm, "Link check failed\n"); + drm_dbg_kms(display->drm, "Link check failed\n"); return false; }
We don't need to shout out loud if there is a Link Integrity Failure. This does not mean HDCP has failed, it is expected and taken into account in the HDCP Spec. The real failure happens when we are not able to reauthenticate and get HDCP running again for which we already have the right logging. Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com> --- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)