diff mbox series

[14/14] drm/i915/dp_mst: Use link.{min/max}_bpp_x16

Message ID 20241217093244.3938132-15-ankit.k.nautiyal@intel.com (mailing list archive)
State New
Headers show
Series DP DSC min/max src bpc fixes | expand

Commit Message

Nautiyal, Ankit K Dec. 17, 2024, 9:32 a.m. UTC
The link.{min/max}_bpp_x16 is already set in crtc_state, use that while
computing link config for MST.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Kandpal, Suraj Dec. 18, 2024, 4:06 a.m. UTC | #1
> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
> Sent: Tuesday, December 17, 2024 3:03 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org; Kandpal, Suraj <suraj.kandpal@intel.com>;
> jani.nikula@linux.intel.com; Deak, Imre <imre.deak@intel.com>
> Subject: [PATCH 14/14] drm/i915/dp_mst: Use link.{min/max}_bpp_x16
> 
> The link.{min/max}_bpp_x16 is already set in crtc_state, use that while
> computing link config for MST.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 689fbd6bcf9b..a9d9d7694acb 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -428,15 +428,8 @@ static int
> mst_stream_dsc_compute_link_config(struct intel_dp *intel_dp,
> 
>  	crtc_state->pipe_bpp = max_bpp;
> 
> -	max_compressed_bpp =
> intel_dp_dsc_sink_max_compressed_bpp(connector,
> -								  crtc_state,
> -								  max_bpp /
> 3);
> -	max_compressed_bpp = min(max_compressed_bpp,
> -				 fxp_q4_to_int(limits->link.max_bpp_x16));
> -
> -	min_compressed_bpp =
> intel_dp_dsc_sink_min_compressed_bpp(crtc_state);
> -	min_compressed_bpp = max(min_compressed_bpp,
> -				 fxp_q4_to_int_roundup(limits-
> >link.min_bpp_x16));
> +	max_compressed_bpp = fxp_q4_to_int(limits->link.max_bpp_x16);
> +	min_compressed_bpp = fxp_q4_to_int_roundup(limits-
> >link.min_bpp_x16);
> 
>  	drm_dbg_kms(display->drm, "DSC Sink supported compressed min
> bpp %d compressed max bpp %d\n",
>  		    min_compressed_bpp, max_compressed_bpp);
> --
> 2.45.2
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 689fbd6bcf9b..a9d9d7694acb 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -428,15 +428,8 @@  static int mst_stream_dsc_compute_link_config(struct intel_dp *intel_dp,
 
 	crtc_state->pipe_bpp = max_bpp;
 
-	max_compressed_bpp = intel_dp_dsc_sink_max_compressed_bpp(connector,
-								  crtc_state,
-								  max_bpp / 3);
-	max_compressed_bpp = min(max_compressed_bpp,
-				 fxp_q4_to_int(limits->link.max_bpp_x16));
-
-	min_compressed_bpp = intel_dp_dsc_sink_min_compressed_bpp(crtc_state);
-	min_compressed_bpp = max(min_compressed_bpp,
-				 fxp_q4_to_int_roundup(limits->link.min_bpp_x16));
+	max_compressed_bpp = fxp_q4_to_int(limits->link.max_bpp_x16);
+	min_compressed_bpp = fxp_q4_to_int_roundup(limits->link.min_bpp_x16);
 
 	drm_dbg_kms(display->drm, "DSC Sink supported compressed min bpp %d compressed max bpp %d\n",
 		    min_compressed_bpp, max_compressed_bpp);