| Message ID | 96be1ba5dcaf1a758f6b75527374b881bd01dd4a.1731011435.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/i915/mst: cleanups, renames, clarifications | expand |
On Thu, Nov 07, 2024 at 10:32:17PM +0200, Jani Nikula wrote: > Use a primary_encoder local variable in > intel_dp_create_fake_mst_encoder() for clarity. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index 558cf13b977f..6d0b4a8f4849 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -1789,6 +1789,7 @@ static const struct drm_dp_mst_topology_cbs mst_cbs = { > static struct intel_dp_mst_encoder * > intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe pipe) > { > + struct intel_encoder *primary_encoder = &dig_port->base; > struct intel_dp_mst_encoder *intel_mst; > struct intel_encoder *encoder; > struct drm_device *dev = dig_port->base.base.dev; > @@ -1806,8 +1807,8 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe > DRM_MODE_ENCODER_DPMST, "DP-MST %c", pipe_name(pipe)); > > encoder->type = INTEL_OUTPUT_DP_MST; > - encoder->power_domain = dig_port->base.power_domain; > - encoder->port = dig_port->base.port; > + encoder->power_domain = primary_encoder->power_domain; > + encoder->port = primary_encoder->port; > encoder->cloneable = 0; > /* > * This is wrong, but broken userspace uses the intersection > -- > 2.39.5 >
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index 558cf13b977f..6d0b4a8f4849 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -1789,6 +1789,7 @@ static const struct drm_dp_mst_topology_cbs mst_cbs = { static struct intel_dp_mst_encoder * intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe pipe) { + struct intel_encoder *primary_encoder = &dig_port->base; struct intel_dp_mst_encoder *intel_mst; struct intel_encoder *encoder; struct drm_device *dev = dig_port->base.base.dev; @@ -1806,8 +1807,8 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *dig_port, enum pipe DRM_MODE_ENCODER_DPMST, "DP-MST %c", pipe_name(pipe)); encoder->type = INTEL_OUTPUT_DP_MST; - encoder->power_domain = dig_port->base.power_domain; - encoder->port = dig_port->base.port; + encoder->power_domain = primary_encoder->power_domain; + encoder->port = primary_encoder->port; encoder->cloneable = 0; /* * This is wrong, but broken userspace uses the intersection
Use a primary_encoder local variable in intel_dp_create_fake_mst_encoder() for clarity. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)