From patchwork Thu Sep 23 19:20:02 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Que X-Patchwork-Id: 202662 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8NJLvmA031651 for ; Thu, 23 Sep 2010 19:22:32 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 471299F4D4 for ; Thu, 23 Sep 2010 12:21:57 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from smtp-out.google.com (smtp-out.google.com [74.125.121.35]) by gabe.freedesktop.org (Postfix) with ESMTP id 340979F4C7 for ; Thu, 23 Sep 2010 12:20:06 -0700 (PDT) Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id o8NJK48K016017 for ; Thu, 23 Sep 2010 12:20:04 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1285269604; bh=10y02g0KImnNcRLoLBLrIdVkzAk=; h=MIME-Version:Sender:In-Reply-To:References:Date:Message-ID: Subject:From:To:Content-Type; b=b2rSLFjNOheaWVetjhn7xBOJlZrEBwG32Kptob5ZHGSWsMJKQApCiQpi78Nkylf5M NTt4YqyI2kcXyzZ57F1Lw== Received: from qyk31 (qyk31.prod.google.com [10.241.83.159]) by wpaz37.hot.corp.google.com with ESMTP id o8NJJKke010270 for ; Thu, 23 Sep 2010 12:20:02 -0700 Received: by qyk31 with SMTP id 31so470742qyk.6 for ; Thu, 23 Sep 2010 12:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=nPHKcLaq39KDXqQ5nMNHz2HuYp/IRaJ0kGxfFh6KaNU=; b=aP/ujIdHXxydiiR81TusDdbgY2hg97uNTIFBKhexz4b5i7XtmkfaBF9BqGimWwpdXm oNGR2zvD28HhYy5fYV9g== DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=f3OzMCNGkJ+149j4mCV2F9G1nRD8/xs8vV/dtB9L5K5gZXKE4ud9Enqc2wNlJzOTyq 3cH2sTjg2f846RaFrL1A== MIME-Version: 1.0 Received: by 10.224.65.138 with SMTP id j10mr1604874qai.147.1285269602402; Thu, 23 Sep 2010 12:20:02 -0700 (PDT) Received: by 10.229.78.97 with HTTP; Thu, 23 Sep 2010 12:20:02 -0700 (PDT) In-Reply-To: References: Date: Thu, 23 Sep 2010 12:20:02 -0700 X-Google-Sender-Auth: XbAwqxbmjofhQ-2L7ER-uJ_3cDs Message-ID: From: Simon Que To: intel-gfx@lists.freedesktop.org X-System-Of-Record: true Subject: [Intel-gfx] Fwd: [PATCH] CHROMIUM: i915: Added default LVDS options for the no-VBT case X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Thu, 23 Sep 2010 19:22:32 +0000 (UTC) From a9a26c9892baeb4d39557d8520be12b33245d201 Mon Sep 17 00:00:00 2001 From: Simon Que Date: Wed, 22 Sep 2010 14:24:10 -0700 Subject: [PATCH] CHROMIUM: i915: Added default LVDS options for the no-VBT case Added a function that sets the LVDS values to default settings (currently only dither bit) when there is no VBT (video BIOS table) found. Signed-off-by: Simon Que BUG=none TEST=Splash screen looks dithered upon boot. Change-Id: If19c763824ee938ad107f655d8d94c65e39cfa56 --- drivers/gpu/drm/Kconfig | 9 +++++++++ drivers/gpu/drm/i915/intel_bios.c | 10 ++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 70c9d4b..ad76f30 100644 --- a/drivers/gpu/drm/i915/intel_bios.c +++ b/drivers/gpu/drm/i915/intel_bios.c @@ -501,6 +501,15 @@ parse_device_mapping(struct drm_i915_private *dev_priv, } return; } + +static void +get_no_vbt_default_settings(struct drm_i915_private *dev_priv) +{ +#if CONFIG_DRM_I915_ENABLE_NO_VBT_DEFAULTS + dev_priv->lvds_dither = 1; +#endif +} + /** * intel_init_bios - initialize VBIOS settings & find VBT * @dev: DRM device @@ -541,6 +550,7 @@ intel_init_bios(struct drm_device *dev) if (!vbt) { DRM_ERROR("VBT signature missing\n"); pci_unmap_rom(pdev, bios); + get_no_vbt_default_settings(dev_priv); return -1; } diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 14e21c3..94979a5 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -136,6 +136,15 @@ config DRM_I915_DIRECT_BACKLIGHT Direct backlight control gives finer granularity (0-256) than ACPI and does not require BIOS support. +config DRM_I915_ENABLE_NO_VBT_DEFAULTS + bool "Set default BIOS settings when VBT is not found" + depends on DRM_I915 + help + Choose this option if you want the i915 driver to set the device + settings to a set of defaults in the event that VBT is not found. + This will happen on systems with firmware that does not initialize + video. + endchoice config DRM_MGA -- 1.7.1