From patchwork Mon Sep 27 21:06:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Que X-Patchwork-Id: 213452 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8RL6YwJ019952 for ; Mon, 27 Sep 2010 21:06:55 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A37DA08ED for ; Mon, 27 Sep 2010 14:06:29 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from smtp-out.google.com (smtp-out.google.com [74.125.121.35]) by gabe.freedesktop.org (Postfix) with ESMTP id 39FAC9E7A9 for ; Mon, 27 Sep 2010 14:06:20 -0700 (PDT) Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id o8RL6Il3006796 for ; Mon, 27 Sep 2010 14:06:19 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1285621579; bh=3Y3hEPBbqVaeDN85dcV3F/N2X7c=; h=MIME-Version:Sender:Date:Message-ID:Subject:From:To:Cc: Content-Type; b=gJxp+ewzAhE954o8NtNvCN4E+xYNsH/Yb6+5RAJYqNYAN0u9ZbSvG41byj98siea4 iRH0kyMF1LaRyEmzkVeWA== Received: from qyk34 (qyk34.prod.google.com [10.241.83.162]) by wpaz21.hot.corp.google.com with ESMTP id o8RL3UvY006767 for ; Mon, 27 Sep 2010 14:06:17 -0700 Received: by qyk34 with SMTP id 34so9118604qyk.15 for ; Mon, 27 Sep 2010 14:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:mime-version:received:sender:received:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=MlDeXTR6Y68GhbF1xsNnfZPQSAG5mfqHNwUmCEvYYYo=; b=vk+1rpYy3JkAlIj6p0wMY4HOpCen0tHbnDjOiKOEZuhneO0qemR0cc9XUJsSKo+z0+ CVkq0pEMFZARtMLatTLQ== DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; b=Lz0Bl6HOaTzINtUwTUVUHWPepMmXoVE3uADi583o4mnGv5GSFS4Sdbu8AGuqVI4ALy 6qDtGUUPagWksrn+l4Ng== MIME-Version: 1.0 Received: by 10.229.214.73 with SMTP id gz9mr6152526qcb.167.1285621577297; Mon, 27 Sep 2010 14:06:17 -0700 (PDT) Received: by 10.229.78.97 with HTTP; Mon, 27 Sep 2010 14:06:17 -0700 (PDT) Date: Mon, 27 Sep 2010 14:06:17 -0700 X-Google-Sender-Auth: QoS6CagKFuYcVBUxW6UUYvNSIyg Message-ID: From: Simon Que To: Chris Wilson , Jesse Barnes , Eric Anholt , intel-gfx@lists.freedesktop.org X-System-Of-Record: true Cc: Olof Johansson , Mandeep Baines , Bryan Freed Subject: [Intel-gfx] [PATCH v2] CHROMIUM: i915: Added default LVDS options for the no-VBT case X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Mon, 27 Sep 2010 21:06:55 +0000 (UTC) =============================================================== Subject: [PATCH] CHROMIUM: i915: Added default LVDS options for the no-VBT case Added a function that sets the LVDS values to default settings (currently only dither bit) when there is no VBT (video BIOS table) found. Also updated dither bit in parse function to be set by default. Signed-off-by: Simon Que BUG=none TEST=Splash screen looks dithered upon boot. Change-Id: If19c763824ee938ad107f655d8d94c65e39cfa56 --- drivers/gpu/drm/i915/intel_bios.c | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 70c9d4b..6cb872c 100644 --- a/drivers/gpu/drm/i915/intel_bios.c +++ b/drivers/gpu/drm/i915/intel_bios.c @@ -120,7 +120,7 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv, struct drm_display_mode *temp_mode; /* Defaults if we can't find VBT info */ - dev_priv->lvds_dither = 0; + dev_priv->lvds_dither = 1; dev_priv->lvds_vbt = 0; lvds_options = find_section(bdb, BDB_LVDS_OPTIONS); @@ -501,6 +501,13 @@ parse_device_mapping(struct drm_i915_private *dev_priv, } return; } + +static void +get_no_vbt_default_settings(struct drm_i915_private *dev_priv) +{ + dev_priv->lvds_dither = 1; +} + /** * intel_init_bios - initialize VBIOS settings & find VBT * @dev: DRM device @@ -541,6 +548,7 @@ intel_init_bios(struct drm_device *dev) if (!vbt) { DRM_ERROR("VBT signature missing\n"); pci_unmap_rom(pdev, bios); + get_no_vbt_default_settings(dev_priv); return -1; }