From patchwork Sat Sep 13 17:27:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 4899781 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 937289F32F for ; Sat, 13 Sep 2014 17:23:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 23F52201BB for ; Sat, 13 Sep 2014 17:27:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 347FD2010C for ; Sat, 13 Sep 2014 17:27:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A517E6E263; Sat, 13 Sep 2014 10:27:31 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 025CE6E263 for ; Sat, 13 Sep 2014 10:27:30 -0700 (PDT) Received: by mail-we0-f179.google.com with SMTP id u56so2135922wes.10 for ; Sat, 13 Sep 2014 10:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=jCD1Qb2WhJyuvfIB/2ipgl1k+f6Umtox/5MusqJWIC4=; b=JvGsRPon9HarK8sHdCPr5NKwibJ2WVb9acSeIZOzRonyIWYByJ7V9FRmg3osxkF6u8 cro8T4ZRS9amWJQNhGoaEp0E9rN7pWr+D3czoPV5W96gM3Rvq7NPK5XK4+EJzeU94R5o mrgN3ShGgtNWSwkeKCaLfeVp6Fnawcg1oHspjR9IQrlhYb+f6z30A33AGdtc9YlHggvX iSLG8EcDtM1cCY765kU5O2cQj0SaTDJLh6cFt28IDO+SDbxNfwPKsE9UvSsrVoEtSZjE cX0WelGmT4FPvzmynPwn0eHbfP3ADjcFIP7KPuKsAAE6w4bqn8WqeFjZkR0wCznC+Iib jzqA== MIME-Version: 1.0 X-Received: by 10.194.9.228 with SMTP id d4mr20156662wjb.99.1410629249880; Sat, 13 Sep 2014 10:27:29 -0700 (PDT) Received: by 10.216.58.10 with HTTP; Sat, 13 Sep 2014 10:27:29 -0700 (PDT) In-Reply-To: References: Date: Sat, 13 Sep 2014 19:27:29 +0200 Message-ID: From: Sedat Dilek To: intel-gfx , Chris Wilson Subject: Re: [Intel-gfx] intel_driver.c:1182:2: error: implicit declaration of function 'intel_sync_close' is invalid in C99 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: sedat.dilek@gmail.com List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Sep 13, 2014 at 7:15 PM, Sedat Dilek wrote: > Building intel-ddx from GIT HEAD breaks here with LLVM v3.4.2 like this... > ... > intel_driver.c:1182:2: error: implicit declaration of function > 'intel_sync_close' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > intel_sync_close(screen); > ^ > In file included from intel_uxa.c:44: > ./intel_glamor.h:92:1: warning: unused function > 'intel_glamor_fd_from_pixmap' [-Wunused-function] > intel_glamor_fd_from_pixmap(ScreenPtr screen, > ^ > intel_driver.c:1182:2: note: did you mean 'intel_mode_close'? > ./intel.h:356:13: note: 'intel_mode_close' declared here > extern void intel_mode_close(intel_screen_private *intel); > ^ > ... > > Please have a look at the full build-log. > Thanks. > > - Sedat - > > P:S:: GIT HEAD is here... > > commit 48f6406a62c06a09b173d82b8eb79761188ff717 ("Use intel_uxa.h in > all uxa-specific files") > > P.S.S.: FYI... v2.99.916 is OK. Looking at the sources... ./src/uxa/intel.h-516-#if HAVE_DRI3 ./src/uxa/intel.h-517-Bool intel_sync_init(ScreenPtr screen); ./src/uxa/intel.h:518:void intel_sync_close(ScreenPtr screen); ./src/uxa/intel.h-519-#endif ...and in my logs... $ grep DRI3 ../logs/build-and-install-log_XF86-Video-Intel-v2-99-916-38-g48f6406_llvm-3-4-2.txt checking for X11_DRI3... yes checking if DRI3 is defined... no checking whether to include DRI3 support... no Then intel_sync_close() should be embedded into a HAVE_DRI3 check? $ git diff Regards, - Sedat - diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c index f31f7bd..9f527fd 100644 --- a/src/uxa/intel_driver.c +++ b/src/uxa/intel_driver.c @@ -1179,7 +1179,9 @@ static Bool I830CloseScreen(CLOSE_SCREEN_ARGS_DECL) intel->dri3 = DRI_NONE; } +#if HAVE_DRI3 intel_sync_close(screen); +#endif xf86GARTCloseScreen(scrn->scrnIndex);