From patchwork Sat Aug 18 01:14:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Airlie X-Patchwork-Id: 1340351 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 5435E3FC33 for ; Sat, 18 Aug 2012 01:14:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CD1A9E8AF for ; Fri, 17 Aug 2012 18:14:51 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qa0-f49.google.com (mail-qa0-f49.google.com [209.85.216.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FBBB9E74E for ; Fri, 17 Aug 2012 18:14:23 -0700 (PDT) Received: by qafk1 with SMTP id k1so1900727qaf.15 for ; Fri, 17 Aug 2012 18:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Gb9RyNSyBfJoOiayHrY4BThZFevs5UcBiFW//CjMtpo=; b=MDDNS0kDBkJrkLUPlbJnxC4kQGs1Xs4SOhEhqMoOiWRv+kEOh7t9njJgfl2vpVKlze 9c88jHEFThh+jhRGn6+hG0OkfJN04ZwizHbOYGSMiYlCDAXf+Q1bcWd5yZcCGdi2c3OA Rpib1/JDk9++4HtGJ2kxB6IRyKQOGLWhaH57pVtM/MusRuW/3JQf85CZZA/9uZbJw2/L pt282T3i8VzHjXVNhQwNYfN4UxAFwQmNebpime6LFO7HTsiFx4sPq9mKJGKoQWZ6Uj6n LnPN8ozEYl0i7mVPyHl30hL0RQ+EJjdDFwL3ZgDE41bKHAVgLs5f9MRgcWW7W81A6cis E1xw== MIME-Version: 1.0 Received: by 10.229.111.70 with SMTP id r6mr5262353qcp.120.1345252462727; Fri, 17 Aug 2012 18:14:22 -0700 (PDT) Received: by 10.229.220.72 with HTTP; Fri, 17 Aug 2012 18:14:22 -0700 (PDT) In-Reply-To: References: Date: Sat, 18 Aug 2012 11:14:22 +1000 Message-ID: From: Dave Airlie To: intel-gfx@lists.freedesktop.org, Michael Chapman Subject: [Intel-gfx] Fwd: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Hi Michael, forwarding to a list that might be better place. Dave. ---------- Forwarded message ---------- From: Michael Chapman Date: Fri, Aug 17, 2012 at 10:30 PM Subject: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness To: airlied@gmail.com Hello Dave: A couple of weeks ago, Carsten Emde helped me fix a display issue on my Acer Aspire 5732Z that was similar to the problem on the 5734Z. (Please see the email fragment below.) I don't know if he submitted a patch, but I was wondering if this fix would be in place for Linux 3.6. I've attached a patch file that was made against git://people.freedesktop.org/~danvet/drm-intel. Thank you, Michael ---------- Forwarded message ---------- From: Carsten Emde Date: Wed, Jul 25, 2012 at 6:04 PM Subject: Re: quirk_invert_brightness and Acer Aspire 5732Z To: Michael Chapman On 07/25/2012 07:09 PM, Michael Chapman wrote: > > Subsystem: 1025:0212 This is the patch: Please let me know, whether a kernel with this patch still requires manual setpci hassle or whether the problem is now fixed. -Carsten. --- drm-intel/drivers/gpu/drm/i915/intel_display.c.orig 2012-08-17 07:56:15.000000000 -0400 +++ drm-intel/drivers/gpu/drm/i915/intel_display.c 2012-08-17 08:07:41.134723059 -0400 @@ -7041,6 +7041,9 @@ /* Acer Aspire 5734Z must invert backlight brightness */ { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness }, + + /* Acer Aspire 5732Z must invert backlight brightness */ + { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness }, }; static void intel_init_quirks(struct drm_device *dev) Index: linux-git/drivers/gpu/drm/i915/intel_display.c =================================================================== --- linux-git.orig/drivers/gpu/drm/i915/intel_display.c +++ linux-git/drivers/gpu/drm/i915/intel_display.c @@ -6877,7 +6877,8 @@ static struct intel_quirk intel_quirks[] /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, - /* Acer Aspire 5734Z must invert backlight brightness */ + /* Acer Aspire 5732Z and 5734Z must invert backlight brightness */ + { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness }, { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness }, };