✗ Fi.CI.IGT: failure for series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw

Commit Message

[e-mail] April 5, 2018, 10:02 a.m. UTC

On 4/5/2018 6:03 AM, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw
> URL   : https://patchwork.freedesktop.org/series/41159/
> State : failure
>
> == Summary ==
>
> ---- Possible new issues:
>
> Test gem_eio:
>          Subgroup execbuf:
>                  pass       -> INCOMPLETE (shard-apl)
I am seeing this failure w/o this patch series too.
Working fix  that I have tried is to unpark from reset path explicitly 
if GT is awake:


This way we will balance the irq refcounts.
>          Subgroup in-flight-external:
>                  pass       -> INCOMPLETE (shard-apl)
>          Subgroup throttle:
>                  pass       -> INCOMPLETE (shard-apl)
> Test perf:
>          Subgroup gen8-unprivileged-single-ctx-counters:
>                  pass       -> FAIL       (shard-apl)
>
> ---- Known issues:
>
> Test drv_missed_irq:
>                  pass       -> SKIP       (shard-apl) fdo#103199
> Test gem_eio:
>          Subgroup in-flight-suspend:
>                  pass       -> INCOMPLETE (shard-apl) fdo#103375
>          Subgroup suspend:
>                  pass       -> INCOMPLETE (shard-apl) fdo#103927 +1
> Test kms_flip:
>          Subgroup 2x-flip-vs-expired-vblank:
>                  fail       -> PASS       (shard-hsw) fdo#102887 +1
>          Subgroup plain-flip-ts-check-interruptible:
>                  fail       -> PASS       (shard-hsw) fdo#100368 +1
> Test kms_sysfs_edid_timing:
>                  warn       -> PASS       (shard-apl) fdo#100047
>
> fdo#103199 https://bugs.freedesktop.org/show_bug.cgi?id=103199
> fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
> fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
> fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
> fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
> fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
>
> shard-apl        total:2701 pass:1404 dwarn:1   dfail:0   fail:6   skip:1274 time:6843s
> shard-hsw        total:3499 pass:1786 dwarn:1   dfail:0   fail:1   skip:1710 time:11567s
> shard-snb        total:3499 pass:1378 dwarn:1   dfail:0   fail:2   skip:2118 time:7127s
> Blacklisted hosts:
> shard-kbl        total:2429 pass:1334 dwarn:4   dfail:0   fail:6   skip:1065 time:4018s
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8581/shards.html
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Comments

Chris Wilson April 5, 2018, 10:19 a.m. UTC | #1

Quoting Sagar Arun Kamble (2018-04-05 11:02:33)
> 
> 
> On 4/5/2018 6:03 AM, Patchwork wrote:
> > == Series Details ==
> >
> > Series: series starting with [v6,01/12] drm/i915: Correctly handle error path in i915_gem_init_hw
> > URL   : https://patchwork.freedesktop.org/series/41159/
> > State : failure
> >
> > == Summary ==
> >
> > ---- Possible new issues:
> >
> > Test gem_eio:
> >          Subgroup execbuf:
> >                  pass       -> INCOMPLETE (shard-apl)
> I am seeing this failure w/o this patch series too.
> Working fix  that I have tried is to unpark from reset path explicitly 
> if GT is awake:
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c 
> b/drivers/gpu/drm/i915/i915_drv.c
> index d354627..2fc9d0e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1960,6 +1960,9 @@ void i915_reset(struct drm_i915_private *i915)
>                  goto error;
>          }
> 
> +       if (i915->gt.awake)
> +               intel_engines_unpark(i915);
> +
>          i915_queue_hangcheck(i915);
> 
>   finish:
> 
> This way we will balance the irq refcounts.

Only for them to be unbalanced on resume... Just we don't currently warn
about that.

But that's the kind of plan I have, before we call
reset_default_submission in unwedge, to bludgeon through the full idle
sequence. Just means playing about with the idle worker to extract what
we need from under the mutex, probably calling it i915_gem_park in the
process.
-Chris

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c 
b/drivers/gpu/drm/i915/i915_drv.c
index d354627..2fc9d0e 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1960,6 +1960,9 @@  void i915_reset(struct drm_i915_private *i915)
                 goto error;
         }

+       if (i915->gt.awake)
+               intel_engines_unpark(i915);
+
         i915_queue_hangcheck(i915);

  finish: