diff mbox

Deep color support and bug fixes

Message ID e0d58a$gs691@orsmga002.jf.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson June 24, 2011, 10:24 a.m. UTC 
On Fri, 24 Jun 2011 10:32:16 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> So here goes -depth 30...

So other than a couple of rendering paths where we write 8bpc data into
the depth-30 fb (go flash, go!), X looks good. Textured XVideo should just
work, GLX doesn't advertise a 10-bpc visual or fbconfig, so will only work
if we can use a render copy for copy-swaps.

However, I did need to:

for the kernel to spot the mode switch when starting X. Lack of logging
ftl. ;-)

For confirmation:

PIPEACONF: 0xc0000020 (enabled, active, 10bpc)
TRANSACONF: 0xc0000020 (enable, active)
FDI_RXA_CTL: 0xb0192050 (enable, train pattern not train, port width X4, 10bpc,link_reverse_strap_overwrite no, dmi_link_reverse no, FDI PLL enable,FS ecc disable, FE ecc disable, FS err report disable, FE err report disable,scrambing enable, enhanced framing enable, PCDClk)


Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
But for my review by, I want to see some logging and validation ;-)
-Chris

Comments

Chris Wilson June 24, 2011, 12:46 p.m. UTC | #1 
On Fri, 24 Jun 2011 11:24:08 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, 24 Jun 2011 10:32:16 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > So here goes -depth 30...
> 
> So other than a couple of rendering paths where we write 8bpc data into
> the depth-30 fb (go flash, go!), X looks good.

Looking at the xtrace and what the xserver/ddx is doing, it appears that
flash is b0rked. Quel surprise.
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 9236965..ef4f29c 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -560,7 +560,9 @@  int drm_crtc_helper_set_config(struct drm_mode_set *set)
 			mode_changed = true;
 		} else if (set->fb == NULL) {
 			mode_changed = true;
-		} else
+		} else if (set->fb->depth != set->crtc->fb->depth)
+			mode_changed = true;
+		else
 			fb_changed = true;
 	}