From patchwork Fri Jun 24 10:24:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 915682 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5OAOWSK011662 for ; Fri, 24 Jun 2011 10:24:54 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D784A0882 for ; Fri, 24 Jun 2011 03:24:31 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 05B99A0955 for ; Fri, 24 Jun 2011 03:24:10 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 24 Jun 2011 03:24:10 -0700 Message-Id: X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,418,1304319600"; d="scan'208";a="17701153" Received: from unknown (HELO cwilso3-mobl.ger.corp.intel.com) ([10.255.17.73]) by orsmga002.jf.intel.com with SMTP; 24 Jun 2011 03:24:08 -0700 Received: by cwilso3-mobl.ger.corp.intel.com (sSMTP sendmail emulation); Fri, 24 Jun 2011 11:24:08 +0100 Date: Fri, 24 Jun 2011 11:24:08 +0100 To: Jesse Barnes , intel-gfx@lists.freedesktop.org References: <1305136090-5858-1-git-send-email-jbarnes@virtuousgeek.org> From: Chris Wilson In-Reply-To: Subject: Re: [Intel-gfx] Deep color support and bug fixes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 24 Jun 2011 10:24:54 +0000 (UTC) On Fri, 24 Jun 2011 10:32:16 +0100, Chris Wilson wrote: > So here goes -depth 30... So other than a couple of rendering paths where we write 8bpc data into the depth-30 fb (go flash, go!), X looks good. Textured XVideo should just work, GLX doesn't advertise a 10-bpc visual or fbconfig, so will only work if we can use a render copy for copy-swaps. However, I did need to: for the kernel to spot the mode switch when starting X. Lack of logging ftl. ;-) For confirmation: PIPEACONF: 0xc0000020 (enabled, active, 10bpc) TRANSACONF: 0xc0000020 (enable, active) FDI_RXA_CTL: 0xb0192050 (enable, train pattern not train, port width X4, 10bpc,link_reverse_strap_overwrite no, dmi_link_reverse no, FDI PLL enable,FS ecc disable, FE ecc disable, FS err report disable, FE err report disable,scrambing enable, enhanced framing enable, PCDClk) Tested-by: Chris Wilson But for my review by, I want to see some logging and validation ;-) -Chris diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 9236965..ef4f29c 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -560,7 +560,9 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) mode_changed = true; } else if (set->fb == NULL) { mode_changed = true; - } else + } else if (set->fb->depth != set->crtc->fb->depth) + mode_changed = true; + else fb_changed = true; }